Core - PermissionHandler followup

amaitland · amaitland · commit 1ae9e01b41c8 · 2022-08-08T14:18:54.000+10:00
- Rename enums (remove cef prefix)
- Fix typos
- Slightly improve docs
diff --git a/CefSharp.Core.Runtime/Internals/CefMediaAccessCallbackWrapper.h b/CefSharp.Core.Runtime/Internals/CefMediaAccessCallbackWrapper.h
@@ -45,7 +45,7 @@ namespace CefSharp
                 delete this;
             }
 
-            virtual void Continue(CefMediaAccessPermissionType allowedPermissions)
+            virtual void Continue(MediaAccessPermissionType allowedPermissions)
             {
                 ThrowIfDisposed();
 
diff --git a/CefSharp.Core.Runtime/Internals/CefPermissionPromptCallbackWrapper.h b/CefSharp.Core.Runtime/Internals/CefPermissionPromptCallbackWrapper.h
@@ -36,7 +36,7 @@ namespace CefSharp
                 _disposed = true;
             }
 
-            virtual void Continue(CefPermissionResult result)
+            virtual void Continue(PermissionRequestResult result)
             {
                 ThrowIfDisposed();
 
diff --git a/CefSharp.Core.Runtime/Internals/ClientAdapter.cpp b/CefSharp.Core.Runtime/Internals/ClientAdapter.cpp
@@ -1194,7 +1194,7 @@ namespace CefSharp
                 auto browserWrapper = GetBrowserWrapper(browser->GetIdentifier(), browser->IsPopup());
                 auto callbackWrapper = gcnew CefPermissionPromptCallbackWrapper(callback);
 
-                return handler->OnShowPermissionPrompt(_browserControl, browserWrapper, prompt_id, StringUtils::ToClr(requesting_origin), (CefPermissionType)requested_permissions, callbackWrapper);
+                return handler->OnShowPermissionPrompt(_browserControl, browserWrapper, prompt_id, StringUtils::ToClr(requesting_origin), (PermissionRequestType)requested_permissions, callbackWrapper);
             }
 
             return false;
@@ -1208,7 +1208,7 @@ namespace CefSharp
             {
                 auto browserWrapper = GetBrowserWrapper(browser->GetIdentifier(), browser->IsPopup());
 
-                handler->OnDismissPermissionPrompt(_browserControl, browserWrapper, prompt_id, (CefPermissionResult)result);
+                handler->OnDismissPermissionPrompt(_browserControl, browserWrapper, prompt_id, (PermissionRequestResult)result);
             }
         }
 
@@ -1223,7 +1223,7 @@ namespace CefSharp
                 CefFrameWrapper frameWrapper(frame);
                 auto callbackWrapper = gcnew CefMediaAccessCallbackWrapper(callback);
 
-                return handler->OnRequestMediaAccessPermission(_browserControl, browserWrapper, %frameWrapper, StringUtils::ToClr(requesting_origin), (CefMediaAccessPermissionType)requested_permissions, callbackWrapper);
+                return handler->OnRequestMediaAccessPermission(_browserControl, browserWrapper, %frameWrapper, StringUtils::ToClr(requesting_origin), (MediaAccessPermissionType)requested_permissions, callbackWrapper);
             }
             return false;
         }
diff --git a/CefSharp.Example/Handlers/PermissionHandlerExample.cs b/CefSharp.Example/Handlers/PermissionHandlerExample.cs
@@ -8,29 +8,29 @@ namespace CefSharp.Example.Handlers
 {
     public class PermissionHandlerExample : PermissionHandler
     {
-        protected override bool OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, CefPermissionType requestedPermissions, IPermissionPromptCallback callback)
+        protected override bool OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, PermissionRequestType requestedPermissions, IPermissionPromptCallback callback)
         {
             using (callback)
             {
                 System.Diagnostics.Debug.WriteLine($"{promptId}|{requestedPermissions} {requestingOrigin}");
-                callback.Continue(CefPermissionResult.Accept);
+                callback.Continue(PermissionRequestResult.Accept);
                 return true;
             }
         }
 
-        protected override void OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, CefPermissionResult result)
+        protected override void OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, PermissionRequestResult result)
         {
             base.OnDismissPermissionPrompt(chromiumWebBrowser, browser, promptId, result);
         }
 
-        protected override bool OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, CefMediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback)
+        protected override bool OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, MediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback)
         {
             using (callback)
             {
-                callback.Continue(CefMediaAccessPermissionType.AudioCapture |
-                                  CefMediaAccessPermissionType.VideoCapture |
-                                  CefMediaAccessPermissionType.DesktopVideoCapture |
-                                  CefMediaAccessPermissionType.DesktopAudioCapture);
+                callback.Continue(MediaAccessPermissionType.AudioCapture |
+                                  MediaAccessPermissionType.VideoCapture |
+                                  MediaAccessPermissionType.DesktopVideoCapture |
+                                  MediaAccessPermissionType.DesktopAudioCapture);
                 return true;
             }
         }
diff --git a/CefSharp/Callback/IMediaAccessCallback.cs b/CefSharp/Callback/IMediaAccessCallback.cs
@@ -20,7 +20,7 @@ public interface IMediaAccessCallback : IDisposable
         /// <see cref="IPermissionHandler.OnRequestMediaAccessPermission"/>
         /// </summary>
         /// <param name="allowedPermissions">Allowed Permissions</param>
-        void Continue(CefMediaAccessPermissionType allowedPermissions);
+        void Continue(MediaAccessPermissionType allowedPermissions);
 
         /// <summary>
         /// Cancel the media access request.
diff --git a/CefSharp/Callback/IPermissionPromptCallback.cs b/CefSharp/Callback/IPermissionPromptCallback.cs
@@ -15,6 +15,6 @@ public interface IPermissionPromptCallback : IDisposable
         /// Complete the permissions request with the specified result.
         /// </summary>
         /// <param name="result">Permission request results.</param>
-        void Continue(CefPermissionResult result);
+        void Continue(PermissionRequestResult result);
     }
 }
diff --git a/CefSharp/DevTools/DevToolsDomainBase.cs b/CefSharp/DevTools/DevToolsDomainBase.cs
@@ -100,7 +100,7 @@ protected IEnumerable<string> EnumToString(ContentEncoding[] values)
             }
         }
 
-        protected IEnumerable<string> EnumToString(PermissionType[] values)
+        protected IEnumerable<string> EnumToString(Browser.PermissionType[] values)
         {
             foreach (var val in values)
             {
diff --git a/CefSharp/Enums/MediaAccessPermissionType.cs b/CefSharp/Enums/MediaAccessPermissionType.cs
@@ -7,10 +7,10 @@
 namespace CefSharp
 {
     /// <summary>
-    /// Media access permissions used by OnRequestMediaAccessPermission.
+    /// Media access permissions used by <see cref="IPermissionHandler.OnRequestMediaAccessPermission(IWebBrowser, IBrowser, IFrame, string, MediaAccessPermissionType, IMediaAccessCallback)"/>.
     /// </summary>
     [Flags]
-    public enum CefMediaAccessPermissionType : uint
+    public enum MediaAccessPermissionType : uint
     {
         /// <summary>
         ///  No permission.
diff --git a/CefSharp/Enums/PermissionRequestResult.cs b/CefSharp/Enums/PermissionRequestResult.cs
@@ -7,7 +7,7 @@ namespace CefSharp
     /// <summary>
     /// Permission request results.
     /// </summary>
-    public enum CefPermissionResult : uint
+    public enum PermissionRequestResult : uint
     {
         /// <summary>
         /// Accept the permission request as an explicit user action.
diff --git a/CefSharp/Enums/PermissionRequestType.cs b/CefSharp/Enums/PermissionRequestType.cs
@@ -7,15 +7,15 @@
 namespace CefSharp
 {
     /// <summary>
-    /// Permission types used with OnShowPermissionPrompt. Some types are
-    /// platform-specific or only supported with the Chrome runtime. Should be kept
+    /// Permission types used with <see cref="IPermissionHandler.OnShowPermissionPrompt(IWebBrowser, IBrowser, ulong, string, PermissionRequestType, IPermissionPromptCallback)"/>.
+    /// Some types are platform-specific or only supported with the Chrome runtime. Should be kept
     /// in sync with Chromium's permissions::RequestType type.
     /// </summary>
     [Flags]
-    public enum CefPermissionType : uint
+    public enum PermissionRequestType : uint
     {
         None = 0,
-        AccessibiLityEvents = 1 << 0,
+        AccessibilityEvents = 1 << 0,
         ArSession = 1 << 1,
         CameraPanTiltZoom = 1 << 2,
         CameraStream = 1 << 3,
@@ -34,6 +34,6 @@ public enum CefPermissionType : uint
         StorageAccess = 1 << 16,
         U2FApiRequest = 1 << 17,
         VrSession = 1 << 18,
-        Windowplacement = 1 << 19
+        WindowPlacement = 1 << 19
     }
 }
diff --git a/CefSharp/Handler/IPermissionHandler.cs b/CefSharp/Handler/IPermissionHandler.cs
@@ -27,7 +27,7 @@ public interface IPermissionHandler
         /// <returns>Return true and call CefMediaAccessCallback methods either in this method or at a later time to continue or cancel the request.
         /// Return false to proceed with default handling.
         /// </returns>
-        bool OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, CefMediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback);
+        bool OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, MediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback);
 
         /// <summary>
         /// Called when a page should show a permission prompt.
@@ -36,27 +36,28 @@ public interface IPermissionHandler
         /// <param name="browser">The browser object</param>
         /// <param name="promptId">Uniquely identifies the prompt.</param>
         /// <param name="requestingOrigin">Is the URL origin requesting permission.</param>
-        /// <param name="requestedPermissions">Is a combination of values from CefPermissionType that represent the requested permissions.</param>
+        /// <param name="requestedPermissions">Is a combination of values from <see cref="PermissionRequestType"/> that represent the requested permissions.</param>
         /// <param name="callback">Callback interface used for asynchronous continuation of permission prompts.</param>
-        /// <returns>Return true and call <see cref="IPermissionPromptCallback.Continue"/> either in this method or at a later time to continue or cancel the request.
+        /// <returns>
+        /// Return true and call <see cref="IPermissionPromptCallback.Continue"/> either in this method or at a later time to continue or cancel the request.
         /// Return false to proceed with default handling.
-        /// With the Chrome runtime, default handling
-        /// will display the permission prompt UI. With the Alloy runtime, default
-        /// handling is <see cref="CefPermissionResult.Ignore"/>.</returns>
-        bool OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, CefPermissionType requestedPermissions, IPermissionPromptCallback callback);
+        /// With the Chrome runtime, default handling will display the permission prompt UI.
+        /// With the Alloy runtime, default handling is <see cref="PermissionRequestResult.Ignore"/>.
+        /// </returns>
+        bool OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, PermissionRequestType requestedPermissions, IPermissionPromptCallback callback);
 
         /// <summary>
         /// Called when a permission prompt handled via <see cref="OnShowPermissionPrompt"/> is dismissed.
         /// <paramref name="result"/> will be the value passed to
-        /// <see cref="IPermissionPromptCallback.Continue"/> or <see cref="CefPermissionResult.Ignore"/> if
+        /// <see cref="IPermissionPromptCallback.Continue"/> or <see cref="PermissionRequestResult.Ignore"/> if
         /// the dialog was dismissed for other reasons such as navigation, browser
         /// closure, etc. This method will not be called if <see cref="OnShowPermissionPrompt"/>
         /// returned false for <paramref name="promptId"/>.
         /// </summary>
         /// <param name="chromiumWebBrowser">The ChromiumWebBrowser control</param>
         /// <param name="browser">The browser object</param>
         /// <param name="promptId">Will match the value that was passed to <see cref="OnShowPermissionPrompt"/>.</param>
-        /// <param name="result">will be the value passed to <see cref="IPermissionPromptCallback.Continue"/> or <see cref="CefPermissionResult.Ignore"/> if the dialog was dismissed for other reasons such as navigation, browser closure, etc. This method will not be called if <see cref="OnShowPermissionPrompt"/> returned false for <paramref name="promptId"/>.</param>
-        void OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, CefPermissionResult result);
+        /// <param name="result">will be the value passed to <see cref="IPermissionPromptCallback.Continue"/> or <see cref="PermissionRequestResult.Ignore"/> if the dialog was dismissed for other reasons such as navigation, browser closure, etc. This method will not be called if <see cref="OnShowPermissionPrompt"/> returned false for <paramref name="promptId"/>.</param>
+        void OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, PermissionRequestResult result);
     }
 }
diff --git a/CefSharp/Handler/PermissionHandler.cs b/CefSharp/Handler/PermissionHandler.cs
@@ -8,7 +8,7 @@ namespace CefSharp.Handler
     public class PermissionHandler : IPermissionHandler
     {
         ///<inheritdoc/>
-        bool IPermissionHandler.OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, CefMediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback)
+        bool IPermissionHandler.OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, MediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback)
         {
             return OnRequestMediaAccessPermission(chromiumWebBrowser, browser, frame, requestingOrigin, requestedPermissions, callback);
         }
@@ -29,7 +29,7 @@ bool IPermissionHandler.OnRequestMediaAccessPermission(IWebBrowser chromiumWebBr
         /// <returns>Return true and call CefMediaAccessCallback methods either in this method or at a later time to continue or cancel the request.
         /// Return false to proceed with default handling.
         /// </returns>
-        protected virtual bool OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, CefMediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback)
+        protected virtual bool OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, MediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback)
         {
             using (callback)
             {
@@ -38,7 +38,7 @@ protected virtual bool OnRequestMediaAccessPermission(IWebBrowser chromiumWebBro
         }
 
         ///<inheritdoc/>
-        bool IPermissionHandler.OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, CefPermissionType requestedPermissions, IPermissionPromptCallback callback)
+        bool IPermissionHandler.OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, PermissionRequestType requestedPermissions, IPermissionPromptCallback callback)
         {
             return OnShowPermissionPrompt(chromiumWebBrowser, browser, promptId, requestingOrigin, requestedPermissions, callback);
         }
@@ -50,14 +50,14 @@ bool IPermissionHandler.OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, I
         /// <param name="browser">The browser object</param>
         /// <param name="promptId">Uniquely identifies the prompt.</param>
         /// <param name="requestingOrigin">Is the URL origin requesting permission.</param>
-        /// <param name="requestedPermissions">Is a combination of values from CefPermissionType that represent the requested permissions.</param>
+        /// <param name="requestedPermissions">Is a combination of values from <see cref="PermissionRequestType"/> that represent the requested permissions.</param>
         /// <param name="callback">Callback interface used for asynchronous continuation of permission prompts.</param>
         /// <returns>Return true and call <see cref="IPermissionPromptCallback.Continue"/> either in this method or at a later time to continue or cancel the request.
         /// Return false to proceed with default handling.
         /// With the Chrome runtime, default handling
         /// will display the permission prompt UI. With the Alloy runtime, default
-        /// handling is <see cref="CefPermissionResult.Ignore"/>.</returns>
-        protected virtual bool OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, CefPermissionType requestedPermissions, IPermissionPromptCallback callback)
+        /// handling is <see cref="PermissionRequestResult.Ignore"/>.</returns>
+        protected virtual bool OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, PermissionRequestType requestedPermissions, IPermissionPromptCallback callback)
         {
             using (callback)
             {
@@ -66,24 +66,24 @@ protected virtual bool OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IB
         }
 
         ///<inheritdoc/>
-        void IPermissionHandler.OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, CefPermissionResult result)
+        void IPermissionHandler.OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, PermissionRequestResult result)
         {
             OnDismissPermissionPrompt(chromiumWebBrowser, browser, promptId, result);
         }
 
         /// <summary>
         /// Called when a permission prompt handled via <see cref="IPermissionHandler.OnShowPermissionPrompt"/> is dismissed.
         /// <paramref name="result"/> will be the value passed to
-        /// <see cref="IPermissionPromptCallback.Continue"/> or <see cref="CefPermissionResult.Ignore"/> if
+        /// <see cref="IPermissionPromptCallback.Continue"/> or <see cref="PermissionRequestResult.Ignore"/> if
         /// the dialog was dismissed for other reasons such as navigation, browser
         /// closure, etc. This method will not be called if <see cref="IPermissionHandler.OnShowPermissionPrompt"/>
         /// returned false for <paramref name="promptId"/>.
         /// </summary>
         /// <param name="chromiumWebBrowser">The ChromiumWebBrowser control</param>
         /// <param name="browser">The browser object</param>
         /// <param name="promptId">Will match the value that was passed to <see cref="IPermissionHandler.OnShowPermissionPrompt"/>.</param>
-        /// <param name="result">will be the value passed to <see cref="IPermissionPromptCallback.Continue"/> or <see cref="CefPermissionResult.Ignore"/> if the dialog was dismissed for other reasons such as navigation, browser closure, etc. This method will not be called if <see cref="OnShowPermissionPrompt"/> returned false for <paramref name="promptId"/>.</param>
-        protected virtual void OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, CefPermissionResult result)
+        /// <param name="result">will be the value passed to <see cref="IPermissionPromptCallback.Continue"/> or <see cref="PermissionRequestResult.Ignore"/> if the dialog was dismissed for other reasons such as navigation, browser closure, etc. This method will not be called if <see cref="OnShowPermissionPrompt"/> returned false for <paramref name="promptId"/>.</param>
+        protected virtual void OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, PermissionRequestResult result)
         {
 
         }

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ namespace CefSharp`
`45`	`45`	`delete this;`
`46`	`46`	`}`
`47`	`47`
`48`		`- virtual void Continue(CefMediaAccessPermissionType allowedPermissions)`
	`48`	`+ virtual void Continue(MediaAccessPermissionType allowedPermissions)`
`49`	`49`	`{`
`50`	`50`	`ThrowIfDisposed();`
`51`	`51`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ namespace CefSharp`
`36`	`36`	`_disposed = true;`
`37`	`37`	`}`
`38`	`38`
`39`		`- virtual void Continue(CefPermissionResult result)`
	`39`	`+ virtual void Continue(PermissionRequestResult result)`
`40`	`40`	`{`
`41`	`41`	`ThrowIfDisposed();`
`42`	`42`
Original file line number	Diff line number	Diff line change
`@@ -1194,7 +1194,7 @@ namespace CefSharp`
`1194`	`1194`	`auto browserWrapper = GetBrowserWrapper(browser->GetIdentifier(), browser->IsPopup());`
`1195`	`1195`	`auto callbackWrapper = gcnew CefPermissionPromptCallbackWrapper(callback);`
`1196`	`1196`
`1197`		`- return handler->OnShowPermissionPrompt(_browserControl, browserWrapper, prompt_id, StringUtils::ToClr(requesting_origin), (CefPermissionType)requested_permissions, callbackWrapper);`
	`1197`	`+ return handler->OnShowPermissionPrompt(_browserControl, browserWrapper, prompt_id, StringUtils::ToClr(requesting_origin), (PermissionRequestType)requested_permissions, callbackWrapper);`
`1198`	`1198`	`}`
`1199`	`1199`
`1200`	`1200`	`return false;`
`@@ -1208,7 +1208,7 @@ namespace CefSharp`
`1208`	`1208`	`{`
`1209`	`1209`	`auto browserWrapper = GetBrowserWrapper(browser->GetIdentifier(), browser->IsPopup());`
`1210`	`1210`
`1211`		`- handler->OnDismissPermissionPrompt(_browserControl, browserWrapper, prompt_id, (CefPermissionResult)result);`
	`1211`	`+ handler->OnDismissPermissionPrompt(_browserControl, browserWrapper, prompt_id, (PermissionRequestResult)result);`
`1212`	`1212`	`}`
`1213`	`1213`	`}`
`1214`	`1214`
`@@ -1223,7 +1223,7 @@ namespace CefSharp`
`1223`	`1223`	`CefFrameWrapper frameWrapper(frame);`
`1224`	`1224`	`auto callbackWrapper = gcnew CefMediaAccessCallbackWrapper(callback);`
`1225`	`1225`
`1226`		`- return handler->OnRequestMediaAccessPermission(_browserControl, browserWrapper, %frameWrapper, StringUtils::ToClr(requesting_origin), (CefMediaAccessPermissionType)requested_permissions, callbackWrapper);`
	`1226`	`+ return handler->OnRequestMediaAccessPermission(_browserControl, browserWrapper, %frameWrapper, StringUtils::ToClr(requesting_origin), (MediaAccessPermissionType)requested_permissions, callbackWrapper);`
`1227`	`1227`	`}`
`1228`	`1228`	`return false;`
`1229`	`1229`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,29 +8,29 @@ namespace CefSharp.Example.Handlers`
`8`	`8`	`{`
`9`	`9`	`public class PermissionHandlerExample : PermissionHandler`
`10`	`10`	`{`
`11`		`- protected override bool OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, CefPermissionType requestedPermissions, IPermissionPromptCallback callback)`
	`11`	`+ protected override bool OnShowPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, string requestingOrigin, PermissionRequestType requestedPermissions, IPermissionPromptCallback callback)`
`12`	`12`	`{`
`13`	`13`	`using (callback)`
`14`	`14`	`{`
`15`	`15`	`System.Diagnostics.Debug.WriteLine($"{promptId}\|{requestedPermissions} {requestingOrigin}");`
`16`		`- callback.Continue(CefPermissionResult.Accept);`
	`16`	`+ callback.Continue(PermissionRequestResult.Accept);`
`17`	`17`	`return true;`
`18`	`18`	`}`
`19`	`19`	`}`
`20`	`20`
`21`		`- protected override void OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, CefPermissionResult result)`
	`21`	`+ protected override void OnDismissPermissionPrompt(IWebBrowser chromiumWebBrowser, IBrowser browser, ulong promptId, PermissionRequestResult result)`
`22`	`22`	`{`
`23`	`23`	`base.OnDismissPermissionPrompt(chromiumWebBrowser, browser, promptId, result);`
`24`	`24`	`}`
`25`	`25`
`26`		`- protected override bool OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, CefMediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback)`
	`26`	`+ protected override bool OnRequestMediaAccessPermission(IWebBrowser chromiumWebBrowser, IBrowser browser, IFrame frame, string requestingOrigin, MediaAccessPermissionType requestedPermissions, IMediaAccessCallback callback)`
`27`	`27`	`{`
`28`	`28`	`using (callback)`
`29`	`29`	`{`
`30`		`- callback.Continue(CefMediaAccessPermissionType.AudioCapture \|`
`31`		`- CefMediaAccessPermissionType.VideoCapture \|`
`32`		`- CefMediaAccessPermissionType.DesktopVideoCapture \|`
`33`		`- CefMediaAccessPermissionType.DesktopAudioCapture);`
	`30`	`+ callback.Continue(MediaAccessPermissionType.AudioCapture \|`
	`31`	`+ MediaAccessPermissionType.VideoCapture \|`
	`32`	`+ MediaAccessPermissionType.DesktopVideoCapture \|`
	`33`	`+ MediaAccessPermissionType.DesktopAudioCapture);`
`34`	`34`	`return true;`
`35`	`35`	`}`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,6 @@ public interface IPermissionPromptCallback : IDisposable`
`15`	`15`	`/// Complete the permissions request with the specified result.`
`16`	`16`	`/// </summary>`
`17`	`17`	`/// <param name="result">Permission request results.</param>`
`18`		`- void Continue(CefPermissionResult result);`
	`18`	`+ void Continue(PermissionRequestResult result);`
`19`	`19`	`}`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ protected IEnumerable<string> EnumToString(ContentEncoding[] values)`
`100`	`100`	`}`
`101`	`101`	`}`
`102`	`102`
`103`		`- protected IEnumerable<string> EnumToString(PermissionType[] values)`
	`103`	`+ protected IEnumerable<string> EnumToString(Browser.PermissionType[] values)`
`104`	`104`	`{`
`105`	`105`	`foreach (var val in values)`
`106`	`106`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,10 +7,10 @@`
`7`	`7`	`namespace CefSharp`
`8`	`8`	`{`
`9`	`9`	`/// <summary>`
`10`		`- /// Media access permissions used by OnRequestMediaAccessPermission.`
	`10`	`+ /// Media access permissions used by <see cref="IPermissionHandler.OnRequestMediaAccessPermission(IWebBrowser, IBrowser, IFrame, string, MediaAccessPermissionType, IMediaAccessCallback)"/>.`
`11`	`11`	`/// </summary>`
`12`	`12`	`[Flags]`
`13`		`- public enum CefMediaAccessPermissionType : uint`
	`13`	`+ public enum MediaAccessPermissionType : uint`
`14`	`14`	`{`
`15`	`15`	`/// <summary>`
`16`	`16`	`/// No permission.`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ namespace CefSharp`
`7`	`7`	`/// <summary>`
`8`	`8`	`/// Permission request results.`
`9`	`9`	`/// </summary>`
`10`		`- public enum CefPermissionResult : uint`
	`10`	`+ public enum PermissionRequestResult : uint`
`11`	`11`	`{`
`12`	`12`	`/// <summary>`
`13`	`13`	`/// Accept the permission request as an explicit user action.`