Skip to content

Commit 249a491

Browse files
authored
Update some leftover net core 3.1 references (#5143)
1 parent 633a8cd commit 249a491

File tree

13 files changed

+57
-58
lines changed

13 files changed

+57
-58
lines changed

.vsconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
"Microsoft.VisualStudio.Component.VC.CLI.Support",
2727
"Microsoft.VisualStudio.Component.Windows10SDK.19041",
2828
"Microsoft.VisualStudio.Workload.NativeDesktop",
29-
"Microsoft.NetCore.Component.DevelopmentTools",
30-
"Microsoft.NetCore.Component.Runtime.3.1",
29+
"Microsoft.NetCore.Component.DevelopmentTools",
30+
"Microsoft.NetCore.Component.Runtime.6.0",
3131
"Microsoft.NetCore.Component.SDK"
3232
]
3333
}

CefSharp.BrowserSubprocess/CefSharp.BrowserSubprocess.netcore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<!-- Explicitly set the PlatformTarget for arm64, see: https://github.com/dotnet/sdk/issues/15434 -->
2626
<PlatformTarget Condition="'$(Platform)' == 'arm64'">arm64</PlatformTarget>
2727
<!--
28-
Run on a newer version of .Net if the specified version (.Net Core 3.1) is not installed
28+
Run on a newer version of .Net if the specified version (.Net 6) is not installed
2929
https://github.com/dotnet/docs/issues/12237
3030
-->
3131
<RollForward>Major</RollForward>

CefSharp.BrowserSubprocess/Program.netcore.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace CefSharp.BrowserSubprocess
99
{
1010
/// <summary>
1111
/// When implementing your own BrowserSubprocess
12-
/// - For .Net Core use <see cref="BrowserSubprocessExecutable"/> (No WCF Support)
12+
/// - For .Net use <see cref="BrowserSubprocessExecutable"/> (No WCF Support)
1313
/// - Include an app.manifest with the dpi/compatability sections, this is required (this project contains the relevant).
1414
/// - If you are targeting x86/Win32 then you should set /LargeAddressAware (https://docs.microsoft.com/en-us/cpp/build/reference/largeaddressaware?view=vs-2017)
1515
/// </summary>

CefSharp.Example/CefExample.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ public static void Init(CefSettingsBase settings, IBrowserProcessHandler browser
165165
{
166166
var architecture = RuntimeInformation.ProcessArchitecture.ToString().ToLowerInvariant();
167167
#if NETCOREAPP
168-
settings.BrowserSubprocessPath = Path.GetFullPath("..\\..\\..\\..\\..\\..\\CefSharp.BrowserSubprocess\\bin.netcore\\" + architecture + "\\Debug\\netcoreapp3.1\\CefSharp.BrowserSubprocess.exe");
168+
settings.BrowserSubprocessPath = Path.GetFullPath("..\\..\\..\\..\\..\\..\\CefSharp.BrowserSubprocess\\bin.netcore\\" + architecture + "\\Debug\\net6.0-windows\\CefSharp.BrowserSubprocess.exe");
169169
#else
170170
settings.BrowserSubprocessPath = Path.GetFullPath("..\\..\\..\\..\\CefSharp.BrowserSubprocess\\bin\\" + architecture + "\\Debug\\CefSharp.BrowserSubprocess.exe");
171171
#endif

CefSharp.OffScreen.Example/CefSharp.OffScreen.Example.netcore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<PlatformTarget Condition="'$(Platform)' == 'arm64'">arm64</PlatformTarget>
2323
<StartupObject>CefSharp.OffScreen.Example.Program</StartupObject>
2424
<!--
25-
Run on a newer version of .Net if the specified version (.Net Core 3.1) is not installed
25+
Run on a newer version of .Net if the specified version (.Net 6) is not installed
2626
https://github.com/dotnet/docs/issues/12237
2727
-->
2828
<RollForward>Major</RollForward>

CefSharp.WinForms.Example/CefSharp.WinForms.Example.netcore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<!-- Explicitly set the PlatformTarget for arm64, see: https://github.com/dotnet/sdk/issues/15434 -->
2323
<PlatformTarget Condition="'$(Platform)' == 'arm64'">arm64</PlatformTarget>
2424
<!--
25-
Run on a newer version of .Net if the specified version (.Net Core 3.1) is not installed
25+
Run on a newer version of .Net if the specified version (.Net 6) is not installed
2626
https://github.com/dotnet/docs/issues/12237
2727
-->
2828
<RollForward>Major</RollForward>

CefSharp.Wpf.Example/CefSharp.Wpf.Example.netcore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<PlatformTarget Condition="'$(Platform)' == 'arm64'">arm64</PlatformTarget>
2424
<StartupObject>CefSharp.Wpf.Example.Program</StartupObject>
2525
<!--
26-
Run on a newer version of .Net if the specified version (.Net Core 3.1) is not installed
26+
Run on a newer version of .Net if the specified version (.Net 6) is not installed
2727
https://github.com/dotnet/docs/issues/12237
2828
-->
2929
<RollForward>Major</RollForward>

CefSharp.Wpf.HwndHost.Example/CefSharp.Wpf.HwndHost.Example.netcore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<PlatformTarget Condition="'$(Platform)' == 'arm64'">arm64</PlatformTarget>
2525
<StartupObject>CefSharp.Wpf.HwndHost.Example.App</StartupObject>
2626
<!--
27-
Run on a newer version of .Net if the specified version (.Net Core 3.1) is not installed
27+
Run on a newer version of .Net if the specified version (.Net 6) is not installed
2828
https://github.com/dotnet/docs/issues/12237
2929
-->
3030
<RollForward>Major</RollForward>

CefSharp/IJavascriptObjectRepository.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public interface IJavascriptObjectRepository : IDisposable
4141
/// This method is newer and recommended for everyone starting out as it is faster and more reliable.
4242
/// If false then methods and properties will be registered, this method relies on a WCF service to communicate,
4343
/// which is only available when targeting the .NET Framework.
44-
/// This parameter is not available when targeting .NET Core or .NET 5+, where only async binding is supported.
44+
/// This parameter is not available when targeting .NET 6+, where only async binding is supported.
4545
/// </param>
4646
#endif
4747
/// <param name="options">binding options, by default method/property names are camelCased, you can control this

CefSharp/WebBrowserExtensions.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ public static Task<LoadUrlAsyncResponse> LoadUrlAsync(IChromiumWebBrowserBase ch
445445
chromiumWebBrowser.LoadingStateChanged -= loadingStateChangeHandler;
446446

447447
//Ensure our continuation is executed on the ThreadPool
448-
//For the .Net Core implementation we could use
448+
//For the .Net implementation we could use
449449
//TaskCreationOptions.RunContinuationsAsynchronously
450450
tcs.TrySetResult(new LoadUrlAsyncResponse(args.ErrorCode, -1));
451451
};
@@ -476,7 +476,7 @@ public static Task<LoadUrlAsyncResponse> LoadUrlAsync(IChromiumWebBrowserBase ch
476476
}
477477

478478
//Ensure our continuation is executed on the ThreadPool
479-
//For the .Net Core implementation we could use
479+
//For the .Net implementation we could use
480480
//TaskCreationOptions.RunContinuationsAsynchronously
481481
tcs.TrySetResult(new LoadUrlAsyncResponse(statusCode == -1 ? CefErrorCode.Failed : CefErrorCode.None, statusCode));
482482
}
@@ -541,7 +541,7 @@ public static async Task<WaitForNavigationAsyncResponse> WaitForNavigationAsync(
541541
chromiumWebBrowser.LoadingStateChanged -= loadingStateChangeHandler;
542542

543543
//Ensure our continuation is executed on the ThreadPool
544-
//For the .Net Core implementation we could use
544+
//For the .Net implementation we could use
545545
//TaskCreationOptions.RunContinuationsAsynchronously
546546
tcs.TrySetResult(new WaitForNavigationAsyncResponse(args.ErrorCode, -1));
547547
};
@@ -572,7 +572,7 @@ public static async Task<WaitForNavigationAsyncResponse> WaitForNavigationAsync(
572572
}
573573

574574
//Ensure our continuation is executed on the ThreadPool
575-
//For the .Net Core implementation we could use
575+
//For the .Net implementation we could use
576576
//TaskCreationOptions.RunContinuationsAsynchronously
577577
tcs.TrySetResult(new WaitForNavigationAsyncResponse(statusCode == -1 ? CefErrorCode.Failed : CefErrorCode.None, statusCode));
578578
}

0 commit comments

Comments
 (0)