Skip to content

Commit 27f1ff1

Browse files
merceyzamaitland
authored andcommitted
Core - BrowserSettings: Fixed a memory leak (#2669)
* Core - BrowserSettings: Fixed memory leak * Core - BrowserSettings: Only delete if we created the instance * Core - BrowserSettings: Always set pointer to null * Update BrowserSettings.h
1 parent f3877be commit 27f1ff1

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

CefSharp.Core/BrowserSettings.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ namespace CefSharp
2020
{
2121
private:
2222
bool _isDisposed = false;
23+
bool _ownsPointer = false;
2324
internal:
2425
CefBrowserSettings* _browserSettings;
2526

@@ -37,10 +38,16 @@ namespace CefSharp
3738
/// </summary>
3839
BrowserSettings() : _browserSettings(new CefBrowserSettings())
3940
{
41+
_ownsPointer = true;
4042
}
4143

4244
!BrowserSettings()
4345
{
46+
if (_ownsPointer)
47+
{
48+
delete _browserSettings;
49+
}
50+
4451
_browserSettings = NULL;
4552
_isDisposed = true;
4653
}

0 commit comments

Comments
 (0)