Skip to content

Commit 2a94e8a

Browse files
committed
Core - Update ContextMenuMediaState values to match Chromium
- Enum updated - Other enum values added to related enums Resolves #4014
1 parent 26f415f commit 2a94e8a

File tree

4 files changed

+29
-7
lines changed

4 files changed

+29
-7
lines changed

CefSharp/Enums/CefMenuCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ public enum CefMenuCommand
3939
AddToDictionary = 206,
4040

4141
/// <summary>
42-
/// Custom menu items originating from the renderer process. For example, plugin placeholder menu items or Flash menu items.
42+
/// Custom menu items originating from the renderer process
4343
/// This is the first entry
4444
/// </summary>
4545
CustomFirst = 220,
4646
/// <summary>
47-
/// Custom menu items originating from the renderer process. For example, plugin placeholder menu items or Flash menu items.
47+
/// Custom menu items originating from the renderer process
4848
/// This is the last entry
4949
/// </summary>
5050
CustomLast = 250,

CefSharp/Enums/ContextMenuEditState.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,5 +48,9 @@ public enum ContextMenuEditState
4848
/// A binary constant representing the can translate flag.
4949
/// </summary>
5050
CanTranslate = 1 << 7,
51+
/// <summary>
52+
/// A binary constant representing the can edit richly flag.
53+
/// </summary>
54+
CanEditRichly = 1 << 8,
5155
}
5256
}

CefSharp/Enums/ContextMenuMediaState.cs

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
namespace CefSharp
88
{
99
/// <summary>
10-
/// Supported context menu media state bit flags.
10+
/// Supported context menu media state bit flags. These constants match their
11+
/// equivalents in Chromium's ContextMenuData::MediaFlags and should not be
12+
/// renumbered.
1113
/// </summary>
1214
[Flags]
1315
public enum ContextMenuMediaState
@@ -41,13 +43,13 @@ public enum ContextMenuMediaState
4143
/// </summary>
4244
HasAudio = 1 << 5,
4345
/// <summary>
44-
/// HasVideo
46+
/// Can Toggle Controls
4547
/// </summary>
46-
HasVideo = 1 << 6,
48+
CanToggleControls = 1 << 6,
4749
/// <summary>
48-
/// ControlRootElement
50+
/// Controls
4951
/// </summary>
50-
ControlRootElement = 1 << 7,
52+
Controls = 1 << 7,
5153
/// <summary>
5254
/// CanPrint
5355
/// </summary>
@@ -56,5 +58,17 @@ public enum ContextMenuMediaState
5658
/// CanRotate
5759
/// </summary>
5860
CanRotate = 1 << 9,
61+
/// <summary>
62+
/// CanPictureInPicture
63+
/// </summary>
64+
CanPictureInPicture = 1 << 10,
65+
/// <summary>
66+
/// PictureInPicture
67+
/// </summary>
68+
PictureInPicture = 1 << 11,
69+
/// <summary>
70+
/// CanLoop
71+
/// </summary>
72+
CanLoop = 1 << 12,
5973
}
6074
}

CefSharp/Enums/ContextMenuMediaType.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ public enum ContextMenuMediaType
2626
/// </summary>
2727
Audio,
2828
/// <summary>
29+
/// An canvas node is selected
30+
/// </summary>
31+
Canvas,
32+
/// <summary>
2933
/// A file node is selected.
3034
/// </summary>
3135
File,

0 commit comments

Comments
 (0)