CefTime.GetDoubleT returns invalid .Net date

Issue #2283

Author: amaitland

CefSharp.BrowserSubprocess.Core/TypeUtils.cpp

@@ -254,7 +254,13 @@ namespace CefSharp
 
     DateTime TypeUtils::ConvertCefTimeToDateTime(CefTime time)
     {
-        return DateTimeUtils::FromCefTime(time.GetDoubleT());
+        return DateTimeUtils::FromCefTime(time.year,
+            time.month,
+            time.day_of_month,
+            time.hour,
+            time.minute,
+            time.second,
+            time.millisecond);
     }
 
     CefTime TypeUtils::ConvertDateTimeToCefTime(DateTime dateTime)

CefSharp.Core/Internals/CookieVisitor.cpp

@@ -23,11 +23,34 @@ namespace CefSharp
 
             if (cefCookie.has_expires)
             {
-                cookie->Expires = DateTimeUtils::FromCefTime(CefTime(cefCookie.expires).GetDoubleT());
+                auto expires = cefCookie.expires;
+                cookie->Expires = DateTimeUtils::FromCefTime(expires.year,
+                    expires.month,
+                    expires.day_of_month,
+                    expires.hour,
+                    expires.minute,
+                    expires.second,
+                    expires.millisecond);
             }
 
-            cookie->Creation = DateTimeUtils::FromCefTime(CefTime(cefCookie.creation).GetDoubleT());
-            cookie->LastAccess = DateTimeUtils::FromCefTime(CefTime(cefCookie.last_access).GetDoubleT());
+
+            auto creation = cefCookie.creation;
+            cookie->Creation = DateTimeUtils::FromCefTime(creation.year,
+                creation.month,
+                creation.day_of_month,
+                creation.hour,
+                creation.minute,
+                creation.second,
+                creation.millisecond);
+
+            auto lastAccess = cefCookie.last_access;
+            cookie->LastAccess = DateTimeUtils::FromCefTime(lastAccess.year,
+                lastAccess.month,
+                lastAccess.day_of_month,
+                lastAccess.hour,
+                lastAccess.minute,
+                lastAccess.second,
+                lastAccess.millisecond);
         }
 
         return _visitor->Visit(cookie, count, total, deleteCookie);

CefSharp.Core/ResourceHandlerWrapper.cpp

@@ -79,11 +79,33 @@ namespace CefSharp
 
             if (cefCookie.has_expires)
             {
-                cookie->Expires = DateTimeUtils::FromCefTime(CefTime(cefCookie.expires).GetDoubleT());
+                auto expires = cefCookie.expires;
+                cookie->Expires = DateTimeUtils::FromCefTime(expires.year,
+                    expires.month,
+                    expires.day_of_month,
+                    expires.hour,
+                    expires.minute,
+                    expires.second,
+                    expires.millisecond);
             }
-            
-            cookie->Creation = DateTimeUtils::FromCefTime(CefTime(cefCookie.creation).GetDoubleT());
-            cookie->LastAccess = DateTimeUtils::FromCefTime(CefTime(cefCookie.last_access).GetDoubleT());
+
+            auto creation = cefCookie.creation;
+            cookie->Creation = DateTimeUtils::FromCefTime(creation.year,
+                creation.month,
+                creation.day_of_month,
+                creation.hour,
+                creation.minute,
+                creation.second,
+                creation.millisecond);
+
+            auto lastAccess = cefCookie.last_access;
+            cookie->LastAccess = DateTimeUtils::FromCefTime(lastAccess.year,
+                lastAccess.month,
+                lastAccess.day_of_month,
+                lastAccess.hour,
+                lastAccess.minute,
+                lastAccess.second,
+                lastAccess.millisecond);
         }
 
         return cookie;

CefSharp/Internals/DateTimeUtils.cs

@@ -12,17 +12,26 @@ public static class DateTimeUtils
         private static DateTime FirstOfTheFirstNineteenSeventy = new DateTime(1970, 1, 1, 0, 0, 0);
 
         /// <summary>
-        /// Takes the epoch and creates a <see cref="DateTime"/>
+        /// Converts a cef
         /// </summary>
-        /// <param name="epoch">cef datetime represented as difference between 01/01/1970</param>
-        /// <returns></returns>
-        public static DateTime FromCefTime(double epoch)
+        /// <param name="year">year</param>
+        /// <param name="month">month</param>
+        /// <param name="day">day</param>
+        /// <param name="hour">hour</param>
+        /// <param name="minute">minute</param>
+        /// <param name="second">second</param>
+        /// <param name="millisecond">millisecond</param>
+        /// <returns>DateTime</returns>
+        public static DateTime FromCefTime(int year, int month, int day, int hour, int minute, int second, int millisecond)
         {
-            if (epoch > 0)
+            try
             {
-                return FirstOfTheFirstNineteenSeventy.AddSeconds(epoch).ToLocalTime();
+                return new DateTime(year, month, day, hour, minute, second, millisecond);
+            }
+            catch(Exception)
+            {
+                return DateTime.MinValue;
             }
-            return DateTime.MinValue;
         }
 
         /// <summary>