Skip to content

Commit 43321f7

Browse files
committed
WinForms/WPF/OffScreen - Change to using Chrome bootstrap by default
Issue #4835
1 parent ed6a983 commit 43321f7

File tree

8 files changed

+9
-9
lines changed

8 files changed

+9
-9
lines changed

CefSharp.Example/CefExample.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,6 @@ public static void Init(CefSettingsBase settings, IBrowserProcessHandler browser
161161

162162
//settings.LogSeverity = LogSeverity.Verbose;
163163

164-
//Experimental setting see https://github.com/chromiumembedded/cef/issues/2969
165-
//for details
166-
//settings.ChromeRuntime = true;
167-
168164
if (DebuggingSubProcess)
169165
{
170166
var architecture = RuntimeInformation.ProcessArchitecture.ToString().ToLowerInvariant();

CefSharp.OffScreen.Example/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ public static int Main(string[] args)
3535
Cef.EnableWaitForBrowsersToClose();
3636

3737
var settings = new CefSettings();
38-
settings.ChromeRuntime = true;
3938
//The location where cache data will be stored on disk. If empty an in-memory cache will be used for some features and a temporary disk cache for others.
4039
//HTML5 databases such as localStorage will only persist across sessions if a cache path is specified.
4140
settings.CachePath = Path.GetFullPath("cache");

CefSharp.OffScreen/CefSettings.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ public class CefSettings : CefSettingsBase
1616
public CefSettings() : base()
1717
{
1818
WindowlessRenderingEnabled = true;
19+
ChromeRuntime = true;
1920

2021
//For OffScreen it doesn't make much sense to enable audio by default, so we disable it.
2122
//this can be removed in user code if required

CefSharp.Test/CefSharpFixture.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ private void CefInitialize()
5656
//HTML5 databases such as localStorage will only persist across sessions if a cache path is specified.
5757
settings.CachePath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), "CefSharp\\Tests\\Cache");
5858
settings.RootCachePath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), "CefSharp\\Tests");
59-
settings.ChromeRuntime = true;
6059
//settings.CefCommandLineArgs.Add("renderer-startup-dialog");
6160
//settings.CefCommandLineArgs.Add("disable-site-isolation-trials");
6261

CefSharp.WinForms.Example/Program.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ public static int Main(string[] args)
4141

4242
var settings = new CefSettings();
4343
settings.BrowserSubprocessPath = System.IO.Path.GetFullPath("CefSharp.WinForms.Example.exe");
44-
settings.ChromeRuntime = true;
4544

4645
Cef.Initialize(settings);
4746

@@ -96,7 +95,6 @@ public static int Main(string[] args)
9695
var settings = new CefSettings();
9796
settings.MultiThreadedMessageLoop = multiThreadedMessageLoop;
9897
settings.ExternalMessagePump = externalMessagePump;
99-
settings.ChromeRuntime = true;
10098

10199
CefExample.Init(settings, browserProcessHandler: browserProcessHandler);
102100

CefSharp.WinForms/CefSettings.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,12 @@ namespace CefSharp.WinForms
1010
/// </summary>
1111
public class CefSettings : CefSettingsBase
1212
{
13+
/// <summary>
14+
/// Intialize with default values
15+
/// </summary>
16+
public CefSettings() : base()
17+
{
18+
ChromeRuntime = true;
19+
}
1320
}
1421
}

CefSharp.Wpf.Example/App.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ protected override void OnStartup(StartupEventArgs e)
4141
var settings = new CefSettings();
4242
settings.MultiThreadedMessageLoop = multiThreadedMessageLoop;
4343
settings.ExternalMessagePump = !multiThreadedMessageLoop;
44-
settings.ChromeRuntime = true;
4544

4645
CefExample.Init(settings, browserProcessHandler: browserProcessHandler);
4746

CefSharp.Wpf/CefSettings.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ public class CefSettings : CefSettingsBase
1616
public CefSettings() : base()
1717
{
1818
WindowlessRenderingEnabled = true;
19+
ChromeRuntime = true;
1920

2021
//Disable multithreaded, compositor scrolling of web content
2122
//With OSR rendering it's fairly common for this to improve scrolling performace

0 commit comments

Comments
 (0)