RequestContext.cpp - LoadExtension resolve issues with CefPostTask

For the x86 version we define and undefine CEF_INCLUDE_BASE_INTERNAL_CEF_BIND_INTERNAL_WIN_H_
as the /clr compliation option attempts to be helpful and convers all the __fastcall versions
to __stdcall which already exist, so we just use the standard calling convention and ignore
the optimised ones. The original error is
warning C4561: '__fastcall' incompatible with the '/clr' option: converting to '__stdcall'
(compiling source file RequestContext.cpp)

Author: amaitland

CefSharp.Core/RequestContext.cpp

@@ -6,9 +6,18 @@
 #include "RequestContext.h"
 
 #include "include\cef_parser.h"
+
+//For the x86 version we define and undefine CEF_INCLUDE_BASE_INTERNAL_CEF_BIND_INTERNAL_WIN_H_
+//as the /clr compliation option attempts to be helpful and convers all the __fastcall versions
+//to __stdcall which already exist, so we just use the standard calling convention and ignore
+//the optimised ones. The original error is
+//warning C4561: '__fastcall' incompatible with the '/clr' option: converting to '__stdcall'
+//(compiling source file RequestContext.cpp) 
+#define CEF_INCLUDE_BASE_INTERNAL_CEF_BIND_INTERNAL_WIN_H_
 #include "include\base\cef_bind.h"
-#include "include\wrapper\cef_closure_task.h"
+#undef CEF_INCLUDE_BASE_INTERNAL_CEF_BIND_INTERNAL_WIN_H_
 
+#include "include\wrapper\cef_closure_task.h"
 
 #include "CookieManager.h"
 #include "SchemeHandlerFactoryWrapper.h"

CefSharp.WinForms.Example/BrowserForm.cs

@@ -565,38 +565,33 @@ private void LoadExtensionsToolStripMenuItemClick(object sender, EventArgs e)
                         throw new DirectoryNotFoundException("Unable to locate example extensions folder - " + dir);
                     }
 
-                    Cef.UIThreadTaskFactory.StartNew(() =>
+                    var extensionHandler = new ExtensionHandler
                     {
-                        var extensionHandler = new ExtensionHandler
+                        LoadExtensionPopup = (url) =>
                         {
-                            LoadExtensionPopup = (url) =>
+                            BeginInvoke(new Action(() =>
                             {
-                                BeginInvoke(new Action(() =>
-                                {
-                                    var extensionForm = new Form();
+                                var extensionForm = new Form();
 
-                                    var extensionBrowser = new ChromiumWebBrowser(url);
+                                var extensionBrowser = new ChromiumWebBrowser(url);
                                 //extensionBrowser.IsBrowserInitializedChanged += (s, args) =>
                                 //{
                                 //    extensionBrowser.ShowDevTools();
                                 //};
 
                                 extensionForm.Controls.Add(extensionBrowser);
 
-                                    extensionForm.Show(this);
-                                }));
-                            },
-                            GetActiveBrowser = (extension, isIncognito) =>
-                            {
+                                extensionForm.Show(this);
+                            }));
+                        },
+                        GetActiveBrowser = (extension, isIncognito) =>
+                        {
                             //Return the active browser for which the extension will act upon
                             return control.Browser.GetBrowser();
-                            }
-                        };
-
-                    //requestContext.LoadExtensionFromDirectory(Path.Combine(dir, "set_page_color"), new ExtensionHandler());
+                        }
+                    };
 
                     requestContext.LoadExtensionsFromDirectory(dir, extensionHandler);
-                    });
                 }
                 else
                 {