BrowserSubprocess - TreatWarningAsError for debug builds

Statically cast size_t to int to remove warnings

Author: amaitland

CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.vcxproj

@@ -110,6 +110,7 @@
       <PrecompiledHeader>Use</PrecompiledHeader>
       <BrowseInformation>true</BrowseInformation>
       <MultiProcessorCompilation>true</MultiProcessorCompilation>
+      <TreatWarningAsError>true</TreatWarningAsError>
     </ClCompile>
     <Link>
       <GenerateDebugInformation>true</GenerateDebugInformation>
@@ -126,6 +127,7 @@
       <PreprocessorDefinitions>WIN32;_DEBUG;EXPORT;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <PrecompiledHeader>Use</PrecompiledHeader>
       <MultiProcessorCompilation>true</MultiProcessorCompilation>
+      <TreatWarningAsError>true</TreatWarningAsError>
     </ClCompile>
     <Link>
       <GenerateDebugInformation>true</GenerateDebugInformation>

CefSharp.BrowserSubprocess.Core/JavascriptMethodHandler.cpp

@@ -12,9 +12,10 @@ namespace CefSharp
     {
         bool JavascriptMethodHandler::Execute(const CefString& name, CefRefPtr<CefV8Value> object, const CefV8ValueList& arguments, CefRefPtr<CefV8Value>& retval, CefString& exception)
         {
-            auto parameter = gcnew array<Object^>(arguments.size());
+            auto size = static_cast<int>(arguments.size());
+            auto parameter = gcnew array<Object^>(size);
 
-            for (std::vector<CefRefPtr<CefV8Value>>::size_type i = 0; i != arguments.size(); i++)
+            for (int i = 0; i < size; i++)
             {
                 parameter[i] = TypeUtils::ConvertFromCef(arguments[i], _callbackRegistry);
             }

CefSharp.BrowserSubprocess.Core/Serialization/JsObjectsSerialization.cpp

@@ -70,7 +70,9 @@ namespace CefSharp
             {
                 auto result = gcnew List<JavascriptObject^>();
                 auto subList = list->GetList(index);
-                for (size_t i = 0; i < subList->GetSize(); i++)
+                auto size = static_cast<int>(subList->GetSize());
+
+                for (int i = 0; i < size; i++)
                 {
                     result->Add(DeserializeJsObject(subList, i));
                 }

CefSharp.BrowserSubprocess.Core/Serialization/V8Serialization.cpp

@@ -149,9 +149,9 @@ namespace CefSharp
                 if (type == VTYPE_LIST)
                 {
                     auto subList = list->GetList(index);
-                    size_t size = subList->GetSize();
+                    auto size = static_cast<int>(subList->GetSize());
                     auto result = CefV8Value::CreateArray(size);
-                    for (size_t i = 0; i < size; i++)
+                    for (int i = 0; i < size; i++)
                     {
                         result->SetValue(i, DeserializeV8Object(subList, i));
                     }

CefSharp.BrowserSubprocess.Core/Wrapper/Browser.cpp

@@ -189,7 +189,7 @@ IFrame^ Browser::GetFrame(String^ name)
 /*--cef()--*/
 int Browser::GetFrameCount()
 {
-    return _browser->GetFrameCount();
+    return static_cast<int>(_browser->GetFrameCount());
 }
 
 ///
@@ -200,7 +200,7 @@ List<Int64>^ Browser::GetFrameIdentifiers()
 {
     std::vector<Int64> identifiers;
     _browser->GetFrameIdentifiers(identifiers);
-    List<Int64>^ results = gcnew List<Int64>(identifiers.size());
+    List<Int64>^ results = gcnew List<Int64>(static_cast<int>(identifiers.size()));
     for (UINT i = 0; i < identifiers.size(); i++)
     {
         results->Add(identifiers[i]);

CefSharp.Core.Runtime/Internals/Serialization/ObjectsSerialization.cpp

@@ -54,7 +54,7 @@ namespace CefSharp
                 else if (type == VTYPE_LIST)
                 {
                     auto subList = list->GetList(index);
-                    auto array = gcnew List<Object^>(subList->GetSize());
+                    auto array = gcnew List<Object^>(static_cast<int>(subList->GetSize()));
                     for (size_t i = 0; i < subList->GetSize(); i++)
                     {
                         array->Add(DeserializeObject(subList, i, javascriptCallbackFactory));