You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nuget - Only run CefSharpExcludeCoreRuntimeBeforeGenerateApplicationManifest for packages.config projects
When using Non SDK Stlye project with PackageReference and publishing with ClickOnce the CefSharp.Core.Runtime.*
files were missing from the installer.
Far as I can tell ClickOnce publishing isn't supported for SDK Style projects so just disable for PackageReference for now
#3613 (reply in thread)
Copy file name to clipboardExpand all lines: NuGet/CefSharp.Common.targets
+2-1Lines changed: 2 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -25,8 +25,9 @@
25
25
<!--
26
26
For VS2017 when publishing x86/x64 there's CefSharp.Core.Runtime.dll references in both _DeploymentManifestDependencies and _DeploymentManifestFiles
27
27
This causes an Error occurred writing to hard disk exception, so we remove one (we leave the dependency and just remove the file reference).
28
+
For VS2019 when using PackageReference this target removes CefSharp.Core.Runtime.* from the publish target, $(NuGetProjectStyle) check added.
28
29
-->
29
-
<TargetName="CefSharpExcludeCoreRuntimeBeforeGenerateApplicationManifest"BeforeTargets="GenerateApplicationManifest"Condition="'$(CefSharpPlatformTarget)' != 'AnyCPU' AND $(TargetFrameworkVersion.StartsWith('v4.'))">
30
+
<TargetName="CefSharpExcludeCoreRuntimeBeforeGenerateApplicationManifest"BeforeTargets="GenerateApplicationManifest"Condition="'$(CefSharpPlatformTarget)' != 'AnyCPU' AND $(TargetFrameworkVersion.StartsWith('v4.')) AND '$(NuGetProjectStyle)' != 'PackageReference'">
0 commit comments