Skip to content

Commit 47f3bcd

Browse files
committed
Nuget - Only run CefSharpExcludeCoreRuntimeBeforeGenerateApplicationManifest for packages.config projects
When using Non SDK Stlye project with PackageReference and publishing with ClickOnce the CefSharp.Core.Runtime.* files were missing from the installer. Far as I can tell ClickOnce publishing isn't supported for SDK Style projects so just disable for PackageReference for now #3613 (reply in thread)
1 parent 4ab6d2a commit 47f3bcd

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

NuGet/CefSharp.Common.targets

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@
2525
<!--
2626
For VS2017 when publishing x86/x64 there's CefSharp.Core.Runtime.dll references in both _DeploymentManifestDependencies and _DeploymentManifestFiles
2727
This causes an Error occurred writing to hard disk exception, so we remove one (we leave the dependency and just remove the file reference).
28+
For VS2019 when using PackageReference this target removes CefSharp.Core.Runtime.* from the publish target, $(NuGetProjectStyle) check added.
2829
-->
29-
<Target Name="CefSharpExcludeCoreRuntimeBeforeGenerateApplicationManifest" BeforeTargets="GenerateApplicationManifest" Condition="'$(CefSharpPlatformTarget)' != 'AnyCPU' AND $(TargetFrameworkVersion.StartsWith('v4.'))">
30+
<Target Name="CefSharpExcludeCoreRuntimeBeforeGenerateApplicationManifest" BeforeTargets="GenerateApplicationManifest" Condition="'$(CefSharpPlatformTarget)' != 'AnyCPU' AND $(TargetFrameworkVersion.StartsWith('v4.')) AND '$(NuGetProjectStyle)' != 'PackageReference'">
3031
<ItemGroup>
3132
<_DeploymentManifestFiles Remove="$(MSBuildThisFileDirectory)..\CefSharp\$(PlatformTarget)\CefSharp.Core.Runtime.dll" />
3233
<_DeploymentManifestFiles Remove="$(MSBuildThisFileDirectory)..\CefSharp\$(PlatformTarget)\CefSharp.Core.Runtime.pdb" />

0 commit comments

Comments
 (0)