Feature: Expose OnCertificateError to allow host application to decide whether or not it should continue

Author: sylvain-hamel

CefSharp.Core/Internals/ClientAdapter.cpp

@@ -207,6 +207,23 @@ namespace CefSharp
             return handler->OnBeforeBrowse(_browserControl, wrapper, isRedirect);
         }
 
+        bool ClientAdapter::OnCertificateError(cef_errorcode_t cert_error, const CefString& request_url, CefRefPtr<CefAllowCertificateErrorCallback> callback)
+        {
+            IRequestHandler^ handler = _browserControl->RequestHandler;
+            if (handler == nullptr)
+            {
+                return false;
+            }
+
+            if (handler->OnCertificateError(_browserControl, (CefErrorCode)cert_error, StringUtils::ToClr(request_url)))
+            {
+                callback->Continue(true);
+                return true;
+            }
+
+            return false;
+        }
+
         // CEF3 API: public virtual bool OnBeforePluginLoad( CefRefPtr< CefBrowser > browser, const CefString& url, const CefString& policy_url, CefRefPtr< CefWebPluginInfo > info );
         // ---
         // return value:

CefSharp.Core/Internals/ClientAdapter.h

@@ -87,6 +87,8 @@ namespace CefSharp
             virtual DECL bool GetAuthCredentials(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, bool isProxy,
                 const CefString& host, int port, const CefString& realm, const CefString& scheme, CefRefPtr<CefAuthCallback> callback) OVERRIDE;
             virtual DECL bool OnBeforeBrowse(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, CefRefPtr<CefRequest> request, bool isRedirect) OVERRIDE;
+            virtual DECL bool OnCertificateError(cef_errorcode_t cert_error, const CefString& request_url, CefRefPtr<CefAllowCertificateErrorCallback> callback) OVERRIDE;            
+
             virtual DECL bool OnBeforePluginLoad( CefRefPtr< CefBrowser > browser, const CefString& url, const CefString& policy_url, CefRefPtr< CefWebPluginInfo > info ) OVERRIDE;
             virtual DECL void OnPluginCrashed(CefRefPtr<CefBrowser> browser, const CefString& plugin_path) OVERRIDE;
             virtual DECL void OnRenderProcessTerminated(CefRefPtr<CefBrowser> browser, TerminationStatus status) OVERRIDE;

CefSharp.Example/RequestHandler.cs

@@ -14,6 +14,11 @@ bool IRequestHandler.OnBeforeBrowse(IWebBrowser browser, IRequest request, bool
             return false;
         }
 
+        bool IRequestHandler.OnCertificateError(IWebBrowser browser, CefErrorCode errorCode, string requestUrl)
+        {
+            return false;
+        }
+
         void IRequestHandler.OnPluginCrashed(IWebBrowser browser, string pluginPath)
         {
             // TODO: Add your own code here for handling scenarios where a plugin crashed, for one reason or another.

CefSharp.WinForms.Example/BrowserTabUserControl.cs

@@ -24,6 +24,7 @@ public BrowserTabUserControl(string url)
             Browser = browser;
 
             browser.MenuHandler = new MenuHandler();
+            browser.RequestHandler = new RequestHandler();
             browser.NavStateChanged += OnBrowserNavStateChanged;
             browser.ConsoleMessage += OnBrowserConsoleMessage;
             browser.TitleChanged += OnBrowserTitleChanged;

CefSharp/IRequestHandler.cs

@@ -18,6 +18,15 @@ public interface IRequestHandler
         /// <returns>Return true to cancel the navigation or false to allow the navigation to proceed.</returns>
         bool OnBeforeBrowse(IWebBrowser browser, IRequest request, bool isRedirect);
 
+        /// <summary>
+        /// Called when a certificate error is thrown.
+        /// </summary>
+        /// <param name="browser">the browser object</param>
+        /// <param name="errorCode">the error code for this invalid certificate</param>
+        /// <param name="requestUrl">the url of the request for the invalid certificate</param>
+        /// <returns>Return true to allow the invalid certificate and continue the request.</returns>
+        bool OnCertificateError(IWebBrowser browser, CefErrorCode errorCode, string requestUrl);
+
         /// <summary>
         /// Called when a plugin has crashed
         /// </summary>