Skip to content

Commit 4a20b19

Browse files
committed
Test - Minor cleanup
1 parent 102f70d commit 4a20b19

File tree

3 files changed

+33
-23
lines changed

3 files changed

+33
-23
lines changed

CefSharp.Test/DevTools/DevToolsClientFacts.cs

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public async Task CanCaptureScreenshot()
4343
var response = await devToolsClient.Page.CaptureScreenshotAsync();
4444

4545
Assert.NotNull(response.Data);
46-
Assert.NotEqual(0, response.Data.Length);
46+
Assert.NotEmpty(response.Data);
4747

4848
var image = Image.FromStream(new MemoryStream(response.Data));
4949
var size = browser.Size;
@@ -196,24 +196,30 @@ public async Task CanSetUserAgentOverride()
196196
using (var devToolsClient = browser.GetDevToolsClient())
197197
{
198198
var brandsList = new List<UserAgentBrandVersion>();
199-
var uab = new UserAgentBrandVersion();
200-
uab.Brand = "Google Chrome";
201-
uab.Version = "89";
199+
var uab = new UserAgentBrandVersion
200+
{
201+
Brand = "Google Chrome",
202+
Version = "89"
203+
};
202204
brandsList.Add(uab);
203205

204-
var uab2 = new UserAgentBrandVersion();
205-
uab2.Brand = "Chromium";
206-
uab2.Version = "89";
206+
var uab2 = new UserAgentBrandVersion
207+
{
208+
Brand = "Chromium",
209+
Version = "89"
210+
};
207211
brandsList.Add(uab2);
208212

209-
var ua = new UserAgentMetadata();
210-
ua.Brands = brandsList;
211-
ua.Architecture = "arm";
212-
ua.Model = "Nexus 7";
213-
ua.Platform = "Android";
214-
ua.PlatformVersion = "6.0.1";
215-
ua.FullVersion = "89.0.4389.114";
216-
ua.Mobile = true;
213+
var ua = new UserAgentMetadata
214+
{
215+
Brands = brandsList,
216+
Architecture = "arm",
217+
Model = "Nexus 7",
218+
Platform = "Android",
219+
PlatformVersion = "6.0.1",
220+
FullVersion = "89.0.4389.114",
221+
Mobile = true
222+
};
217223

218224
await devToolsClient.Emulation.SetUserAgentOverrideAsync("Mozilla/5.0 (Linux; Android 6.0.1; Nexus 7 Build/MOB30X) AppleWebKit/5(KHTML,likeGeckoChrome/89.0.4389.114Safari/537.36", null, null, ua);
219225
}

CefSharp.Test/JavascriptBinding/JavaScriptObjectRepositoryFacts.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public void CanRegisterJavascriptObjectBindWhenNamespaceIsNull()
4040
Assert.True(javascriptObjectRepository.IsBound(name));
4141

4242
var boundObjects = javascriptObjectRepository.GetObjects(new List<string> { name });
43-
Assert.Equal(1, boundObjects.Count);
43+
Assert.Single(boundObjects);
4444

4545
var result = javascriptObjectRepository.TryCallMethod(boundObjects[0].Id, "getExampleString", new object[0]);
4646
Assert.True(result.Success);

CefSharp.Test/OffScreen/OffScreenBrowserBasicFacts.cs

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -479,9 +479,11 @@ await Cef.UIThreadTaskFactory.StartNew(delegate
479479
taskCompletionSource.TrySetResult(Encoding.UTF8.GetString(responseBody));
480480
});
481481

482-
var request = new Request();
483-
request.Method = "GET";
484-
request.Url = "https://code.jquery.com/jquery-3.4.1.min.js";
482+
var request = new Request
483+
{
484+
Method = "GET",
485+
Url = "https://code.jquery.com/jquery-3.4.1.min.js"
486+
};
485487

486488
//Global RequestContext will be used
487489
urlRequest = new UrlRequest(request, requestClient);
@@ -528,9 +530,11 @@ public async Task CanLoadRequestWithPostData(string url)
528530

529531
Assert.True(response.Success);
530532

531-
var request = new Request();
532-
request.Url = "http://httpbin.org/post";
533-
request.Method = "POST";
533+
var request = new Request
534+
{
535+
Url = "http://httpbin.org/post",
536+
Method = "POST"
537+
};
534538
var postData = new PostData();
535539
postData.AddElement(new PostDataElement
536540
{
@@ -681,7 +685,7 @@ public async Task CanLoadMultipleBrowserInstancesSequentially()
681685

682686
var source = await browser.GetSourceAsync();
683687

684-
Assert.True(source.Contains("Testing"));
688+
Assert.Contains("Testing", source);
685689
}
686690
}
687691
}

0 commit comments

Comments
 (0)