Skip to content

Commit 6d62d18

Browse files
amaitlandamaitland
committed
Core - Reduce Code Duplication
Move Handler property decelerations to partial class Issue #3082
1 parent 4678bbc commit 6d62d18

File tree

4 files changed

+96
-243
lines changed

4 files changed

+96
-243
lines changed

‎CefSharp.OffScreen/ChromiumWebBrowser.cs‎

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -113,85 +113,11 @@ public bool IsDisposed
113113
/// <value>The request context.</value>
114114
public IRequestContext RequestContext { get; private set; }
115115
/// <summary>
116-
/// Implement <see cref="IJsDialogHandler" /> and assign to handle events related to JavaScript Dialogs.
117-
/// </summary>
118-
/// <value>The js dialog handler.</value>
119-
public IJsDialogHandler JsDialogHandler { get; set; }
120-
/// <summary>
121-
/// Implement <see cref="IDialogHandler" /> and assign to handle dialog events.
122-
/// </summary>
123-
/// <value>The dialog handler.</value>
124-
public IDialogHandler DialogHandler { get; set; }
125-
/// <summary>
126-
/// Implement <see cref="IDownloadHandler" /> and assign to handle events related to downloading files.
127-
/// </summary>
128-
/// <value>The download handler.</value>
129-
public IDownloadHandler DownloadHandler { get; set; }
130-
/// <summary>
131-
/// Implement <see cref="IKeyboardHandler" /> and assign to handle events related to key press.
132-
/// </summary>
133-
/// <value>The keyboard handler.</value>
134-
public IKeyboardHandler KeyboardHandler { get; set; }
135-
/// <summary>
136-
/// Implement <see cref="ILoadHandler" /> and assign to handle events related to browser load status.
137-
/// </summary>
138-
/// <value>The load handler.</value>
139-
public ILoadHandler LoadHandler { get; set; }
140-
/// <summary>
141-
/// Implement <see cref="ILifeSpanHandler" /> and assign to handle events related to popups.
142-
/// </summary>
143-
/// <value>The life span handler.</value>
144-
public ILifeSpanHandler LifeSpanHandler { get; set; }
145-
/// <summary>
146-
/// Implement <see cref="IDisplayHandler" /> and assign to handle events related to browser display state.
147-
/// </summary>
148-
/// <value>The display handler.</value>
149-
public IDisplayHandler DisplayHandler { get; set; }
150-
/// <summary>
151-
/// Implement <see cref="IContextMenuHandler" /> and assign to handle events related to the browser context menu
152-
/// </summary>
153-
/// <value>The menu handler.</value>
154-
public IContextMenuHandler MenuHandler { get; set; }
155-
/// <summary>
156-
/// Implement <see cref="IFocusHandler" /> and assign to handle events related to the browser component's focus
157-
/// </summary>
158-
/// <value>The focus handler.</value>
159-
public IFocusHandler FocusHandler { get; set; }
160-
/// <summary>
161-
/// Implement <see cref="IRequestHandler" /> and assign to handle events related to browser requests.
162-
/// </summary>
163-
/// <value>The request handler.</value>
164-
public IRequestHandler RequestHandler { get; set; }
165-
/// <summary>
166116
/// Implement <see cref="IRenderHandler" /> and assign to handle events related to browser rendering.
167117
/// </summary>
168118
/// <value>The render handler.</value>
169119
public IRenderHandler RenderHandler { get; set; }
170120
/// <summary>
171-
/// Implement <see cref="IDragHandler" /> and assign to handle events related to dragging.
172-
/// </summary>
173-
/// <value>The drag handler.</value>
174-
public IDragHandler DragHandler { get; set; }
175-
/// <summary>
176-
/// Implement <see cref="IResourceRequestHandlerFactory" /> and control the loading of resources
177-
/// </summary>
178-
/// <value>The resource handler factory.</value>
179-
public IResourceRequestHandlerFactory ResourceRequestHandlerFactory { get; set; }
180-
/// <summary>
181-
/// Implement <see cref="IRenderProcessMessageHandler" /> and assign to handle messages from the render process.
182-
/// </summary>
183-
/// <value>The render process message handler.</value>
184-
public IRenderProcessMessageHandler RenderProcessMessageHandler { get; set; }
185-
/// <summary>
186-
/// Implement <see cref="IFindHandler" /> to handle events related to find results.
187-
/// </summary>
188-
/// <value>The find handler.</value>
189-
public IFindHandler FindHandler { get; set; }
190-
/// <summary>
191-
/// Implement <see cref="IAudioHandler" /> to handle audio events.
192-
/// </summary>
193-
public IAudioHandler AudioHandler { get; set; }
194-
/// <summary>
195121
/// Implement <see cref="IAccessibilityHandler" /> to handle events related to accessibility.
196122
/// </summary>
197123
/// <value>The accessibility handler.</value>

‎CefSharp.WinForms/ChromiumWebBrowser.cs‎

Lines changed: 0 additions & 95 deletions
Original file line numberDiff line numberDiff line change
@@ -201,101 +201,6 @@ public IRequestContext RequestContext
201201
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
202202
public string Address { get; private set; }
203203

204-
/// <summary>
205-
/// Implement <see cref="IDialogHandler" /> and assign to handle dialog events.
206-
/// </summary>
207-
/// <value>The dialog handler.</value>
208-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
209-
public IDialogHandler DialogHandler { get; set; }
210-
/// <summary>
211-
/// Implement <see cref="IJsDialogHandler" /> and assign to handle events related to JavaScript Dialogs.
212-
/// </summary>
213-
/// <value>The js dialog handler.</value>
214-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
215-
public IJsDialogHandler JsDialogHandler { get; set; }
216-
/// <summary>
217-
/// Implement <see cref="IKeyboardHandler" /> and assign to handle events related to key press.
218-
/// </summary>
219-
/// <value>The keyboard handler.</value>
220-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
221-
public IKeyboardHandler KeyboardHandler { get; set; }
222-
/// <summary>
223-
/// Implement <see cref="IRequestHandler" /> and assign to handle events related to browser requests.
224-
/// </summary>
225-
/// <value>The request handler.</value>
226-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
227-
public IRequestHandler RequestHandler { get; set; }
228-
/// <summary>
229-
/// Implement <see cref="IDownloadHandler" /> and assign to handle events related to downloading files.
230-
/// </summary>
231-
/// <value>The download handler.</value>
232-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
233-
public IDownloadHandler DownloadHandler { get; set; }
234-
/// <summary>
235-
/// Implement <see cref="ILoadHandler" /> and assign to handle events related to browser load status.
236-
/// </summary>
237-
/// <value>The load handler.</value>
238-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
239-
public ILoadHandler LoadHandler { get; set; }
240-
/// <summary>
241-
/// Implement <see cref="ILifeSpanHandler" /> and assign to handle events related to popups.
242-
/// </summary>
243-
/// <value>The life span handler.</value>
244-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
245-
public ILifeSpanHandler LifeSpanHandler { get; set; }
246-
/// <summary>
247-
/// Implement <see cref="IDisplayHandler" /> and assign to handle events related to browser display state.
248-
/// </summary>
249-
/// <value>The display handler.</value>
250-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
251-
public IDisplayHandler DisplayHandler { get; set; }
252-
/// <summary>
253-
/// Implement <see cref="IContextMenuHandler" /> and assign to handle events related to the browser context menu
254-
/// </summary>
255-
/// <value>The menu handler.</value>
256-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
257-
public IContextMenuHandler MenuHandler { get; set; }
258-
/// <summary>
259-
/// Implement <see cref="IRenderProcessMessageHandler" /> and assign to handle messages from the render process.
260-
/// </summary>
261-
/// <value>The render process message handler.</value>
262-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
263-
public IRenderProcessMessageHandler RenderProcessMessageHandler { get; set; }
264-
/// <summary>
265-
/// Implement <see cref="IFindHandler" /> to handle events related to find results.
266-
/// </summary>
267-
/// <value>The find handler.</value>
268-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
269-
public IFindHandler FindHandler { get; set; }
270-
/// <summary>
271-
/// Implement <see cref="IAudioHandler" /> to handle audio events.
272-
/// </summary>
273-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
274-
public IAudioHandler AudioHandler { get; set; }
275-
/// <summary>
276-
/// The <see cref="IFocusHandler" /> for this ChromiumWebBrowser.
277-
/// </summary>
278-
/// <value>The focus handler.</value>
279-
/// <remarks>If you need customized focus handling behavior for WinForms, the suggested
280-
/// best practice would be to inherit from DefaultFocusHandler and try to avoid
281-
/// needing to override the logic in OnGotFocus. The implementation in
282-
/// DefaultFocusHandler relies on very detailed behavior of how WinForms and
283-
/// Windows interact during window activation.</remarks>
284-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
285-
public IFocusHandler FocusHandler { get; set; }
286-
/// <summary>
287-
/// Implement <see cref="IDragHandler" /> and assign to handle events related to dragging.
288-
/// </summary>
289-
/// <value>The drag handler.</value>
290-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
291-
public IDragHandler DragHandler { get; set; }
292-
/// <summary>
293-
/// Implement <see cref="IResourceRequestHandlerFactory" /> and control the loading of resources
294-
/// </summary>
295-
/// <value>The resource handler factory.</value>
296-
[Browsable(false), DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden), DefaultValue(null)]
297-
public IResourceRequestHandlerFactory ResourceRequestHandlerFactory { get; set; }
298-
299204
/// <summary>
300205
/// Event handler that will get called when the resource load for a navigation fails or is canceled.
301206
/// It's important to note this event is fired on a CEF UI thread, which by default is not the same as your application UI

‎CefSharp.Wpf/ChromiumWebBrowser.cs‎

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -218,85 +218,11 @@ public IRequestContext RequestContext
218218
}
219219
}
220220
/// <summary>
221-
/// Implement <see cref="IDialogHandler" /> and assign to handle dialog events.
222-
/// </summary>
223-
/// <value>The dialog handler.</value>
224-
public IDialogHandler DialogHandler { get; set; }
225-
/// <summary>
226-
/// Implement <see cref="IJsDialogHandler" /> and assign to handle events related to JavaScript Dialogs.
227-
/// </summary>
228-
/// <value>The js dialog handler.</value>
229-
public IJsDialogHandler JsDialogHandler { get; set; }
230-
/// <summary>
231-
/// Implement <see cref="IKeyboardHandler" /> and assign to handle events related to key press.
232-
/// </summary>
233-
/// <value>The keyboard handler.</value>
234-
public IKeyboardHandler KeyboardHandler { get; set; }
235-
/// <summary>
236-
/// Implement <see cref="IRequestHandler" /> and assign to handle events related to browser requests.
237-
/// </summary>
238-
/// <value>The request handler.</value>
239-
public IRequestHandler RequestHandler { get; set; }
240-
/// <summary>
241-
/// Implement <see cref="IDownloadHandler" /> and assign to handle events related to downloading files.
242-
/// </summary>
243-
/// <value>The download handler.</value>
244-
public IDownloadHandler DownloadHandler { get; set; }
245-
/// <summary>
246-
/// Implement <see cref="ILoadHandler" /> and assign to handle events related to browser load status.
247-
/// </summary>
248-
/// <value>The load handler.</value>
249-
public ILoadHandler LoadHandler { get; set; }
250-
/// <summary>
251-
/// Implement <see cref="ILifeSpanHandler" /> and assign to handle events related to popups.
252-
/// </summary>
253-
/// <value>The life span handler.</value>
254-
public ILifeSpanHandler LifeSpanHandler { get; set; }
255-
/// <summary>
256-
/// Implement <see cref="IDisplayHandler" /> and assign to handle events related to browser display state.
257-
/// </summary>
258-
/// <value>The display handler.</value>
259-
public IDisplayHandler DisplayHandler { get; set; }
260-
/// <summary>
261-
/// Implement <see cref="IContextMenuHandler" /> and assign to handle events related to the browser context menu
262-
/// </summary>
263-
/// <value>The menu handler.</value>
264-
public IContextMenuHandler MenuHandler { get; set; }
265-
/// <summary>
266-
/// Implement <see cref="IFocusHandler" /> and assign to handle events related to the browser component's focus
267-
/// </summary>
268-
/// <value>The focus handler.</value>
269-
public IFocusHandler FocusHandler { get; set; }
270-
/// <summary>
271-
/// Implement <see cref="IDragHandler" /> and assign to handle events related to dragging.
272-
/// </summary>
273-
/// <value>The drag handler.</value>
274-
public IDragHandler DragHandler { get; set; }
275-
/// <summary>
276-
/// Implement <see cref="IResourceRequestHandlerFactory" /> and control the loading of resources
277-
/// </summary>
278-
/// <value>The resource handler factory.</value>
279-
public IResourceRequestHandlerFactory ResourceRequestHandlerFactory { get; set; }
280-
/// <summary>
281221
/// Implement <see cref="IRenderHandler"/> and control how the control is rendered
282222
/// </summary>
283223
/// <value>The render Handler.</value>
284224
public IRenderHandler RenderHandler { get; set; }
285225
/// <summary>
286-
/// Implement <see cref="IRenderProcessMessageHandler" /> and assign to handle messages from the render process.
287-
/// </summary>
288-
/// <value>The render process message handler.</value>
289-
public IRenderProcessMessageHandler RenderProcessMessageHandler { get; set; }
290-
/// <summary>
291-
/// Implement <see cref="IFindHandler" /> to handle events related to find results.
292-
/// </summary>
293-
/// <value>The find handler.</value>
294-
public IFindHandler FindHandler { get; set; }
295-
/// <summary>
296-
/// Implement <see cref="IAudioHandler" /> to handle audio events.
297-
/// </summary>
298-
public IAudioHandler AudioHandler { get; set; }
299-
/// <summary>
300226
/// Implement <see cref="IAccessibilityHandler" /> to handle events related to accessibility.
301227
/// </summary>
302228
/// <value>The accessibility handler.</value>

0 commit comments

Comments
 (0)