Skip to content

Commit 6dfad90

Browse files
committed
Core - Add IBrowser reference to TitleChangedEventArgs/ConsoleMessageEventArgs
1 parent 8d6de99 commit 6dfad90

File tree

3 files changed

+23
-6
lines changed

3 files changed

+23
-6
lines changed

CefSharp.Core/Internals/ClientAdapter.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -284,21 +284,22 @@ namespace CefSharp
284284

285285
bool ClientAdapter::OnAutoResize(CefRefPtr<CefBrowser> browser, const CefSize& new_size)
286286
{
287-
auto browserWrapper = GetBrowserWrapper(browser->GetIdentifier(), browser->IsPopup());
288-
289287
auto handler = _browserControl->DisplayHandler;
290288

291289
if (handler == nullptr)
292290
{
293291
return false;
294292
}
295293

294+
auto browserWrapper = GetBrowserWrapper(browser->GetIdentifier(), browser->IsPopup());
295+
296296
return handler->OnAutoResize(_browserControl, browserWrapper, CefSharp::Structs::Size(new_size.width, new_size.height));
297297
}
298298

299299
void ClientAdapter::OnTitleChange(CefRefPtr<CefBrowser> browser, const CefString& title)
300300
{
301-
auto args = gcnew TitleChangedEventArgs(StringUtils::ToClr(title));
301+
auto browserWrapper = GetBrowserWrapper(browser->GetIdentifier(), browser->IsPopup());
302+
auto args = gcnew TitleChangedEventArgs(browserWrapper, StringUtils::ToClr(title));
302303

303304
if (browser->IsPopup() && !_browserControl->HasParent)
304305
{
@@ -384,7 +385,9 @@ namespace CefSharp
384385

385386
bool ClientAdapter::OnConsoleMessage(CefRefPtr<CefBrowser> browser, cef_log_severity_t level, const CefString& message, const CefString& source, int line)
386387
{
387-
auto args = gcnew ConsoleMessageEventArgs((LogSeverity)level, StringUtils::ToClr(message), StringUtils::ToClr(source), line);
388+
auto browserWrapper = GetBrowserWrapper(browser->GetIdentifier(), browser->IsPopup());
389+
390+
auto args = gcnew ConsoleMessageEventArgs(browserWrapper, (LogSeverity)level, StringUtils::ToClr(message), StringUtils::ToClr(source), line);
388391

389392
if (!browser->IsPopup() || _browserControl->HasParent)
390393
{

CefSharp/Event/ConsoleMessageEventArgs.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,25 @@ public class ConsoleMessageEventArgs : EventArgs
1414
/// <summary>
1515
/// Creates a new ConsoleMessageEventArgs event argument.
1616
/// </summary>
17+
/// <param name="browser">browser</param>
1718
/// <param name="level">level</param>
1819
/// <param name="message">message</param>
1920
/// <param name="source">source</param>
2021
/// <param name="line">line number</param>
21-
public ConsoleMessageEventArgs(LogSeverity level, string message, string source, int line)
22+
public ConsoleMessageEventArgs(IBrowser browser, LogSeverity level, string message, string source, int line)
2223
{
24+
Browser = browser;
2325
Level = level;
2426
Message = message;
2527
Source = source;
2628
Line = line;
2729
}
2830

31+
/// <summary>
32+
/// Access to the underlying <see cref="IBrowser"/> object
33+
/// </summary>
34+
public IBrowser Browser { get; private set; }
35+
2936
/// <summary>
3037
/// Log level
3138
/// </summary>

CefSharp/Event/TitleChangedEventArgs.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ namespace CefSharp
1111
/// </summary>
1212
public class TitleChangedEventArgs : EventArgs
1313
{
14+
/// <summary>
15+
/// Access to the underlying <see cref="IBrowser"/> object
16+
/// </summary>
17+
public IBrowser Browser { get; private set; }
18+
1419
/// <summary>
1520
/// The new title
1621
/// </summary>
@@ -19,9 +24,11 @@ public class TitleChangedEventArgs : EventArgs
1924
/// <summary>
2025
/// Creates a new TitleChanged event arg
2126
/// </summary>
27+
/// <param name="browser">browser</param>
2228
/// <param name="title">the new title</param>
23-
public TitleChangedEventArgs(string title)
29+
public TitleChangedEventArgs(IBrowser browser, string title)
2430
{
31+
Browser = browser;
2532
Title = title;
2633
}
2734
}

0 commit comments

Comments
 (0)