Core - Crash opening popup window

Upstream changes mean that extraInfo can now be null (https://bitbucket.org/chromiumembedded/cef/issues/3123/convert-legacy-ipc-messages-to-mojo)
We currently only send extra Info for the main browser and not for popups.
Assign the _jsBindingPropertyName/_jsBindingPropertyNameCamelCase properties
by default and only update when the user has specified their own name.

It's not currently possible to have different naming in the same render process (was previously the case).

Issue #3670

Author: amaitland

CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cpp

@@ -90,18 +90,13 @@ namespace CefSharp
                     }
                 }
             }
-        }
 
-        if (extraInfo->HasKey("JsBindingPropertyName") || extraInfo->HasKey("JsBindingPropertyNameCamelCase"))
-        {
-            //TODO: Create constant for these and legacy binding strings above
-            _jsBindingPropertyName = extraInfo->GetString("JsBindingPropertyName");
-            _jsBindingPropertyNameCamelCase = extraInfo->GetString("JsBindingPropertyNameCamelCase");
-        }
-        else
-        {
-            _jsBindingPropertyName = "CefSharp";
-            _jsBindingPropertyNameCamelCase = "cefSharp";
+            if (extraInfo->HasKey("JsBindingPropertyName") || extraInfo->HasKey("JsBindingPropertyNameCamelCase"))
+            {
+                //TODO: Create constant for these and legacy binding strings above
+                _jsBindingPropertyName = extraInfo->GetString("JsBindingPropertyName");
+                _jsBindingPropertyNameCamelCase = extraInfo->GetString("JsBindingPropertyNameCamelCase");
+            }
         }
     }
 

CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.h

@@ -50,6 +50,8 @@ namespace CefSharp
             _javascriptObjects = gcnew Dictionary<String^, JavascriptObject^>();
             _registerBoundObjectRegistry = gcnew RegisterBoundObjectRegistry();
             _legacyBindingEnabled = false;
+            _jsBindingPropertyName = "CefSharp";
+            _jsBindingPropertyNameCamelCase = "cefSharp";
         }
 
         ~CefAppUnmanagedWrapper()