CefSharp.OffScreen - Disable audio by default

amaitland · amaitland · commit 810f087ddaa8 · 2018-08-12T15:17:53.000+10:00
It doesn't make much sense in an offscreen scenario
diff --git a/CefSharp.OffScreen/CefSettings.cs b/CefSharp.OffScreen/CefSettings.cs
@@ -11,7 +11,11 @@ public CefSettings() : base()
         {
             WindowlessRenderingEnabled = true;
 
-            if(Cef.CefVersion.StartsWith("r3.3497"))
+            //For OffScreen it doesn't make much sense to enable audio by default, so we disable it.
+            //this can be removed in user code if required
+            CefCommandLineArgs.Add("mute-audio", "1");
+
+            if (Cef.CefVersion.StartsWith("r3.3497"))
             {
                 throw new System.Exception("Issue #2408 should have been resolved, remove the below code");
             }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,11 @@ public CefSettings() : base()`
`11`	`11`	`{`
`12`	`12`	`WindowlessRenderingEnabled = true;`
`13`	`13`
`14`		`- if(Cef.CefVersion.StartsWith("r3.3497"))`
	`14`	`+ //For OffScreen it doesn't make much sense to enable audio by default, so we disable it.`
	`15`	`+ //this can be removed in user code if required`
	`16`	`+ CefCommandLineArgs.Add("mute-audio", "1");`
	`17`	`+`
	`18`	`+ if (Cef.CefVersion.StartsWith("r3.3497"))`
`15`	`19`	`{`
`16`	`20`	`throw new System.Exception("Issue #2408 should have been resolved, remove the below code");`
`17`	`21`	`}`