Javascript Binding - Allow binding to classes in the global namespace (#3467)

* fix IsComplexType NullReferenceException

Sometimes, the registered Javascript object does not have a namespace, at this time this function will throw a ```NullReferenceException```.

* add unit test for IsComplexType

* Simplify and remove useless code

* Update CefSharp/Internals/JavascriptObjectRepository.cs

Co-authored-by: campersau <[email protected]>

Co-authored-by: Alex Maitland <[email protected]>
Co-authored-by: campersau <[email protected]>

Author: 3 people

CefSharp.Test/CefSharp.Test.csproj

@@ -163,6 +163,7 @@
     <Compile Include="Framework\RequestContextFacts.cs" />
     <Compile Include="Framework\TestMemberInfo.cs" />
     <Compile Include="JavascriptBinding\IntegrationTestFacts.cs" />
+    <Compile Include="JavascriptBinding\JavaScriptObjectRepositoryFacts.cs" />
     <Compile Include="OffScreen\OffScreenBrowserBasicFacts.cs" />
     <Compile Include="CefSharpXunitTestFramework.cs" />
     <Compile Include="CefSharpFixture.cs" />

CefSharp.Test/JavascriptBinding/JavaScriptObjectRepositoryFacts.cs

@@ -0,0 +1,38 @@
+using CefSharp.Internals;
+using Xunit;
+
+internal class NoNamespaceClass
+{
+    public SomeElseClass SomeElseClass { get; set; }
+    public int Year { get; set; }
+
+    public string GetExampleString()
+    {
+        return "ok";
+    }
+}
+
+internal class SomeElseClass
+{
+
+}
+
+
+namespace CefSharp.Test.JavascriptBinding
+{  
+    public class JavaScriptObjectRepositoryFacts
+    {
+        [Fact]
+        public void CanRegisterJavascriptObjectBindWhenNamespaceIsNull()
+        {
+            var javascriptObjectRepository = new JavascriptObjectRepository();
+            var name = nameof(NoNamespaceClass);
+            javascriptObjectRepository.Register(name, new NoNamespaceClass(), false, new BindingOptions() { });
+            Assert.True(javascriptObjectRepository.IsBound(name));
+
+            var result = ((IJavascriptObjectRepositoryInternal)javascriptObjectRepository).TryCallMethod(1, "getExampleString", new object[0]);
+            Assert.True(result.Success);
+            Assert.Equal("ok", result.ReturnValue.ToString());
+        }
+    }
+}

CefSharp/Internals/JavascriptObjectRepository.cs

@@ -738,7 +738,7 @@ private static bool IsComplexType(Type type)
                 baseType = Nullable.GetUnderlyingType(type);
             }
 
-            if (baseType == null || baseType.IsArray || baseType.Namespace.StartsWith("System"))
+            if (baseType == null || baseType.IsArray || baseType.Namespace?.StartsWith("System") == true)
             {
                 return false;
             }