TypeConversion - Improve ToNative type checking when converting from Object to CefValue

Previously you had to used a fixed type, now the type checking is more flexible.

Move the Dictionary check to before the collection check as a dictionary is technically a collection

Resolves #2625

Author: amaitland

CefSharp.Core/Internals/TypeConversion.h

@@ -150,31 +150,34 @@ namespace CefSharp
                 {
                     cefValue->SetDouble(Convert::ToDouble(value));
                 }
-                else if (type == List<Object^>::typeid)
+                else if (System::Collections::IDictionary::typeid->IsAssignableFrom(type))
                 {
-                    auto list = safe_cast<List<Object^>^>(value);
-                    auto cefList = CefListValue::Create();
-                    for (int i = 0; i < list->Count; i++)
-                    {
-                        auto value = list[i];
-                        SerializeV8Object(cefList, i, value);
-                    }
-                    cefValue->SetList(cefList);
-                }
-                else if (type == Dictionary<String^, Object^>::typeid)
-                {
-                    auto dictionary = safe_cast<Dictionary<String^, Object^>^>(value);
+                    auto dictionary = (System::Collections::IDictionary^) value;
                     auto cefDictionary = CefDictionaryValue::Create();
 
-                    for each (KeyValuePair<String^, Object^>^ entry in dictionary)
+                    for each (System::Collections::DictionaryEntry entry in dictionary)
                     {
-                        auto key = StringUtils::ToNative(entry->Key);
-                        auto value = entry->Value;
+                        auto key = StringUtils::ToNative(Convert::ToString(entry.Key));
+                        auto value = entry.Value;
                         SerializeV8Object(cefDictionary, key, value);
                     }
 
                     cefValue->SetDictionary(cefDictionary);
                 }
+                else if (System::Collections::IEnumerable::typeid->IsAssignableFrom(type))
+                {
+                    auto enumerable = (System::Collections::IEnumerable^) value;
+                    auto cefList = CefListValue::Create();
+
+                    int i = 0;
+                    for each (Object^ arrObj in enumerable)
+                    {
+                        SerializeV8Object(cefList, i, arrObj);
+
+                        i++;
+                    }
+                    cefValue->SetList(cefList);
+                }
 
                 return cefValue;
             }

CefSharp.Example/Handlers/BrowserProcessHandler.cs

@@ -3,6 +3,7 @@
 // Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
 
 using System;
+using System.Collections.Generic;
 using System.Diagnostics;
 using System.Threading.Tasks;
 using CefSharp.SchemeHandler;
@@ -73,6 +74,19 @@ void IBrowserProcessHandler.OnContextInitialized()
                 //The default is true, you can change to false to disable
                 context.SetPreference("webkit.webprefs.plugins_enabled", true, out errorMessage);
 
+                //string error;
+                //var dicts = new List<string> { "en-GB", "en-US" };
+                //var success = context.SetPreference("spellcheck.dictionaries", dicts, out error);
+
+                //The no-proxy-server flag is set in CefExample.cs class, you'll have to remove that before you can test
+                //this code out
+                //var v = new Dictionary<string, string>
+                //{
+                //    ["mode"] = "fixed_servers",
+                //    ["server"] = "scheme://host:port"
+                //};
+                //success = context.SetPreference("proxy", v, out errorMessage);
+
                 //It's possible to register a scheme handler for the default http and https schemes
                 //In this example we register the FolderSchemeHandlerFactory for https://cefsharp.example
                 //Best to include the domain name, so only requests for that domain are forwarded to your scheme handler