Skip to content

Commit a76ada3

Browse files
committed
Cleanup Loading and NavState code, there's currently additional calls to both which are slightly confusing (and don't provide any benefit).
So simplify by setting SetIsLoading(true) on LoadStart and SetIsLoading(false) on LoadEnd. Then only set NavState in ClientAdapter::OnLoadingStateChange
1 parent a439488 commit a76ada3

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

CefSharp.Core/Internals/ClientAdapter.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ namespace CefSharp
6666

6767
void ClientAdapter::OnLoadingStateChange(CefRefPtr<CefBrowser> browser, bool isLoading, bool canGoBack, bool canGoForward)
6868
{
69-
_browserControl->SetIsLoading(isLoading);
70-
7169
auto canReload = !isLoading;
7270
_browserControl->SetNavState(canGoBack, canGoForward, canReload);
7371
}
@@ -168,7 +166,6 @@ namespace CefSharp
168166
if (frame->IsMain())
169167
{
170168
_browserControl->SetIsLoading(true);
171-
_browserControl->SetNavState(false, false, false);
172169
}
173170

174171
_browserControl->OnFrameLoadStart(StringUtils::ToClr(frame->GetURL()), frame->IsMain());

0 commit comments

Comments
 (0)