Skip to content

Commit b064efd

Browse files
committed
BrowserSubProcess - Change SetProcessShutdownParameters priority to 0x200
- Change to 0x200 which is low end of 'Application reserved "in between" shutdown range.' - Remove logging as it wasn't working, must be too early to use the LOG(INFO) CEF macro Test with a GetProcessShutdownParameters in debugger shows working e.g. if (SetProcessShutdownParameters(0x200, SHUTDOWN_NORETRY)) { DWORD level = 0; DWORD flags = 0; GetProcessShutdownParameters(&level, &flags); } Issue #3155
1 parent c39e0ea commit b064efd

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

CefSharp.BrowserSubprocess.Core/BrowserSubprocessExecutable.h

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,19 +125,13 @@ namespace CefSharp
125125
//Lower the shutdown priority so the browser process is shutdown first (Issue #3155)
126126
//The system terminates the process without displaying a retry dialog box for the user.
127127
//Crashpad is lower than other sub processes so it can still monitor process exit crashes.
128-
if (!SetProcessShutdownParameters(0x100, SHUTDOWN_NORETRY))
129-
{
130-
LOG(ERROR) << "SetProcessShutdownParameters - Crashpad";
131-
}
128+
SetProcessShutdownParameters(0x100, SHUTDOWN_NORETRY);
132129
}
133130
else
134131
{
135132
//Lower the shutdown priority so the browser process is shutdown first (Issue #3155)
136133
//The system terminates the process without displaying a retry dialog box for the user.
137-
if (!SetProcessShutdownParameters(0x280 - 100, SHUTDOWN_NORETRY))
138-
{
139-
LOG(ERROR) << "SetProcessShutdownParameters - Sub Process";
140-
}
134+
SetProcessShutdownParameters(0x200, SHUTDOWN_NORETRY);
141135

142136
parentProcessId = int::Parse(CommandLineArgsParser::GetArgumentValue(args, CefSharpArguments::HostProcessIdArgument));
143137
if (CommandLineArgsParser::HasArgument(args, CefSharpArguments::ExitIfParentProcessClosed))

0 commit comments

Comments
 (0)