Core - Further migration of extensions methods from IWebBrowser to IChromiumWebBrowserBase

- EvaluateScriptAsync can now be used from IChromiumWebBrowserBase, if also IWebBrowser then
main frame check will occur as previous.

Related to #3944

Author: amaitland

CefSharp.Core/WebBrowserExtensionsEx.cs

@@ -23,7 +23,7 @@ public static class WebBrowserExtensionsEx
         /// <returns>
         /// <see cref="Task{NavigationEntry}"/> that when executed returns the current <see cref="NavigationEntry"/> or null
         /// </returns>
-        public static Task<NavigationEntry> GetVisibleNavigationEntryAsync(this IWebBrowser browser)
+        public static Task<NavigationEntry> GetVisibleNavigationEntryAsync(this IChromiumWebBrowserBase browser)
         {
             var host = browser.GetBrowserHost();
 

CefSharp.Example/DevTools/DevToolsExtensions.cs

@@ -12,7 +12,7 @@ public static class DevToolsExtensions
         /// </summary>
         /// <param name="browser">the ChromiumWebBrowser</param>
         /// <returns>png encoded image as byte[]</returns>
-        public static async Task<byte[]> CaptureScreenShotAsPng(this IWebBrowser chromiumWebBrowser)
+        public static async Task<byte[]> CaptureScreenShotAsPng(this IChromiumWebBrowserBase chromiumWebBrowser)
         {
             //Make sure to dispose of our observer registration when done
             //If you need to make multiple calls then reuse the devtools client

CefSharp.WinForms/WebBrowserExtensions.cs

@@ -23,7 +23,7 @@ public static class WebBrowserExtensions
         /// This will avoid the WM_Close message that CEF sends by default to the top level window.
         /// (Which closes your application). This method should generally only be used in the WinForms version.
         /// </summary>
-        /// <param name="chromiumWebBrowser">the ChromiumWebBrowser instance</param>
+        /// <param name="chromiumWebBrowser">the <see cref="ChromiumWebBrowser"/> or <see cref="ChromiumHostControl"/> instance.</param>
         /// <returns>If the function succeeds, the return value is true.</returns>
         /// <example>
         /// <code>
@@ -34,7 +34,7 @@ public static class WebBrowserExtensions
         /// });
         /// </code>
         /// </example>
-        public static bool DestroyWindow(this IWebBrowser chromiumWebBrowser)
+        public static bool DestroyWindow(this IChromiumWebBrowserBase chromiumWebBrowser)
         {
             if (!Cef.CurrentlyOnThread(CefThreadIds.TID_UI))
             {

CefSharp/WebBrowserExtensions.cs

@@ -1369,26 +1369,19 @@ private static string GetPromiseHandlerScript(string script, string javascriptBi
         /// When false don't include a return statement e.g. 42;
         /// </param>
         /// <returns>
-        /// <see cref="Task{JavascriptResponse}"/> that can be awaited to perform the script execution.
+        /// <see cref="Task{JavascriptResponse}"/> that can be awaited to obtain the result of the script execution.
         /// </returns>
-        public static Task<JavascriptResponse> EvaluateScriptAsync(this IWebBrowser browser, string script, TimeSpan? timeout = null, bool useImmediatelyInvokedFuncExpression = false)
+        public static Task<JavascriptResponse> EvaluateScriptAsync(this IChromiumWebBrowserBase browser, string script, TimeSpan? timeout = null, bool useImmediatelyInvokedFuncExpression = false)
         {
-            if (timeout.HasValue && timeout.Value.TotalMilliseconds > UInt32.MaxValue)
-            {
-                throw new ArgumentOutOfRangeException("timeout", "Timeout greater than Maximum allowable value of " + UInt32.MaxValue);
-            }
-
-            if (browser.CanExecuteJavascriptInMainFrame == false)
+            if (browser is IWebBrowser b)
             {
-                ThrowExceptionIfCanExecuteJavascriptInMainFrameFalse();
+                if (b.CanExecuteJavascriptInMainFrame == false)
+                {
+                    ThrowExceptionIfCanExecuteJavascriptInMainFrameFalse();
+                }
             }
 
-            using (var frame = browser.GetMainFrame())
-            {
-                ThrowExceptionIfFrameNull(frame);
-
-                return frame.EvaluateScriptAsync(script, timeout: timeout, useImmediatelyInvokedFuncExpression: useImmediatelyInvokedFuncExpression);
-            }
+            return browser.BrowserCore.EvaluateScriptAsync(script, timeout, useImmediatelyInvokedFuncExpression);
         }
 
         /// <summary>
@@ -1404,7 +1397,7 @@ public static Task<JavascriptResponse> EvaluateScriptAsync(this IWebBrowser brow
         /// When false don't include a return statement e.g. 42;
         /// </param>
         /// <returns>
-        /// <see cref="Task{JavascriptResponse}"/> that can be awaited to perform the script execution.
+        /// <see cref="Task{JavascriptResponse}"/> that can be awaited to obtain the result of the script execution.
         /// </returns>
         public static Task<JavascriptResponse> EvaluateScriptAsync(this IBrowser browser, string script, TimeSpan? timeout = null, bool useImmediatelyInvokedFuncExpression = false)
         {
@@ -1432,7 +1425,7 @@ public static Task<JavascriptResponse> EvaluateScriptAsync(this IBrowser browser
         /// <param name="methodName">The javascript method name to execute.</param>
         /// <param name="args">the arguments to be passed as params to the method.</param>
         /// <returns>
-        /// <see cref="Task{JavascriptResponse}"/> that can be awaited to perform the script execution.
+        /// <see cref="Task{JavascriptResponse}"/> that can be awaited to obtain the result of the script execution.
         /// </returns>
         public static Task<JavascriptResponse> EvaluateScriptAsync(this IChromiumWebBrowserBase browser, string methodName, params object[] args)
         {