Core - Remove Cookie.Creation/LastAccessed setters

Resolves #3741

Author: amaitland

CefSharp.Core.Runtime/Internals/TypeConversion.h

@@ -288,8 +288,8 @@ namespace CefSharp
                     cookie->Path = StringUtils::ToClr(cefCookie.path);
                     cookie->Secure = cefCookie.secure == 1;
                     cookie->HttpOnly = cefCookie.httponly == 1;
-                    cookie->Creation = ConvertCefTimeToDateTime(cefCookie.creation);
-                    cookie->LastAccess = ConvertCefTimeToDateTime(cefCookie.last_access);
+                    cookie->SetCreationDate(ConvertCefTimeToDateTime(cefCookie.creation));
+                    cookie->SetLastAccessDate(ConvertCefTimeToDateTime(cefCookie.last_access));
                     cookie->SameSite = (CefSharp::Enums::CookieSameSite)cefCookie.same_site;
                     cookie->Priority = (CefSharp::Enums::CookiePriority)cefCookie.priority;
 

CefSharp/Cookie.cs

@@ -3,6 +3,7 @@
 // Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
 
 using System;
+using System.ComponentModel;
 using System.Diagnostics;
 using CefSharp.Enums;
 
@@ -49,11 +50,11 @@ public sealed class Cookie
         /// <summary>
         /// The cookie creation date. This is automatically populated by the system on cookie creation. 
         /// </summary>
-        public DateTime Creation { get; set; }
+        public DateTime Creation { get; private set; }
         /// <summary>
         /// The cookie last access date. This is automatically populated by the system on access. 
         /// </summary>		
-        public DateTime LastAccess { get; set; }
+        public DateTime LastAccess { get; private set; }
         /// <summary>
         /// Same site.
         /// </summary>
@@ -62,5 +63,35 @@ public sealed class Cookie
         /// Priority
         /// </summary>
         public CookiePriority Priority { get; set; }
+
+        /// <summary>
+        /// Used internally to set <see cref="Creation"/>.
+        /// <see cref="Creation"/> can only be set when fecting a Cookie from Chromium
+        /// </summary>
+        /// <param name="dateTime">dateTime</param>
+        /// <remarks>
+        /// Hidden from intellisense as only meant to be used internally, unfortunately
+        /// VC++ makes it hard to use internal classes from C#
+        /// </remarks>
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public void SetCreationDate(DateTime dateTime)
+        {
+            Creation = dateTime;
+        }
+
+        /// <summary>
+        /// Used internally to set <see cref="LastAccess"/>.
+        /// <see cref="LastAccess"/> can only be set when fecting a Cookie from Chromium
+        /// </summary>
+        /// <param name="dateTime">dateTime</param>
+        /// <remarks>
+        /// Hidden from intellisense as only meant to be used internally, unfortunately
+        /// VC++ makes it hard to use internal classes from C#
+        /// </remarks>
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public void SetLastAccessDate(DateTime dateTime)
+        {
+            LastAccess = dateTime;
+        }
     }
 }