JSB - Fix bug where properties weren't being analysed for sync bound objects

Added test case
Reordered method to make it more logical, used named properties so it's clear what's being set.
Add TODO for unresolved object event

Author: amaitland

CefSharp.Example/Resources/BindingTest.html

@@ -43,6 +43,31 @@
                 assert.equal( actualResult, expectedResult, "We expect value to be " + actualResult );
             });
 
+            QUnit.test( "bound.myProperty", function( assert )
+            {
+                const expectedResult = 42;
+                let actualResult = bound.myProperty;
+
+                assert.equal(actualResult, expectedResult, "We expect value to be " + expectedResult);
+            });
+
+            QUnit.test( "bound.subObject.simpleProperty", function( assert )
+            {
+                const expectedResult = "This is a very simple property.";
+                let actualResult = bound.subObject.simpleProperty;
+
+                assert.equal(actualResult, expectedResult, "We expect value to be " + expectedResult);
+
+                bound.subObject.simpleProperty = expectedResult + "1";
+
+                actualResult = bound.subObject.simpleProperty;
+
+                assert.equal(actualResult, (expectedResult + "1"), "We expect value to be " + (expectedResult + 1));
+
+                //Reset to default value
+                bound.subObject.simpleProperty = expectedResult;
+            });
+
             QUnit.test( "Function delegate to c# method", function( assert )
             {
                 function myFunction(functionParam)

CefSharp/Internals/JavascriptObjectRepository.cs

@@ -66,7 +66,11 @@ public bool IsBound(string name)
 
         public List<JavascriptObject> GetObjects(List<string> names = null)
         {
-            if (names == null || names.Count == 0)
+            //If there are no objects names or the count is 0 then we will raise
+            //the resolve event then return all objects that are registered,
+            //we'll only perform checking if object(s) of specific name is requested.
+            var getAllObjects = names == null || names.Count == 0;
+            if (getAllObjects)
             {
                 //TODO: JSB Declare Constant for All
                 RaiseResolveObjectEvent("All");
@@ -81,8 +85,12 @@ public List<JavascriptObject> GetObjects(List<string> names = null)
                     RaiseResolveObjectEvent(name);
                 }
             }
-            
-            return objects.Values.Where(x => names.Contains(x.JavascriptName)).ToList();
+
+            var objectsByName = objects.Values.Where(x => names.Contains(x.JavascriptName)).ToList();
+
+            //TODO: JSB Add another event that signals when no object matching a name
+            //in the list was provided.
+            return objectsByName;
         }
 
 
@@ -122,7 +130,7 @@ public void Register(string name, object value, bool isAsync, BindingOptions opt
         {
             //Enable WCF if not already enabled - can only be done before the browser has been initliazed
             //if done after the subprocess won't be WCF enabled it we'll have to throw an exception
-            if (!IsBrowserInitialized)
+            if (!IsBrowserInitialized && !isAsync)
             { 
                 CefSharpSettings.WcfEnabled = true;
             }
@@ -148,7 +156,7 @@ public void Register(string name, object value, bool isAsync, BindingOptions opt
             jsObject.Binder = options == null ? null : options.Binder;
             jsObject.MethodInterceptor = options == null ? null : options.MethodInterceptor;
 
-            AnalyseObjectForBinding(jsObject, analyseMethods: true, analyseProperties: isAsync, readPropertyValue: false, camelCaseJavascriptNames: camelCaseJavascriptNames);
+            AnalyseObjectForBinding(jsObject, analyseMethods: true, analyseProperties: !isAsync, readPropertyValue: false, camelCaseJavascriptNames: camelCaseJavascriptNames);
         }
 
         public bool TryCallMethod(long objectId, string name, object[] parameters, out object result, out string exception)
@@ -349,10 +357,10 @@ public bool TrySetProperty(long objectId, string name, object value, out string
         /// </summary>
         /// <param name="obj">Javascript object</param>
         /// <param name="analyseMethods">Analyse methods for inclusion in metadata model</param>
+        /// <param name="analyseProperties">Analyse properties for inclusion in metadata model</param>
         /// <param name="readPropertyValue">When analysis is done on a property, if true then get it's value for transmission over WCF</param>
         /// <param name="camelCaseJavascriptNames">camel case the javascript names of properties/methods</param>
-        /// <param name="analyseProperties">Analyse properties for binding</param>
-        private void AnalyseObjectForBinding(JavascriptObject obj, bool analyseMethods, bool readPropertyValue, bool camelCaseJavascriptNames, bool analyseProperties)
+        private void AnalyseObjectForBinding(JavascriptObject obj, bool analyseMethods, bool analyseProperties, bool readPropertyValue, bool camelCaseJavascriptNames)
         {
             if (obj.Value == null)
             {
@@ -403,7 +411,7 @@ private void AnalyseObjectForBinding(JavascriptObject obj, bool analyseMethods,
                         jsObject.Value = jsProperty.GetValue(obj.Value);
                         jsProperty.JsObject = jsObject;
 
-                        AnalyseObjectForBinding(jsProperty.JsObject, analyseMethods, readPropertyValue, camelCaseJavascriptNames, true);
+                        AnalyseObjectForBinding(jsProperty.JsObject, analyseMethods, analyseProperties: true, readPropertyValue: readPropertyValue, camelCaseJavascriptNames: camelCaseJavascriptNames);
                     }
                     else if (readPropertyValue)
                     {