Skip to content

Commit fef18e2

Browse files
committed
Cleanup Loading and NavState code, there's currently additional calls to both which are slightly confusing (and don't provide any benefit).
So simplify by setting SetIsLoading(true) on LoadStart and SetIsLoading(false) on LoadEnd. Then only set NavState in ClientAdapter::OnLoadingStateChange
1 parent 3cfeaef commit fef18e2

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

CefSharp.Core/Internals/ClientAdapter.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ namespace CefSharp
6262

6363
void ClientAdapter::OnLoadingStateChange(CefRefPtr<CefBrowser> browser, bool isLoading, bool canGoBack, bool canGoForward)
6464
{
65-
_browserControl->SetIsLoading(isLoading);
66-
6765
auto canReload = !isLoading;
6866
_browserControl->SetNavState(canGoBack, canGoForward, canReload);
6967
}
@@ -163,7 +161,6 @@ namespace CefSharp
163161
if (frame->IsMain())
164162
{
165163
_browserControl->SetIsLoading(true);
166-
_browserControl->SetNavState(false, false, false);
167164
}
168165

169166
_browserControl->OnFrameLoadStart(StringUtils::ToClr(frame->GetURL()), frame->IsMain());

0 commit comments

Comments
 (0)