Skip to content

Commit 4cad53f

Browse files
committed
Remove CefRedistCopyDllPak32 and CefRedistCopyDllPak64 targets - files are no longer copied as part of these packages
File copying will be added to CefSharp.Common.targets Former-commit-id: 39c52c95937501b0acab2fa7ed4138fadd8bdb7d
1 parent 0af5fb2 commit 4cad53f

File tree

3 files changed

+26
-30
lines changed

3 files changed

+26
-30
lines changed

NuGet/cef.redist.targets

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,27 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
3-
<!-- Only execute if the Platform folder exists in this package -->
4-
<Target Name="CefRedistCopyDllPak64" BeforeTargets="AfterBuild" Condition="Exists('$(MSBuildThisFileDirectory)..\CEF\$(Platform)')">
5-
<ItemGroup>
6-
<CefBinaries Include="$(MSBuildThisFileDirectory)..\CEF\$(Platform)\*.*" />
7-
<CefPakFiles Include="$(MSBuildThisFileDirectory)..\CEF\*.*" />
8-
<CefLocales Include="$(MSBuildThisFileDirectory)..\CEF\locales\*.*" />
9-
</ItemGroup>
10-
<Message Importance="high" Text="-- cef.redist.targets at $(MSBuildThisFileDirectory)" />
11-
<Message Importance="high" Text="Copying CEF .dll files from $(MSBuildThisFileDirectory)..\CEF\$(Platform) to $(TargetDir)" />
12-
<Copy SourceFiles="@(CefBinaries)" DestinationFolder="$(TargetDir)" SkipUnchangedFiles="true" />
13-
<Message Importance="high" Text="Copying CEF .pak files from $(MSBuildThisFileDirectory)..\CEF to $(TargetDir)" />
14-
<Copy SourceFiles="@(CefPakFiles)" DestinationFolder="$(TargetDir)" SkipUnchangedFiles="true" />
15-
<Message Importance="high" Text="Copying CEF locales from $(MSBuildThisFileDirectory)..\CEF\locales to $(TargetDir)\locales" />
16-
<Copy SourceFiles="@(CefLocales)" DestinationFolder="$(TargetDir)\locales" SkipUnchangedFiles="true" />
17-
</Target>
3+
<!--
4+
Files are no longer copied as part of this targets file.
5+
For projects other than CefSharp define a target to copy the files.
6+
Checkout the CefSharp.Common.targets file for an example
7+
-->
8+
9+
<!--
10+
If this packages contains the x86 folder then set the 32bit properties,
11+
if it contains the x64 folder than set the 64bit properties.
12+
Example if this is a x64 package, their will be a x64 folder in the CEF
13+
directory, if that's the case this package contains the x64 files, so we'll
14+
define those properties.
15+
-->
16+
<ItemGroup Condition="Exists('$(MSBuildThisFileDirectory)..\CEF\x86')">
17+
<CefBinaries32 Include="$(MSBuildThisFileDirectory)..\CEF\x86\*.*" />
18+
<CefPakFiles32 Include="$(MSBuildThisFileDirectory)..\CEF\*.*" />
19+
<CefLocales32 Include="$(MSBuildThisFileDirectory)..\CEF\locales\*.*" />
20+
</ItemGroup>
21+
22+
<ItemGroup Condition="Exists('$(MSBuildThisFileDirectory)..\CEF\x64')">
23+
<CefBinaries64 Include="$(MSBuildThisFileDirectory)..\CEF\x64\*.*" />
24+
<CefPakFiles64 Include="$(MSBuildThisFileDirectory)..\CEF\*.*" />
25+
<CefLocales64 Include="$(MSBuildThisFileDirectory)..\CEF\locales\*.*" />
26+
</ItemGroup>
1827
</Project>

NuGet/cef.sdk.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<PropertyGroup>
4-
<CefSdkVer>cef.sdk.3.2704.1418</CefSdkVer>
4+
<CefSdkVer>cef.sdk.3.2704.1429</CefSdkVer>
55
</PropertyGroup>
66
</Project>

build.ps1

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ $Cef32vcx = Join-Path (Join-Path $Cef32 'libcef_dll_wrapper') 'libcef_dll_wrappe
1616
$Cef64 = Join-Path $WorkingDir 'cef_binary_3.y.z_windows64'
1717
$Cef64vcx = Join-Path (Join-Path $Cef64 'libcef_dll_wrapper') 'libcef_dll_wrapper.vcxproj'
1818

19-
$CefVersion = "3.2704.1424.gc3f0a5b"
19+
$CefVersion = "3.2704.1429.g11ec9b6"
2020
# Take the cef version and strip the commit hash
2121
$CefPackageVersion = $CefVersion.SubString(0, $CefVersion.LastIndexOf('.'))
2222

@@ -342,23 +342,10 @@ function Nupkg
342342
Die "Please install nuget. More information available at: http://docs.nuget.org/docs/start-here/installing-nuget"
343343
}
344344

345-
# Redist target
346-
$RedistTargetsFilename = Resolve-Path ".\nuget\cef.redist.targets"
347-
348-
# Write 32bit redist target
349-
[xml]$Xml = Get-Content $RedistTargetsFilename
350-
$Xml.Project.Target | Foreach-Object { $_.Name = 'CefRedistCopyDllPak32'}
351-
$Xml.Save($RedistTargetsFilename)
352-
353345
# Build 32bit packages
354346
#. $Nuget pack nuget\cef.redist.nuspec -NoPackageAnalysis -Version $CefPackageVersion -Properties 'Configuration=Debug;DotConfiguration=.Debug;Platform=x86;CPlatform=windows32;' -OutputDirectory nuget
355347
. $Nuget pack nuget\cef.redist.nuspec -NoPackageAnalysis -Version $CefPackageVersion -Properties 'Configuration=Release;DotConfiguration=;Platform=x86;CPlatform=windows32;' -OutputDirectory nuget
356348

357-
# Write 64bit redist target
358-
[xml]$Xml = Get-Content $RedistTargetsFilename
359-
$Xml.Project.Target | Foreach-Object { $_.Name = 'CefRedistCopyDllPak64'}
360-
$Xml.Save($RedistTargetsFilename)
361-
362349
# Build 64bit packages
363350
#. $Nuget pack nuget\cef.redist.nuspec -NoPackageAnalysis -Version $CefPackageVersion -Properties 'Configuration=Debug;DotConfiguration=.Debug;Platform=x64;CPlatform=windows64;' -OutputDirectory nuget
364351
. $Nuget pack nuget\cef.redist.nuspec -NoPackageAnalysis -Version $CefPackageVersion -Properties 'Configuration=Release;DotConfiguration=;Platform=x64;CPlatform=windows64;' -OutputDirectory nuget

0 commit comments

Comments
 (0)