Ensure :autoconvert is initialized before :value for rabbitmq_parameter

Author: joec4i

lib/puppet/type/rabbitmq_parameter.rb

@@ -82,6 +82,12 @@
     [self[:name].split('@')[1]]
   end
 
+  def set_parameters(hash) # rubocop:disable Style/AccessorMethodName
+    # Hack to ensure :autoconvert is initialized before :value
+    self[:autoconvert] = hash[:autoconvert] if hash.key?(:autoconvert)
+    super
+  end
+
   def validate_component_name(value)
     raise ArgumentError, 'component_name must be defined' if value.empty?
   end
@@ -96,7 +102,7 @@ def validate_value(value)
   end
 
   def munge_value(value)
-    return value if self[:autoconvert] == :false
+    return value if value(:autoconvert) == :false
     value.each do |k, v|
       value[k] = v.to_i if v =~ %r{\A[-+]?[0-9]+\z}
     end

spec/unit/puppet/type/rabbitmq_parameter_spec.rb

@@ -83,11 +83,19 @@
     expect(parameter[:value]['myparameter']).to eq(1_800_000)
   end
 
-  it 'does not convert numeric string to integer when autoconvert is set to false' do
-    parameter[:autoconvert] = false
-    value = { 'myparameter' => '1800000' }
-    parameter[:value] = value
-    expect(parameter[:value]['myparameter']).to eq('1800000')
-    expect(parameter[:value]['myparameter']).to be_kind_of(String)
+  context 'autoconvert is set to false' do
+    let(:parameter) do
+      Puppet::Type.type(:rabbitmq_parameter).new(
+        name: 'documentumShovel@/',
+        component_name: 'shovel',
+        autoconvert: false,
+        value: { 'myparameter' => '1800000' }
+      )
+    end
+
+    it 'does not convert numeric string to integer' do
+      expect(parameter[:value]['myparameter']).to eq('1800000')
+      expect(parameter[:value]['myparameter']).to be_kind_of(String)
+    end
   end
 end