Add on_delete to ForeignKeys, plus other fixes (#44)

* Fix the tests so they complete again

* Add explicit support for Django 1.11

* Add an explicit on_delete to ForeignKeys

* Add myself to the AUTHORS list

Author: tarkatronic

AUTHORS

@@ -46,6 +46,7 @@ Jeffrey Hu <[email protected]>
 Jens Alm <[email protected]>
 Jerzy Kozera <[email protected]>
 Jesper Noehr <[email protected]>
+Joey Wilhelm <[email protected]>
 John Andrews <johna@stjit011.(none)>
 John Watson <[email protected]>
 Jonas Haag <[email protected]>

django_celery_beat/models.py

@@ -224,16 +224,16 @@ class PeriodicTask(models.Model):
     )
     task = models.CharField(_('task name'), max_length=200)
     interval = models.ForeignKey(
-        IntervalSchedule,
+        IntervalSchedule, on_delete=models.CASCADE,
         null=True, blank=True, verbose_name=_('interval'),
     )
     crontab = models.ForeignKey(
-        CrontabSchedule, null=True, blank=True, verbose_name=_('crontab'),
-        help_text=_('Use one of interval/crontab'),
+        CrontabSchedule, on_delete=models.CASCADE, null=True, blank=True,
+        verbose_name=_('crontab'), help_text=_('Use one of interval/crontab'),
     )
     solar = models.ForeignKey(
-        SolarSchedule, null=True, blank=True, verbose_name=_('solar'),
-        help_text=_('Use a solar schedule')
+        SolarSchedule, on_delete=models.CASCADE, null=True, blank=True,
+        verbose_name=_('solar'), help_text=_('Use a solar schedule')
     )
     args = models.TextField(
         _('Arguments'), blank=True, default='[]',

requirements/test-django111.txt

@@ -0,0 +1 @@
+django>=1.11,<2.0

setup.py

@@ -50,6 +50,7 @@ def _pyimp():
     Framework :: Django :: 1.8
     Framework :: Django :: 1.9
     Framework :: Django :: 1.10
+    Framework :: Django :: 1.11
     Operating System :: OS Independent
     Topic :: Communications
     Topic :: System :: Distributed Computing

t/unit/test_schedulers.py

@@ -106,6 +106,8 @@ def test_entry(self):
         assert e.options['routing_key'] == 'cpu'
 
         right_now = self.app.now()
+        # Entry.last_run_at returns naive tz, so make this naive for comparison
+        right_now = right_now.replace(tzinfo=None)
         m2 = self.create_model_interval(
             schedule(timedelta(seconds=10)),
             last_run_at=right_now,

tox.ini

@@ -1,15 +1,19 @@
 [tox]
 envlist =
+    2.7-django1.11
     2.7-django1.10
     2.7-django1.9
     2.7-django1.8
+    pypy-django1.11
     pypy-django1.10
     pypy-django1.9
     pypy-django1.8
+    3.4-django1.11
     3.4-django1.10
     3.4-django1.9
     3.4-django1.8
-    3.4-django1.10
+    3.5-django1.11
+    3.5-django1.10
     3.5-django1.9
     3.5-django1.8
 
@@ -27,6 +31,7 @@ deps=
 
     cov: -r{toxinidir}/requirements/test-django.txt
 
+    django1.11: -r{toxinidir}/requirements/test-django111.txt
     django1.10: -r{toxinidir}/requirements/test-django110.txt
     django1.9: -r{toxinidir}/requirements/test-django19.txt
     django1.8: -r{toxinidir}/requirements/test-django18.txt