Skip to content

Commit 0aa8e97

Browse files
authored
Fix for missing periodic task name (#445)
* fix for missing periodic task name in rabbitmq * update tests for periodic_task_name
1 parent 416551c commit 0aa8e97

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

django_celery_results/backends/database.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ def _get_extended_properties(self, request, traceback):
8787
if task_kwargs is not None:
8888
_, _, task_kwargs = self.encode_content(task_kwargs)
8989

90-
properties = getattr(request, 'properties', {}) or {}
91-
periodic_task_name = properties.get('periodic_task_name', None)
90+
periodic_task_name = getattr(request, 'periodic_task_name', None)
91+
9292
extended_props.update({
9393
'periodic_task_name': periodic_task_name,
9494
'task_args': task_args,

t/unit/backends/test_database.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,7 @@ def test_on_chord_part_return(self):
789789
request.argsrepr = "argsrepr"
790790
request.kwargsrepr = "kwargsrepr"
791791
request.hostname = "celery@ip-0-0-0-0"
792-
request.properties = {"periodic_task_name": "my_periodic_task"}
792+
request.periodic_task_name = "my_periodic_task"
793793
request.ignore_result = False
794794
result = {"foo": "baz"}
795795

@@ -839,7 +839,7 @@ def test_callback_failure(self):
839839
request.argsrepr = "argsrepr"
840840
request.kwargsrepr = "kwargsrepr"
841841
request.hostname = "celery@ip-0-0-0-0"
842-
request.properties = {"periodic_task_name": "my_periodic_task"}
842+
request.periodic_task_name = "my_periodic_task"
843843
request.ignore_result = False
844844
request.chord.id = cid
845845
result = {"foo": "baz"}
@@ -885,7 +885,7 @@ def test_on_chord_part_return_failure(self):
885885
request.argsrepr = "argsrepr"
886886
request.kwargsrepr = "kwargsrepr"
887887
request.hostname = "celery@ip-0-0-0-0"
888-
request.properties = {"periodic_task_name": "my_periodic_task"}
888+
request.periodic_task_name = "my_periodic_task"
889889
request.chord.id = cid
890890
result = {"foo": "baz"}
891891

@@ -1018,7 +1018,7 @@ def test_on_chord_part_return_multiple_databases(self):
10181018
request.argsrepr = "argsrepr"
10191019
request.kwargsrepr = "kwargsrepr"
10201020
request.hostname = "celery@ip-0-0-0-0"
1021-
request.properties = {"periodic_task_name": "my_periodic_task"}
1021+
request.periodic_task_name = "my_periodic_task"
10221022
request.ignore_result = False
10231023
result = {"foo": "baz"}
10241024

0 commit comments

Comments
 (0)