Send heartbeat frames more often

[arnaudmorin]

The AMQP protocol is saying that we should send "two" "heartbeat frames" during the "heartbeat timeout" (see [1] and rabbit implement this in [2]).

The "two" value is the "rate" parameter in the current implementation.

The current implementation was sending only one frame during the "heartbeat timeout", which is wrong.

[1] https://www.amqp.org/specification/0-9-1/amqp-org-download
[2] https://www.rabbitmq.com/heartbeats.html#heartbeats-interval

[pslestang]

From my POV there is a main issue in the library implementation. The current implementation is mixing heartbeat (the interval between two tick) and the heartbeat timeout on amqp connection.

py-amqp/amqp/connection.py

Lines 441 to 445 in 9d7b36a

	self.send_method(
	spec.Connection.TuneOk, argsig,
	(self.channel_max, self.frame_max, self.heartbeat),
	callback=self._on_tune_sent,
	)

As written in rabbitmq documentation "It is important to not confuse the timeout value with the interval one".

The amqp connection should be open with the heartbeat timeout taking care of timeout negotiation with server and then send a tick every heartbeat interval.

Technically it is enough to get the heartbeat timeout and the heartbeat rate to compute the heartbeat interval.

[arnaudmorin]

Units are green on my side, is there anything wrong in the github actions?

[auvipy]

I restarted

[arnaudmorin]

up

[arnaudmorin]

recheck

[auvipy]

From my POV there is a main issue in the library implementation. The current implementation is mixing heartbeat (the interval between two tick) and the heartbeat timeout on amqp connection.

py-amqp/amqp/connection.py

Lines 441 to 445 in 9d7b36a

	self.send_method(
	spec.Connection.TuneOk, argsig,
	(self.channel_max, self.frame_max, self.heartbeat),
	callback=self._on_tune_sent,
	)

As written in rabbitmq documentation "It is important to not confuse the timeout value with the interval one".

The amqp connection should be open with the heartbeat timeout taking care of timeout negotiation with server and then send a tick every heartbeat interval.

Technically it is enough to get the heartbeat timeout and the heartbeat rate to compute the heartbeat interval.

@arnaudmorin I would like to know your POV on this

[arnaudmorin]

I agree with what Pierre Samuel is explaining, but refactoring this would lead to an API change (the parameter would be renamed / reconfigured), and I dont think this is something we want on py-amqp now.

Eventually this could be done in another change.

[auvipy]

can you please try to change the rabbitmq docker image to fix the integration test?

[auvipy]

lets see how this #414 go

[auvipy]

you can rebase now