feat(cli): Add operations commands

dnys1 · dnys1 · commit 5987adec36b5 · 2025-04-27T19:27:06.000-07:00
Add commands for working with cloud operations.
diff --git a/apps/cli/bin/celest.dart b/apps/cli/bin/celest.dart
@@ -1,5 +1,6 @@
 import 'package:celest_cli/celest_cli.dart';
 import 'package:celest_cli/src/commands/auth/auth_command.dart';
+import 'package:celest_cli/src/commands/cloud/operations/operations_command.dart';
 import 'package:celest_cli/src/commands/cloud/organizations/organizations_command.dart';
 import 'package:celest_cli/src/commands/cloud/project_environments/project_environments_command.dart';
 import 'package:celest_cli/src/commands/cloud/projects/projects_command.dart';
@@ -32,7 +33,8 @@ void main(List<String> args) async {
   cli
     ..addCommand(OrganizationsCommand())
     ..addCommand(ProjectsCommand())
-    ..addCommand(ProjectEnvironmentsCommand());
+    ..addCommand(ProjectEnvironmentsCommand())
+    ..addCommand(OperationsCommand());
 
   await cli.run(args);
 }
diff --git a/apps/cli/lib/src/commands/cloud/cloud_command.dart b/apps/cli/lib/src/commands/cloud/cloud_command.dart
@@ -484,6 +484,8 @@ abstract base class CloudDeleteCommand<R extends GeneratedMessage>
 
 extension type CloudCommandOptions(ArgResults argResults)
     implements ArgResults {
+  String? get maybeResourceId => rest.elementAtOrNull(0);
+
   String get resourceId {
     final id = rest.elementAtOrNull(0);
     if (id == null) {
diff --git a/apps/cli/lib/src/commands/cloud/operations/get_operation_command.dart b/apps/cli/lib/src/commands/cloud/operations/get_operation_command.dart
@@ -0,0 +1,22 @@
+import 'package:celest_cli/src/commands/cloud/cloud_command.dart';
+import 'package:celest_cli/src/context.dart' show cloud;
+import 'package:celest_cloud/celest_cloud.dart';
+
+final class GetOperationCommand extends CloudGetCommand<Operation> {
+  @override
+  String get description => 'Gets an operation.';
+
+  @override
+  String get name => 'get';
+
+  @override
+  String get resourceType => 'Operation';
+
+  @override
+  Operation createEmptyResource() => Operation();
+
+  @override
+  Future<Operation?> callService() async {
+    return cloud.operations.get(options.resourceId);
+  }
+}
diff --git a/apps/cli/lib/src/commands/cloud/operations/list_operations_command.dart b/apps/cli/lib/src/commands/cloud/operations/list_operations_command.dart
@@ -0,0 +1,44 @@
+import 'package:celest_cli/src/commands/cloud/cloud_command.dart';
+import 'package:celest_cli/src/context.dart' show cloud;
+import 'package:celest_cloud/celest_cloud.dart';
+import 'package:celest_cloud_core/celest_cloud_core.dart';
+
+final class ListOperationsCommand extends CloudListCommand<Operation> {
+  @override
+  String get description => 'Lists operations.';
+
+  @override
+  String get name => 'list';
+
+  @override
+  String get resourceType => 'Operation';
+
+  @override
+  String? get parentResourceType => null;
+
+  @override
+  Operation createEmptyResource() => Operation();
+
+  @override
+  Future<CloudListResult<Operation>> callService() async {
+    var filter = options.filter;
+    if (options.maybeResourceId case final resourceId?) {
+      final resourceName = ResourceName.parse(resourceId);
+      final resourceFilter = 'resource_type = "${resourceName.uid.type}" AND '
+          'resource_id = "${resourceName.uid.id}"';
+      if (filter == null || filter.isEmpty) {
+        filter = resourceFilter;
+      } else {
+        filter = '$filter AND $resourceFilter';
+      }
+    }
+    final result = await cloud.operations.list(
+      filter: filter,
+      pageSize: options.pageSize,
+    );
+    return (
+      items: result.operations,
+      nextPageToken: result.hasNextPageToken() ? result.nextPageToken : null,
+    );
+  }
+}
diff --git a/apps/cli/lib/src/commands/cloud/operations/operations_command.dart b/apps/cli/lib/src/commands/cloud/operations/operations_command.dart
@@ -0,0 +1,22 @@
+import 'package:celest_cli/src/commands/celest_command.dart';
+import 'package:celest_cli/src/commands/cloud/operations/get_operation_command.dart';
+import 'package:celest_cli/src/commands/cloud/operations/list_operations_command.dart';
+
+final class OperationsCommand extends CelestCommand {
+  OperationsCommand() {
+    addSubcommand(GetOperationCommand());
+    addSubcommand(ListOperationsCommand());
+  }
+
+  @override
+  String get description => 'Manage Celest Cloud operations.';
+
+  @override
+  String get name => 'operations';
+
+  @override
+  String get category => 'Cloud';
+
+  @override
+  bool get hidden => true;
+}
diff --git a/packages/celest_cloud/CHANGELOG.md b/packages/celest_cloud/CHANGELOG.md
@@ -1,6 +1,7 @@
-# 0.1.8
+# 0.1.8-wip
 
 - feat: Add `ProjectAsset_Type.DART_EXECUTABLE`
+- fix: Incorrect route for `Operations.listOperations`
 
 # 0.1.7
 
diff --git a/packages/celest_cloud/lib/src/cloud/operations/operations_protocol.http.dart b/packages/celest_cloud/lib/src/cloud/operations/operations_protocol.http.dart
@@ -65,10 +65,14 @@ final class OperationsProtocolHttp
 
   @override
   Future<ListOperationsResponse> list(ListOperationsRequest request) async {
-    if (request.name == '') {
-      throw ArgumentError.value(request.name, 'name', 'must not be empty');
+    if (request.name.isNotEmpty) {
+      throw ArgumentError.value(
+        request.name,
+        'name',
+        'only empty name is allowed',
+      );
     }
-    final path = '/v1alpha1/${request.name}/operations';
+    const path = '/v1alpha1/operations';
     final url = _baseUri.replace(
       path: path,
       queryParameters: {
diff --git a/packages/celest_cloud/pubspec.yaml b/packages/celest_cloud/pubspec.yaml
@@ -1,6 +1,6 @@
 name: celest_cloud
 description: API contracts and Dart clients for the Celest Cloud platform.
-version: 0.1.8
+version: 0.1.8-wip
 repository: https://github.com/celest-dev/celest
 
 environment:
diff --git a/services/celest_cloud_core/lib/celest_cloud_core.dart b/services/celest_cloud_core/lib/celest_cloud_core.dart
@@ -4,4 +4,6 @@ library;
 export 'src/model/filter.dart';
 export 'src/model/order_by.dart';
 export 'src/model/page_token.dart';
-export 'src/model/resource.dart';
+export 'src/model/resource_name.dart';
+export 'src/model/resource_table.dart';
+export 'src/model/resource_type.dart';
diff --git a/services/celest_cloud_core/lib/src/model/filter.dart b/services/celest_cloud_core/lib/src/model/filter.dart
@@ -28,7 +28,7 @@ sealed class Filter {
     String filter, {
     AnyDriftTable? table,
   }) {
-    final parser = _createParser(table: table);
+    final parser = _parserCache[table] ??= _createParser(table: table);
     final result = parser.parse(filter);
     switch (result) {
       case Success(:final value):
@@ -304,6 +304,8 @@ sealed class Filter {
     return expression.end();
   }
 
+  static final Map<AnyDriftTable?, Parser<Filter>> _parserCache = {};
+
   /// Converts this filter to a [DriftFilter] function.
   DriftFilter<Tbl> toDrift<Tbl extends ResultSetImplementation<Tbl, Object?>>();
 
diff --git a/services/celest_cloud_core/lib/src/model/resource_name.dart b/services/celest_cloud_core/lib/src/model/resource_name.dart
@@ -0,0 +1,63 @@
+import 'package:cedar/ast.dart';
+import 'package:celest_cloud_core/src/model/resource_type.dart';
+
+typedef _ResourceNameInfo = ({
+  ResourceType type,
+  EntityUid uid,
+  List<EntityUid> parents,
+});
+
+/// A resource name in Celest Cloud.
+///
+/// Example: `organizations/123/projects/456/environments/789`
+extension type ResourceName(_ResourceNameInfo _info) {
+  /// Parses a resource name string into a [ResourceName] object.
+  factory ResourceName.parse(String name) {
+    final segments = name.split('/').reversed.toList();
+    if (segments.length < 2 || segments.length % 2 != 0) {
+      throw ArgumentError('Invalid resource name: $name');
+    }
+
+    (ResourceType, String)? uid;
+    final parents = <EntityUid>[];
+    for (var i = 0; i < segments.length; i += 2) {
+      final type = segments[i + 1];
+      final id = segments[i];
+      if (type.isEmpty || id.isEmpty) {
+        throw ArgumentError('Invalid resource name: $name');
+      }
+      final resourceType = ResourceType.fromPatternType(type);
+      if (uid == null) {
+        uid = (resourceType, id);
+      } else {
+        parents.add(resourceType.uid(id));
+      }
+    }
+
+    final (resourceType, id) = uid!;
+    return ResourceName((
+      type: resourceType,
+      uid: resourceType.uid(id),
+      parents: parents,
+    ));
+  }
+
+  /// A map of resource pattern types to their Cedar entity types.
+  static const Map<String, EntityTypeName> entityTypes = {
+    'operations': EntityTypeName('Celest::Operation'),
+    'users': EntityTypeName('Celest::User'),
+    'sessions': EntityTypeName('Celest::Session'),
+    'projects': EntityTypeName('Celest::Project'),
+    'organizations': EntityTypeName('Celest::Organization'),
+    'environments': EntityTypeName('Celest::Project::Environment'),
+  };
+
+  /// The resource type for this resource.
+  ResourceType get type => _info.type;
+
+  /// The unique identifier for this resource.
+  EntityUid get uid => _info.uid;
+
+  /// The list of parent resources for this resource.
+  List<EntityUid> get parents => _info.parents;
+}
diff --git a/services/celest_cloud_core/lib/src/model/resource_table.dart b/services/celest_cloud_core/lib/src/model/resource_table.dart
diff --git a/services/celest_cloud_core/lib/src/model/resource_type.dart b/services/celest_cloud_core/lib/src/model/resource_type.dart
@@ -0,0 +1,79 @@
+import 'package:cedar/cedar.dart';
+
+/// A resource type in Celest Cloud.
+enum ResourceType {
+  /// A Celest operation.
+  operation(
+    patternType: 'operations',
+    entityType: EntityTypeName('Celest::Operation'),
+  ),
+
+  /// A Celest user.
+  user(
+    patternType: 'users',
+    entityType: EntityTypeName('Celest::User'),
+  ),
+
+  /// A Celest session.
+  session(
+    patternType: 'sessions',
+    entityType: EntityTypeName('Celest::Session'),
+  ),
+
+  /// A Celest project.
+  project(
+    patternType: 'projects',
+    patternParentType: organization,
+    entityType: EntityTypeName('Celest::Project'),
+  ),
+
+  /// A Celest organization.
+  organization(
+    patternType: 'organizations',
+    entityType: EntityTypeName('Celest::Organization'),
+  ),
+
+  /// A Celest environment.
+  projectEnvironment(
+    patternType: 'environments',
+    patternParentType: project,
+    entityType: EntityTypeName('Celest::Project::Environment'),
+  );
+
+  const ResourceType({
+    required this.patternType,
+    this.patternParentType,
+    required this.entityType,
+  });
+
+  /// The resource type for the given pattern type.
+  factory ResourceType.fromPatternType(String patternType) {
+    return ResourceType.values.firstWhere(
+      (type) => type.patternType == patternType,
+      orElse: () =>
+          throw FormatException('Invalid resource type: $patternType'),
+    );
+  }
+
+  /// The resource type for the given Cedar entity type.
+  factory ResourceType.fromEntityType(EntityTypeName entityType) {
+    return ResourceType.values.firstWhere(
+      (type) => type.entityType == entityType,
+      orElse: () => throw FormatException('Invalid resource type: $entityType'),
+    );
+  }
+
+  /// The pattern type for this resource.
+  final String patternType;
+
+  /// The parent resource type in patterns.
+  final ResourceType? patternParentType;
+
+  /// The Cedar entity type for this resource.
+  final EntityTypeName entityType;
+
+  /// Creates a new [EntityUid] for this resource type and the given [id].
+  EntityUid uid(String id) {
+    return EntityUid(entityType, EntityId(id));
+  }
+}
diff --git a/services/celest_cloud_core/pubspec.yaml b/services/celest_cloud_core/pubspec.yaml
@@ -7,7 +7,8 @@ environment:
 resolution: workspace
 
 dependencies:
-  celest_cloud: ^0.1.8
+  cedar: ^0.2.5
+  celest_cloud: ^0.1.8-0
   celest_core: ^1.0.0
   collection: ^1.18.0
   drift: '>=2.26.0 <2.27.0'
diff --git a/services/celest_cloud_hub/bin/cloud_hub.dart b/services/celest_cloud_hub/bin/cloud_hub.dart
@@ -23,6 +23,7 @@ import 'package:celest_cloud_hub/src/services/organizations_service.dart';
 import 'package:celest_cloud_hub/src/services/project_environments_service.dart';
 import 'package:celest_cloud_hub/src/services/projects_service.dart';
 import 'package:celest_core/_internal.dart';
+import 'package:drift/drift.dart' show driftRuntimeOptions;
 import 'package:grpc/grpc.dart' as grpc;
 import 'package:logging/logging.dart';
 import 'package:sentry/sentry.dart';
@@ -46,6 +47,10 @@ Future<void> main() async {
       print(record.stackTrace);
     }
   });
+  driftRuntimeOptions.debugPrint = (message) {
+    context.logger.finest(message);
+  };
+
   context.put(ContextKey.project, project);
   context.put(
     env.environment,
@@ -96,6 +101,7 @@ Future<void> _run() async {
     hostnameVariable: const env('CLOUD_HUB_DATABASE_HOST'),
     tokenSecret: const secret('CLOUD_HUB_DATABASE_TOKEN'),
     setup: (db) => db.addHelperFunctions(),
+    logStatements: context.logger.level <= Level.FINEST,
   );
   await db.ping();
 
diff --git a/services/celest_cloud_hub/lib/src/database/schema/operations.drift b/services/celest_cloud_hub/lib/src/database/schema/operations.drift
@@ -210,25 +210,18 @@ findOperationsByResource:
     LIMIT :limit;
 
 listOperations(
-    :owner_type AS TEXT OR NULL,
-    :owner_id AS TEXT OR NULL,
-    :resource_type AS TEXT OR NULL,
-    :resource_id AS TEXT OR NULL,
-    :start_time AS DATETIME OR NULL,
+    :startTime AS DATETIME OR NULL,
     :offset AS INTEGER,
     :limit AS INTEGER
 ):
     WITH rowed AS(
         SELECT 
             ROW_NUMBER() OVER (ORDER BY create_time DESC) AS row_num,
             id
-        FROM operations
+        FROM operations ops
         WHERE
-            (operations.owner_type IS NULL AND :owner_type IS NULL OR operations.owner_type = :owner_type) AND
-            (operations.owner_id IS NULL AND :owner_id IS NULL OR operations.owner_id = :owner_id) AND
-            (operations.resource_type IS NULL AND :resource_type IS NULL OR operations.resource_type = :resource_type) AND
-            (operations.resource_id IS NULL AND :resource_id IS NULL OR operations.resource_id = :resource_id) AND
-            operations.create_time < coalesce(:start_time, unixepoch('now', '+1 second', 'subsec'))
+            $filter AND
+            ops.create_time < coalesce(:startTime, unixepoch('now', '+1 second', 'subsec'))
     )
     SELECT
         row_num,
diff --git a/services/celest_cloud_hub/lib/src/database/schema/operations.drift.dart b/services/celest_cloud_hub/lib/src/database/schema/operations.drift.dart
diff --git a/services/celest_cloud_hub/lib/src/services/operations_service.dart b/services/celest_cloud_hub/lib/src/services/operations_service.dart
diff --git a/services/celest_cloud_hub/pubspec.yaml b/services/celest_cloud_hub/pubspec.yaml
diff --git a/services/celest_cloud_hub/test/services/operations_service_e2e_test.dart b/services/celest_cloud_hub/test/services/operations_service_e2e_test.dart
diff --git a/services/celest_cloud_hub/test/services/operations_service_test.dart b/services/celest_cloud_hub/test/services/operations_service_test.dart
