Skip to content

Commit 79c34c7

Browse files
authored
chore(cli): Update goldens (#251)
- Update goldens for Flutter 3.29.2 - Fix SDK version in `dart_sdk_finder.dart` - Fix client pubspec generation (previously handled by V1 migrator) - Re-enable fixture tests on all platforms
1 parent 67b02e2 commit 79c34c7

File tree

43 files changed

+216
-256
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+216
-256
lines changed

.github/workflows/celest_cli.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- macos-latest
2727
- windows-latest
2828
runs-on: ${{ matrix.os }}
29-
timeout-minutes: 20
29+
timeout-minutes: 30 # Windows is really slow
3030
steps:
3131
- name: Git Checkout
3232
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2
@@ -36,7 +36,7 @@ jobs:
3636
cache: true
3737
# Because many golden tests encode the precise Dart/Flutter SDKs used to generate
3838
# them, these values must be consistently used when running tests locally and in CI.
39-
flutter-version: 3.29.1
39+
flutter-version: 3.29.2
4040
- name: Setup Libsecret
4141
if: runner.os == 'Linux'
4242
run: tool/setup-ci.sh
@@ -47,6 +47,5 @@ jobs:
4747
working-directory: apps/cli
4848
run: dart test -x e2e --fail-fast -j 1
4949
- name: Test (Fixtures)
50-
if: runner.os == 'macOS' # TODO: Goldens differ on other OSes
5150
working-directory: apps/cli
5251
run: dart test fixtures/fixtures_test.dart --fail-fast -j 1

apps/cli/fixtures/standalone/api/client/lib/api_client.dart

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -18,88 +18,88 @@ import 'package:native_storage/native_storage.dart'
1818
export 'package:celest_backend/exceptions/demo.dart' show BadNameException;
1919
export 'package:celest_backend/exceptions/exceptions.dart'
2020
show
21-
CustomException,
22-
CustomExceptionToFromJson,
2321
CustomError,
2422
CustomErrorToFromJson,
25-
CustomErrorWithStackTrace;
23+
CustomErrorWithStackTrace,
24+
CustomException,
25+
CustomExceptionToFromJson;
2626
export 'package:celest_backend/exceptions/overrides.dart'
2727
show OverriddenException;
2828
export 'package:celest_backend/models/classes.dart'
2929
show
30+
DefaultValues,
3031
Empty,
3132
Fields,
32-
NamedFields,
33+
FromJsonAndToJson,
34+
FromJsonStatic,
3335
MixedFields,
34-
DefaultValues,
36+
NamedFields,
3537
NestedClass,
36-
OnlyFromJson,
37-
OnlyToJson,
38-
OnlyToJsonWithDefaults,
39-
FromJsonAndToJson,
38+
NonMapFromAndToJson,
4039
NonMapToJson,
4140
NonMapToJsonWithDefaults,
42-
NonMapFromAndToJson,
43-
FromJsonStatic;
41+
OnlyFromJson,
42+
OnlyToJson,
43+
OnlyToJsonWithDefaults;
4444
export 'package:celest_backend/models/cycles.dart'
4545
show Node, Parent, SelfReferencing;
4646
export 'package:celest_backend/models/demo.dart' show Person;
4747
export 'package:celest_backend/models/exceptions.dart'
48-
show SupportedExceptionType, SupportedErrorType;
48+
show SupportedErrorType, SupportedExceptionType;
4949
export 'package:celest_backend/models/extension_types.dart'
5050
show
51+
Color,
52+
ColorX,
53+
ColorXFromJson,
54+
ColorXFromJsonImpl,
55+
ColorXFromJsonStatic,
56+
ColorXImpl,
57+
ColorXToFromJson,
58+
ColorXToJson,
59+
ColorXToJsonImpl,
5160
StringX,
52-
StringXImpl,
53-
StringXToFromJson,
54-
StringXToJson,
55-
StringXToJsonImpl,
5661
StringXFromJson,
5762
StringXFromJsonImpl,
5863
StringXFromJsonStatic,
59-
StringXPrivateField,
60-
StringXPrivateFieldImpl,
64+
StringXImpl,
6165
StringXPrivateCtor,
6266
StringXPrivateCtorImpl,
67+
StringXPrivateField,
68+
StringXPrivateFieldImpl,
69+
StringXToFromJson,
70+
StringXToJson,
71+
StringXToJsonImpl,
6372
Value,
6473
ValueX,
65-
ValueXImpl,
66-
ValueXToFromJson,
67-
ValueXToJson,
68-
ValueXToJsonImpl,
6974
ValueXFromJson,
7075
ValueXFromJsonImpl,
7176
ValueXFromJsonStatic,
72-
Color,
73-
ColorX,
74-
ColorXImpl,
75-
ColorXToFromJson,
76-
ColorXToJson,
77-
ColorXToJsonImpl,
78-
ColorXFromJson,
79-
ColorXFromJsonImpl,
80-
ColorXFromJsonStatic;
77+
ValueXImpl,
78+
ValueXToFromJson,
79+
ValueXToJson,
80+
ValueXToJsonImpl;
8181
export 'package:celest_backend/models/generic_wrappers.dart'
8282
show GenericWrappers;
8383
export 'package:celest_backend/models/metadata.dart'
84-
show Exportable, Serializable, LiteralEnum;
84+
show Exportable, LiteralEnum, Serializable;
8585
export 'package:celest_backend/models/overrides.dart'
86-
show NestedGrandparent, NestedParent, NestedChild;
86+
show NestedChild, NestedGrandparent, NestedParent;
8787
export 'package:celest_backend/models/parameter_types.dart'
88-
show MyEnum, SimpleStruct, ComplexStruct, SimpleClass, ComplexClass;
88+
show ComplexClass, ComplexStruct, MyEnum, SimpleClass, SimpleStruct;
8989
export 'package:celest_backend/models/records.dart'
9090
show NamedFieldsRecord, Nested, NullableNested;
9191
export 'package:celest_backend/models/sealed_classes.dart'
9292
show
93-
Shape,
94-
Rectangle,
9593
Circle,
9694
CircleWithOverriddenCustomJson,
95+
OkResult,
96+
OkShapeResult,
97+
Rectangle,
9798
RectangleWithOverriddenCustomJson,
98-
ShapeWithOverriddenCustomJson,
99-
SwappedResult,
10099
Result,
101-
OkResult,
102-
OkShapeResult;
100+
Shape,
101+
ShapeWithOverriddenCustomJson,
102+
SwappedResult;
103103
export 'package:celest_backend/models/typedefs.dart' show Portfolio;
104104

105105
final Celest celest = Celest();

apps/cli/fixtures/standalone/api/goldens/ast.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/cli/fixtures/standalone/api/goldens/ast.resolved.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/cli/fixtures/standalone/api/goldens/celest.json

Lines changed: 6 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/cli/fixtures/standalone/auth/goldens/ast.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/cli/fixtures/standalone/auth/goldens/ast.resolved.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/cli/fixtures/standalone/auth/goldens/celest.json

Lines changed: 6 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/cli/fixtures/standalone/data/client/lib/data_client.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import 'package:native_storage/native_storage.dart'
1616
as _$native_storage_native_storage;
1717

1818
export 'package:celest_backend/src/database/task_database.dart'
19-
show Task, Priority;
19+
show Priority, Task;
2020

2121
final Celest celest = Celest();
2222

apps/cli/fixtures/standalone/data/goldens/ast.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)