fix(cli): Sentry integration (#336)

Ensure Sentry integration handles all errors raised and respects NO_ANALYTICS setting.

Author: dnys1

apps/cli/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## NEXT
 
 - fix: Pass `flutter_assets` to backend when using `celest deploy`
+- fix: Sentry integration
 
 ## 1.0.10+2
 

apps/cli/lib/src/cli/cli.dart

@@ -84,10 +84,10 @@ final class Cli {
         (sentryDsn == null
             ? ctx.httpClient
             : SentryHttpClient(client: ctx.httpClient));
-    ctx.performance = (sentryDsn == null ||
-            io.Platform.environment.containsKey('CELEST_NO_ANALYTICS'))
-        ? const CelestPerformance()
-        : const SentryPerformance();
+    ctx.performance = sentryDsn != null &&
+            !io.Platform.environment.containsKey('CELEST_NO_ANALYTICS')
+        ? const SentryPerformance()
+        : const CelestPerformance();
     ctx.storage = storage ?? Storage();
 
     try {
@@ -114,18 +114,14 @@ final class Cli {
       ctx.secureStorage = NativeMemoryStorage(namespace: Storage.cliNamespace);
     }
 
-    ctx.analytics = postHogConfig == null ||
-            io.Platform.environment.containsKey('CELEST_NO_ANALYTICS')
-        ? const NoopAnalytics()
-        : PostHog(
+    ctx.analytics = postHogConfig != null &&
+            !io.Platform.environment.containsKey('CELEST_NO_ANALYTICS')
+        ? PostHog(
             config: postHogConfig,
             client: ctx.httpClient,
             storage: ctx.secureStorage,
-          );
-
-    if (kReleaseMode) {
-      ctx.analytics.identifyUser(setOnce: {'local_iterations_mvp': true});
-    }
+          )
+        : const NoopAnalytics();
 
     final sdkFinder = DartSdkFinder(
       platform: ctx.platform,
@@ -225,6 +221,8 @@ final class Cli {
             );
         },
         appRunner: () => _run(argResults),
+        // We use our own error handling, so we don't want to use the default
+        // `runZonedGuarded` behavior.
         // ignore: invalid_use_of_internal_member
         callAppRunnerInRunZonedGuarded: false,
       );
@@ -359,6 +357,13 @@ final class Cli {
   }
 
   Future<void> _handleError(Object error, StackTrace stackTrace) async {
+    Future<void> recordError() async {
+      await ctx.performance
+          .innerCaptureError(error, stackTrace: stackTrace)
+          .timeout(const Duration(seconds: 3))
+          .catchError((_) => '');
+    }
+
     switch (error) {
       case UsageException():
         stderr.writeln(error);
@@ -374,13 +379,15 @@ final class Cli {
             ..writeln(stackTrace);
         }
         exitCode = 1;
+        await recordError();
       default:
         _logFile
           ?..writeln(error)
           ..writeln(stackTrace);
         ctx.cliLogger
           ..err(error.toString())
           ..detail(stackTrace.toString());
+        await recordError();
     }
   }
 
@@ -393,6 +400,7 @@ final class Cli {
     await _loggerSub?.cancel();
     await _logFile?.flush();
     await _logFile?.close();
+    await ctx.performance.close();
     ctx.httpClient.close();
     exit(exitCode);
   }

apps/cli/lib/src/context.dart

@@ -4,6 +4,7 @@ import 'package:analyzer/src/dart/analysis/byte_store.dart';
 import 'package:analyzer/src/dart/element/inheritance_manager3.dart';
 import 'package:celest_cli/src/analytics/interface.dart';
 import 'package:celest_cli/src/analytics/noop.dart';
+import 'package:celest_cli/src/cli/cli_runtime.dart';
 import 'package:celest_cli/src/commands/auth/cli_auth.dart';
 import 'package:celest_cli/src/database/cache/cache_database.dart';
 import 'package:celest_cli/src/database/project/project_database.dart';
@@ -17,7 +18,6 @@ import 'package:celest_cli/src/storage/storage.dart';
 import 'package:celest_cli/src/types/type_helper.dart';
 import 'package:celest_cli/src/version.dart';
 import 'package:celest_cloud/celest_cloud.dart';
-import 'package:celest_core/_internal.dart';
 import 'package:file/file.dart';
 import 'package:file/local.dart';
 import 'package:http/http.dart' as http;
@@ -124,7 +124,10 @@ String? get celestLocalPath {
 /// The identifier for the current CLI environment.
 ///
 /// This should be used in Sentry/PostHog to identify events.
-const String kCliEnvironment = kReleaseMode ? 'release' : 'debug';
+final String kCliEnvironment = switch (CliRuntime.current) {
+  CliRuntime.aot || CliRuntime.pubGlobal => 'release',
+  CliRuntime.local => 'debug',
+};
 
 /// Whether the current terminal supports ANSI output.
 ///

apps/cli/lib/src/performance/local_perf.dart

@@ -39,4 +39,8 @@ base class CelestPerformance {
     );
     return result;
   }
+
+  Future<void> close() async {
+    // No-op
+  }
 }

apps/cli/lib/src/performance/sentry_perf.dart

@@ -54,4 +54,11 @@ base class SentryPerformance extends CelestPerformance {
       await transaction.finish();
     }
   }
+
+  @override
+  Future<void> close() async {
+    if (Sentry.isEnabled) {
+      await Sentry.close();
+    }
+  }
 }