fix(cli): Auth issues (#257)

- Ensure we call `_auth.init` only after initialization
- Ensure auth APIs are linked in the resolved AST

Author: dnys1

apps/cli/fixtures/fixtures_test.dart

@@ -20,7 +20,7 @@ import 'package:celest_cli/src/database/project/project_database.dart';
 import 'package:celest_cli/src/env/config_value_solver.dart';
 import 'package:celest_cli/src/init/project_migrator.dart';
 import 'package:celest_cli/src/project/celest_project.dart';
-import 'package:celest_cli/src/project/project_resolver.dart';
+import 'package:celest_cli/src/project/project_linker.dart';
 import 'package:celest_cli/src/pub/pub_action.dart';
 import 'package:celest_cli/src/sdk/dart_sdk.dart';
 import 'package:celest_cli/src/sdk/sdk_finder.dart';
@@ -245,7 +245,7 @@ class TestRunner {
         project: project!,
         environmentId: 'local',
       ).solveAll();
-      final projectResolver = ProjectResolver(
+      final projectResolver = ProjectLinker(
         configValues: configValues,
         environmentId: 'local',
       );
@@ -295,7 +295,7 @@ class TestRunner {
         project: project!,
         environmentId: 'local',
       ).solveAll();
-      final projectResolver = ProjectResolver(
+      final projectResolver = ProjectLinker(
         configValues: configValues,
         environmentId: 'local',
       );
@@ -331,7 +331,7 @@ class TestRunner {
         project: project!,
         environmentId: 'local',
       ).solveAll();
-      final projectResolver = ProjectResolver(
+      final projectResolver = ProjectLinker(
         configValues: configValues,
         environmentId: 'local',
       );
@@ -409,7 +409,7 @@ class TestRunner {
           project: project!,
           environmentId: 'local',
         ).solveAll();
-        final projectResolver = ProjectResolver(
+        final projectResolver = ProjectLinker(
           configValues: configValues,
           environmentId: 'local',
         );

apps/cli/lib/src/codegen/client/client_generator.dart

@@ -399,15 +399,12 @@ final class ClientGenerator {
         )
         ..addExpression(
           refer('scheduleMicrotask', 'dart:async').call([
-            if (hasExternalAuth)
-              Method(
-                (m) => m
-                  ..body = refer('_auth').property('init').call([], {
-                    'externalAuth': refer('externalAuth'),
-                  }).code,
-              ).closure
-            else
-              refer('_auth').property('init'),
+            Method(
+              (m) => m
+                ..body = refer('_auth').property('init').call([], {
+                  if (hasExternalAuth) 'externalAuth': refer('externalAuth'),
+                }).code,
+            ).closure
           ]),
         );
     }

apps/cli/lib/src/frontend/celest_frontend.dart

@@ -19,7 +19,7 @@ import 'package:celest_cli/src/env/config_value_solver.dart';
 import 'package:celest_cli/src/exceptions.dart';
 import 'package:celest_cli/src/frontend/child_process.dart';
 import 'package:celest_cli/src/project/celest_project.dart';
-import 'package:celest_cli/src/project/project_resolver.dart';
+import 'package:celest_cli/src/project/project_linker.dart';
 import 'package:celest_cli/src/utils/json.dart';
 import 'package:logging/logging.dart';
 import 'package:mason_logger/mason_logger.dart' show Progress;
@@ -367,9 +367,10 @@ final class CelestFrontend {
 
         // Wait for the next changeset or for the child process to exit, if
         // there is one.
-        final exitCode = await Future.any([
+        final exitCode = await Future.any<int?>([
           _nextChangeSet().then((_) => null),
-          Future.value(childProcess?.exitCode),
+          if (childProcess case final childProcess?)
+            Future.value(childProcess.exitCode),
         ]);
         if (exitCode != null) {
           return exitCode;
@@ -507,7 +508,7 @@ final class CelestFrontend {
           environmentId: environmentId,
         ).solveAll();
         logger.fine('Resolving project...');
-        final projectResolver = ProjectResolver(
+        final projectResolver = ProjectLinker(
           configValues: configValues,
           environmentId: environmentId,
         );

…li/lib/src/project/project_resolver.dart …/cli/lib/src/project/project_linker.dartapps/cli/lib/src/project/project_resolver.dart renamed to apps/cli/lib/src/project/project_linker.dart apps/cli/lib/src/project/project_resolver.dart renamed to apps/cli/lib/src/project/project_linker.dart

@@ -3,6 +3,8 @@ import 'package:cedar/cedar.dart';
 import 'package:celest_ast/celest_ast.dart';
 import 'package:celest_cli/src/utils/error.dart';
 import 'package:celest_cli/src/utils/run.dart';
+import 'package:celest_cloud_auth/celest_cloud_auth.dart'
+    show AuthenticationService;
 
 extension on CloudFunction {
   EntityUid get uid => EntityUid.of('Celest::Function', '$apiName/$name');
@@ -65,8 +67,8 @@ extension on ApiAuth {
   }
 }
 
-final class ProjectResolver extends AstVisitorWithArg<Node?, AstNode> {
-  ProjectResolver({
+final class ProjectLinker extends AstVisitorWithArg<Node?, AstNode> {
+  ProjectLinker({
     required Map<String, String> configValues,
     required String environmentId,
     this.driftSchemas = const {},
@@ -218,6 +220,20 @@ final class ProjectResolver extends AstVisitorWithArg<Node?, AstNode> {
 
   @override
   ResolvedAuth visitAuth(Auth auth, Project context) {
+    assert(
+      auth.providers.isNotEmpty || auth.externalProviders.isNotEmpty,
+      'Must have at least one auth provider',
+    );
+
+    // Ensure auth routes are exposed in the route map.
+    //
+    // External auth providers do not require custom routes exposed on the
+    // Celest backend.
+    if (auth.providers.isNotEmpty) {
+      final authService = AuthenticationService.api;
+      _resolvedProject.apis[authService.apiId] = authService;
+    }
+
     return ResolvedAuth.build((b) {
       for (final authProvider in auth.providers) {
         b.providers.add(visitAuthProvider(authProvider, auth));

apps/cli/pubspec.yaml

@@ -20,6 +20,7 @@ dependencies:
   celest: ^1.0.0
   celest_ast: ^0.1.4
   celest_auth: ^1.0.0
+  celest_cloud_auth: ^0.1.0
   celest_core: ^1.0.0
   chunked_stream: ^1.4.2
   cli_script: ^1.0.0