Skip to content

Commit bd73fde

Browse files
authored
chore(test): Update linter/style preferences (#409)
- Ensures `celest_lints` is used - Applies latest linter/style preferences using dart fix - Re-formats using Dart 3.8
1 parent 8d826ad commit bd73fde

File tree

4 files changed

+56
-23
lines changed

4 files changed

+56
-23
lines changed

.github/workflows/celest_test.yaml

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
name: celest_test
2+
on:
3+
pull_request:
4+
paths:
5+
- ".github/workflows/celest_test.yaml"
6+
- "packages/celest_test/**"
7+
8+
# Prevent duplicate runs due to Graphite
9+
# https://graphite.dev/docs/troubleshooting#why-are-my-actions-running-twice
10+
concurrency:
11+
group: ${{ github.repository }}-${{ github.workflow }}-${{ github.ref }}-${{ github.ref == 'refs/heads/main' && github.sha || ''}}
12+
cancel-in-progress: true
13+
14+
permissions:
15+
contents: read
16+
17+
jobs:
18+
analyze_and_format:
19+
runs-on: ubuntu-latest
20+
timeout-minutes: 10
21+
steps:
22+
- name: Git Checkout
23+
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2
24+
- name: Setup Flutter
25+
uses: subosito/flutter-action@e938fdf56512cc96ef2f93601a5a40bde3801046 # 2.19.0
26+
with:
27+
channel: beta
28+
cache: true
29+
- name: Get Packages
30+
working-directory: packages/celest_test
31+
run: dart pub upgrade
32+
- name: Analyze
33+
working-directory: packages/celest_test
34+
run: dart analyze
35+
- name: Format
36+
working-directory: packages/celest_test
37+
run: dart format --language-version=latest --set-exit-if-changed .

packages/celest_test/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
## 0.1.1-wip
1+
## NEXT
22

33
- chore: Update dependencies
4+
- chore: Re-format with Dart 3.8
5+
- chore: Update linter/style preferences
46

57
## 0.1.0
68

packages/celest_test/lib/celest_test.dart

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ final class CelestTester {
1919
}) async {
2020
_logger.fine('Connecting to Celest service: $wsUri');
2121

22-
var uri = Uri.parse(wsUri);
22+
Uri uri = Uri.parse(wsUri);
2323
if (uri.host case '127.0.0.1' || 'localhost'
2424
when !kIsWeb && Platform.isAndroid) {
2525
uri = uri.replace(host: '10.0.2.2');
2626
}
2727

28-
final vmService = await vmServiceConnect(uri);
28+
final VmService vmService = await vmServiceConnect(uri);
2929
await vmService.streamListen(EventStreams.kExtension);
3030

3131
final tester = CelestTester._(vmService);
@@ -57,15 +57,12 @@ final class CelestAuthTester {
5757

5858
/// OTP codes sent to users during sign up/sign in.
5959
Stream<Otp> get onSentOtp async* {
60-
await for (final event in _vmService.onExtensionEvent) {
60+
await for (final Event event in _vmService.onExtensionEvent) {
6161
if (event.extensionKind != 'celest.cloud_auth.emailOtpSent') {
6262
continue;
6363
}
64-
final data = event.extensionData!.data;
65-
yield (
66-
to: data['to'] as String,
67-
code: data['code'] as String,
68-
);
64+
final Map<String, dynamic> data = event.extensionData!.data;
65+
yield (to: data['to'] as String, code: data['code'] as String);
6966
}
7067
}
7168
}

packages/celest_test/lib/src/vm_service_factory.dart

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,21 @@ import 'package:web_socket/web_socket.dart';
66
/// An implementation of the `vmServiceConnectUri` method from
77
/// `package:vm_service/vm_service_io.dart` which works on Web as well as VM.
88
Future<VmService> vmServiceConnect(Uri wsUri, {Log? log}) async {
9-
final socket = await WebSocket.connect(wsUri);
9+
final WebSocket socket = await WebSocket.connect(wsUri);
1010

1111
final controller = StreamController<dynamic>();
1212
final streamClosedCompleter = Completer<void>();
1313

14-
socket.events.listen(
15-
(event) {
16-
switch (event) {
17-
case TextDataReceived():
18-
controller.add(event.text);
19-
case BinaryDataReceived():
20-
controller.add(event.data);
21-
case CloseReceived():
22-
controller.close();
23-
}
24-
},
25-
onDone: streamClosedCompleter.complete,
26-
);
14+
socket.events.listen((event) {
15+
switch (event) {
16+
case TextDataReceived():
17+
controller.add(event.text);
18+
case BinaryDataReceived():
19+
controller.add(event.data);
20+
case CloseReceived():
21+
controller.close();
22+
}
23+
}, onDone: streamClosedCompleter.complete);
2724

2825
return VmService.defaultFactory(
2926
inStream: controller.stream,

0 commit comments

Comments
 (0)