refactor(cloud_auth)!: Consolidate session logic (#273)

- Adds new repos for sessions and users to consolidate logic and DB operations
- Makes all tokens issued by AuthenticationService be "session tokens"
  - Effectively, this makes all "identity tokens" now "access tokens" instead
- Adds DB migrations for column changes

Author: dnys1

apps/cli/lib/src/pub/project_dependency.dart

@@ -97,7 +97,7 @@ final class ProjectDependency {
     'celest_cloud_auth',
     DependencyType.dependency,
     HostedDependency(
-      version: VersionConstraint.compatibleWith(Version.parse('0.1.0')),
+      version: VersionConstraint.compatibleWith(Version.parse('0.2.0')),
     ),
   );
 

apps/cli/pubspec.yaml

@@ -20,7 +20,7 @@ dependencies:
   celest: ^1.0.0
   celest_ast: ^0.1.4
   celest_auth: ^1.0.0
-  celest_cloud_auth: ^0.1.0
+  celest_cloud_auth: ^0.2.0-0
   celest_core: ^1.0.0
   chunked_stream: ^1.4.2
   cli_script: ^1.0.0

packages/celest/build.yaml

@@ -2,4 +2,5 @@ targets:
   $default:
     sources:
       include:
+        - 'lib/$lib$'
         - 'test/runtime/data/**'

packages/celest_auth/example/integration_test/integration_test.dart

@@ -26,12 +26,6 @@ void main() {
       ),
       findsOneWidget,
     );
-
-    // TODO(dnys1): Fix unhandled exception.
-    final _ = tester.takeException();
-    addTearDown(() {
-      tester.takeException();
-    });
   });
 
   testWidgets('sends OTP code', (tester) async {
@@ -101,12 +95,10 @@ void main() {
       findsOneWidget,
     );
 
-    // TODO
-
     // Sign out
-    // await tester.tap(find.byKey(TestKeys.btnSignOut));
-    // await tester.pumpAndSettle();
+    await tester.tap(find.byKey(TestKeys.btnSignOut));
+    await tester.pumpAndSettle();
 
-    // expect(find.byKey(TestKeys.txtSignedOut), findsOneWidget);
+    expect(find.byKey(TestKeys.txtSignedOut), findsOneWidget);
   });
 }

packages/celest_auth/lib/src/auth_impl.dart

@@ -29,7 +29,7 @@ final class AuthImpl implements Auth {
         celest_cloud.CelestCloud(
           authenticator: Authenticator(
             secureStorage: _storage.secure,
-            onRevoke: signOut,
+            onRevoke: _revokeSession,
           ),
           uri: celest.baseUri,
           httpClient: celest.httpClient,
@@ -80,8 +80,7 @@ final class AuthImpl implements Auth {
     _authProviderSubs[type] = tokenSource.listen(
       (token) async {
         if (token == null) {
-          _reset();
-          _authStateController.add(const Unauthenticated());
+          _revokeSession();
           return;
         }
         await secureStorage.write('cork', token);
@@ -113,18 +112,18 @@ final class AuthImpl implements Auth {
       return initialState;
     }
     if (localStorage.read('userId') == null) {
-      _reset();
+      _revokeSession();
       return const Unauthenticated();
     }
     try {
       final user = await cloud.users.get('users/me');
       initialState = Authenticated(user: user.toCelest());
     } on UnauthorizedException {
       initialState = const Unauthenticated();
-      _reset();
+      _revokeSession();
     } on NotFoundException {
       initialState = const Unauthenticated();
-      _reset();
+      _revokeSession();
     }
     return initialState;
   }
@@ -197,16 +196,16 @@ final class AuthImpl implements Auth {
     } on Object {
       // TODO(dnys1): Log error
     } finally {
-      _reset();
-      if (!_authStateController.isClosed) {
-        _authStateController.add(const Unauthenticated());
-      }
+      _revokeSession();
     }
   }
 
-  void _reset() {
+  void _revokeSession() {
     localStorage.delete('userId');
-    secureStorage.delete('cork').ignore();
+    unawaited(secureStorage.delete('cork'));
+    if (_authState != null && !_authStateController.isClosed) {
+      _authStateController.add(const Unauthenticated());
+    }
   }
 
   final CelestBase celest;

services/celest_cloud_auth/CHANGELOG.md

@@ -1,3 +1,5 @@
+## 0.2.0-wip
+
 ## 0.1.1
 
 - fix: Ensure Cedar types are registered during seeding

services/celest_cloud_auth/Makefile

@@ -2,16 +2,11 @@ lib/src/database/schema/*.drift.dart: lib/src/database/schema/*.drift
 	@echo "Generating Drift code..."
 	@dart run build_runner build --delete-conflicting-outputs
 
-drift_schema/*.json: lib/src/database/schema/*.drift.dart
-	@echo "Generating schema JSON..."
-	@mkdir -p drift_schema
-	@dart run drift_dev schema dump lib/src/database/auth_database.dart drift_schema/
-
-lib/src/database/schema_versions.dart: drift_schema/*.json
+lib/src/database/auth_database.steps.dart: lib/src/database/auth_database.dart lib/src/database/schema/*.drift.dart
 	@echo "Generating migration steps..."
-	@dart run drift_dev schema steps drift_schema/ lib/src/database/schema_versions.dart
+	@dart run drift_dev make-migrations
 
-drift: lib/src/database/schema_versions.dart
+drift: lib/src/database/auth_database.steps.dart
 
 cedar: lib/src/authorization/cedar/*
 	@echo "Generating Cedar code..."

services/celest_cloud_auth/analysis_options.yaml

@@ -8,3 +8,4 @@ analyzer:
   exclude:
     - '**/*.g.dart'
     - '**/*.drift.dart'
+    - 'test/database/auth_database/generated'

services/celest_cloud_auth/build.yaml

@@ -8,6 +8,11 @@ targets:
       drift_dev:analyzer:
         enabled: true
         options: &options
+          databases:
+            auth_database: lib/src/database/auth_database.dart
+          schema_dir: drift_schema/
+          test_dir: test/database/
+
           named_parameters: true
           store_date_time_values_as_text: false