Skip to content

BlockedAddresses are incorrect #6175

@rootulp

Description

@rootulp

Context

#6174

Problem

The BlockedAddresses implementation is flawed. It gets module account addresses but treats them like account names.

celestia-app/app/app.go

Lines 650 to 651 in 013eb80

for acc := range app.ModuleAccountAddrs() {
modAccAddrs[authtypes.NewModuleAddress(acc).String()] = true

The BlockedAddresses are used by the bank keeper to prevent sending tokens to the blocked addresses.

Proposal

  1. Fix the implementation
  2. Add unit tests

Note: this change is breaking so can't be included until v7.

Metadata

Metadata

Assignees

Labels

WS: V7bugSomething isn't working

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions