chore: revert stopping the p2p connection on received invalid have part (#2640)

rach-id · web-flow · commit 30517119170f · 2025-11-13T15:00:48.000+01:00
This is temporarily not disconnecting from peers who send invalid have parts until this is worked on #2211
diff --git a/consensus/propagation/have_wants.go b/consensus/propagation/have_wants.go
@@ -56,7 +56,7 @@ func (blockProp *Reactor) handleHaves(peer p2p.ID, haves *proptypes.HaveParts) {
 	err := haves.ValidatePartHashes(cb.PartsHashes)
 	if err != nil {
 		blockProp.Logger.Error("received invalid have part", "height", haves.Height, "round", haves.Round, "err", err)
-		blockProp.Switch.StopPeerForError(p.peer, err, blockProp.String())
+		//blockProp.Switch.StopPeerForError(p.peer, err, blockProp.String())
 		return
 	}
 
diff --git a/consensus/propagation/have_wants_test.go b/consensus/propagation/have_wants_test.go
@@ -15,6 +15,7 @@ import (
 )
 
 func TestInvalidHavePartHash(t *testing.T) {
+	t.Skip("skipping TestInvalidHavePartHash until the issue is fixed")
 	p2pCfg := cfg.DefaultP2PConfig()
 	nodes := 2
 	reactors, _ := createTestReactors(nodes, p2pCfg, false, "")

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ func (blockProp Reactor) handleHaves(peer p2p.ID, haves proptypes.HaveParts) {`
`56`	`56`	`err := haves.ValidatePartHashes(cb.PartsHashes)`
`57`	`57`	`if err != nil {`
`58`	`58`	`blockProp.Logger.Error("received invalid have part", "height", haves.Height, "round", haves.Round, "err", err)`
`59`		`- blockProp.Switch.StopPeerForError(p.peer, err, blockProp.String())`
	`59`	`+ //blockProp.Switch.StopPeerForError(p.peer, err, blockProp.String())`
`60`	`60`	`return`
`61`	`61`	`}`
`62`	`62`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ import (`
`15`	`15`	`)`
`16`	`16`
`17`	`17`	`func TestInvalidHavePartHash(t *testing.T) {`
	`18`	`+ t.Skip("skipping TestInvalidHavePartHash until the issue is fixed")`
`18`	`19`	`p2pCfg := cfg.DefaultP2PConfig()`
`19`	`20`	`nodes := 2`
`20`	`21`	`reactors, _ := createTestReactors(nodes, p2pCfg, false, "")`