feat: add signers field to TxStatus (#2593)

Fixes #2595

Author: ninabarbakadze

abci/example/kvstore/kvstore.go

@@ -273,6 +273,7 @@ func (app *Application) FinalizeBlock(_ context.Context, req *types.RequestFinal
 					},
 				},
 			},
+			Signers: []string{"kvstore-app"}, // set signers for the tx
 		}
 		app.state.Size++
 	}

abci/types/types.pb.go

@@ -452,6 +452,7 @@ message ExecTxResult {
   repeated Event events     = 7
       [(gogoproto.nullable) = false, (gogoproto.jsontag) = "events,omitempty"];  // nondeterministic
   string codespace = 8;
+  repeated string signers = 9;
 }
 
 // TxResult contains results of executing the transaction.

proto/tendermint/abci/types.proto

@@ -24,4 +24,5 @@ message TxInfo {
   int64 gas_wanted = 6;
   // Actual gas consumed
   int64 gas_used = 7;
+  repeated string signers = 8; // tx signers
 }

proto/tendermint/store/types.pb.go

@@ -893,6 +893,7 @@ func TestTxStatus(t *testing.T) {
 	require.Equal("COMMITTED", result.Status)
 	require.Equal(abci.CodeTypeOK, result.ExecutionCode)
 	require.Equal("", result.Error)
+	require.Equal(bres.TxResult.Signers, result.Signers)
 }
 
 func TestDataCommitment(t *testing.T) {

proto/tendermint/store/types.proto

@@ -237,6 +237,7 @@ func (env *Environment) TxStatus(ctx *rpctypes.Context, hash []byte) (*ctypes.Re
 			Codespace:     txInfo.Codespace,
 			GasWanted:     txInfo.GasWanted,
 			GasUsed:       txInfo.GasUsed,
+			Signers:       txInfo.Signers,
 		}, nil
 	}
 

rpc/client/rpc_test.go

@@ -267,14 +267,15 @@ type ResultSignedBlock struct {
 // ResultTxStatus represents the status of a transaction during its life cycle.
 // It contains info to locate a tx in a committed block as well as its execution code, log if it fails and status.
 type ResultTxStatus struct {
-	Height        int64  `json:"height"`
-	Index         uint32 `json:"index"`
-	ExecutionCode uint32 `json:"execution_code"`
-	Error         string `json:"error"`
-	Status        string `json:"status"`
-	Codespace     string `json:"codespace,omitempty"`
-	GasWanted     int64  `json:"gas_wanted,omitempty"`
-	GasUsed       int64  `json:"gas_used,omitempty"`
+	Height        int64    `json:"height"`
+	Index         uint32   `json:"index"`
+	ExecutionCode uint32   `json:"execution_code"`
+	Error         string   `json:"error"`
+	Status        string   `json:"status"`
+	Codespace     string   `json:"codespace,omitempty"`
+	GasWanted     int64    `json:"gas_wanted,omitempty"`
+	GasUsed       int64    `json:"gas_used,omitempty"`
+	Signers       []string `json:"signers,omitempty"`
 }
 
 type ResultDataCommitment struct {

rpc/core/tx.go

@@ -812,6 +812,7 @@ func (bs *BlockStore) SaveTxInfo(block *types.Block, execTxRes []*abci.ExecTxRes
 			Codespace: result.Codespace,
 			GasWanted: result.GasWanted,
 			GasUsed:   result.GasUsed,
+			Signers:   result.Signers,
 		}
 		// Set error log for failed txs
 		if result.Code != abci.CodeTypeOK {

rpc/core/types/responses.go

@@ -795,6 +795,7 @@ func TestSaveTxInfo(t *testing.T) {
 				Data:      []byte("success_data"),
 				Info:      "successful execution",
 				Codespace: "",
+				Signers:   []string{"signer1"},
 			}
 		} else {
 			txResult = &abci.ExecTxResult{
@@ -805,6 +806,7 @@ func TestSaveTxInfo(t *testing.T) {
 				Data:      []byte(""),
 				Info:      "failed execution",
 				Codespace: "app",
+				Signers:   []string{"signer2"},
 			}
 		}
 
@@ -831,11 +833,13 @@ func TestSaveTxInfo(t *testing.T) {
 				require.Equal(t, "", txInfo.Codespace)
 				require.Equal(t, int64(75000), txInfo.GasUsed)
 				require.Equal(t, int64(100000), txInfo.GasWanted)
+				require.Equal(t, []string{"signer1"}, txInfo.Signers)
 			} else {
 				require.Equal(t, "app", txInfo.Codespace)
 				require.Equal(t, int64(25000), txInfo.GasUsed)
 				require.Equal(t, int64(50000), txInfo.GasWanted)
 				require.Equal(t, allTxLogs[txIndex], txInfo.Error)
+				require.Equal(t, []string{"signer2"}, txInfo.Signers)
 			}
 			txIndex++
 		}