fix(nodebuilder/tests): fix pruning and shrex test failures

TestArchivalBlobSync: the prunerOpts only replaced time.Duration, but
the pruner service uses share.Window for its availability window. Add
fx.Replace(modshare.Window(testAvailWindow)) for pruning nodes so the
pruner actually uses the 1ms window to prune historical data.

TestShrexFromLightsWithBadFulls: setTimeInterval was using testTimeout
(10min) as the AdvertiseInterval, preventing peer discovery for the
entire test duration. Use a fixed 20s interval instead.

TestHeaderSubscription: revert changes since the test already used
DefaultTestTimeout and the gossipsub issue with FanoutOnly in mocknet
is a pre-existing problem requiring deeper fixes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: rootulp

nodebuilder/tests/api_test.go

@@ -156,18 +156,7 @@ func TestHeaderSubscription(t *testing.T) {
 	err = light.Start(ctx)
 	require.NoError(t, err)
 
-	// Explicitly connect bridge and light, then wait for gossipsub mesh
-	// formation. Bridge nodes use FanoutOnly for header gossipsub, so we
-	// need to ensure the connection is established and gossipsub has
-	// exchanged subscription metadata before subscribing.
-	sw.Connect(t, bridge, light)
-
 	lightClient := getAdminClient(ctx, light, t)
-	// Wait for the light to sync a few headers (proves connectivity) and
-	// give gossipsub heartbeats time to propagate subscription info.
-	_, err = lightClient.Header.WaitForHeight(ctx, 3)
-	require.NoError(t, err)
-	time.Sleep(3 * time.Second)
 
 	// subscribe to headers via the light node's RPC header subscription
 	subctx, subcancel := context.WithCancel(ctx)

nodebuilder/tests/prune_test.go

@@ -20,6 +20,7 @@ import (
 	"github.com/celestiaorg/celestia-node/nodebuilder"
 	"github.com/celestiaorg/celestia-node/nodebuilder/node"
 	"github.com/celestiaorg/celestia-node/nodebuilder/pruner"
+	modshare "github.com/celestiaorg/celestia-node/nodebuilder/share"
 	"github.com/celestiaorg/celestia-node/nodebuilder/tests/swamp"
 	"github.com/celestiaorg/celestia-node/share"
 	full_avail "github.com/celestiaorg/celestia-node/share/availability/full"
@@ -88,6 +89,13 @@ func TestArchivalBlobSync(t *testing.T) {
 			)
 		}),
 	)
+	// pruningNodeOpts also replaces the share.Window so the pruner service
+	// uses the 1ms availability window (prunerOpts only replaces time.Duration
+	// which doesn't affect the pruner's share.Window-typed dependency).
+	pruningNodeOpts := fx.Options(
+		prunerOpts,
+		fx.Replace(modshare.Window(testAvailWindow)),
+	)
 
 	// wait until bn syncs to the latest submitted height
 	_, err = archivalFN.HeaderServ.WaitForHeight(ctx, heights[len(heights)-1])
@@ -101,14 +109,14 @@ func TestArchivalBlobSync(t *testing.T) {
 	sw.Bootstrappers = sw.Bootstrappers[:0]
 	sw.SetBootstrapper(t, archivalFN)
 
-	pruningBN := sw.NewBridgeNode(prunerOpts)
+	pruningBN := sw.NewBridgeNode(pruningNodeOpts)
 	err = pruningBN.Start(ctx)
 	require.NoError(t, err)
 
 	pruningFulls := make([]*nodebuilder.Node, 0, 3)
 	for range 3 {
 		cfg := sw.DefaultTestConfig(node.Bridge)
-		pruningFN := sw.NewNodeWithConfig(node.Bridge, cfg, prunerOpts)
+		pruningFN := sw.NewNodeWithConfig(node.Bridge, cfg, pruningNodeOpts)
 		err = pruningFN.Start(ctx)
 		require.NoError(t, err)
 

nodebuilder/tests/shrex_test.go

@@ -123,7 +123,7 @@ func TestShrexFromLightsWithBadFulls(t *testing.T) {
 	fulls := make([]*nodebuilder.Node, 0, amountOfFulls)
 	for i := 0; i < amountOfFulls; i++ {
 		cfg := sw.DefaultTestConfig(node.Bridge)
-		setTimeInterval(cfg, testTimeout)
+		setTimeInterval(cfg, time.Second*20)
 		full := sw.NewNodeWithConfig(node.Bridge, cfg, replaceShrexServer(cfg, ndHandler), replaceShareGetter())
 		fulls = append(fulls, full)
 	}