fix(lint): fix lint errors (#4760)

Author: vgonkivs

blob/service_test.go

@@ -469,7 +469,7 @@ func TestService_GetSingleBlobWithoutPadding(t *testing.T) {
 	rawShares1, err := BlobsToShares(blobs[1])
 	require.NoError(t, err)
 
-	rawShares := make([]libshare.Share, 0)
+	rawShares := make([]libshare.Share, 0) //nolint:prealloc
 	rawShares = append(rawShares, append(rawShares0, padding0)...)
 	rawShares = append(rawShares, append(rawShares1, padding1)...)
 	service := createService(ctx, t, rawShares)
@@ -544,7 +544,7 @@ func TestService_GetAllWithoutPadding(t *testing.T) {
 	blobs, err := convertBlobs(libBlob...)
 	require.NoError(t, err)
 
-	rawShares := make([]libshare.Share, 0)
+	rawShares := make([]libshare.Share, 0) //nolint:prealloc
 
 	require.NoError(t, err)
 	padding, err := libshare.NamespacePaddingShare(blobs[0].Namespace(), libshare.ShareVersionZero)

nodebuilder/da/service.go

@@ -116,7 +116,6 @@ func (s *Service) GetIDs(ctx context.Context, height uint64, namespace da.Namesp
 		return nil, err
 	}
 
-	var ids []da.ID //nolint:prealloc
 	log.Debugw("getting ids", "height", height, "namespace", ns)
 	blobs, err := s.blobServ.GetAll(ctx, height, []libshare.Namespace{ns})
 	log.Debugw("got ids", "height", height, "namespace", ns)
@@ -126,6 +125,8 @@ func (s *Service) GetIDs(ctx context.Context, height uint64, namespace da.Namesp
 		}
 		return nil, err
 	}
+
+	ids := make([]da.ID, 0, len(blobs))
 	for _, b := range blobs {
 		ids = append(ids, MakeID(height, b.Commitment))
 	}

share/eds/edstest/testing.go

@@ -130,7 +130,7 @@ func GenerateTestBlock(
 		blobSize,
 	)
 
-	txs := make(coretypes.Txs, 0)
+	txs := make(coretypes.Txs, 0) //nolint:prealloc
 	txs = append(txs, coreTxs...)
 
 	eds, err := da.ConstructEDS(txs.ToSliceOfBytes(), appconsts.Version, -1)
@@ -152,10 +152,10 @@ func createTestBlobTransactions(
 	t *testing.T,
 	numberOfTransactions, size int,
 ) ([]libshare.Namespace, []*blobtypes.MsgPayForBlobs, []*libshare.Blob, []coretypes.Tx) {
-	nss := make([]libshare.Namespace, 0)
-	msgs := make([]*blobtypes.MsgPayForBlobs, 0)
-	blobs := make([]*libshare.Blob, 0)
-	coreTxs := make([]coretypes.Tx, 0)
+	nss := make([]libshare.Namespace, 0, numberOfTransactions)
+	msgs := make([]*blobtypes.MsgPayForBlobs, 0, numberOfTransactions)
+	blobs := make([]*libshare.Blob, 0, numberOfTransactions)
+	coreTxs := make([]coretypes.Tx, 0, numberOfTransactions)
 	config := encoding.MakeConfig(app.ModuleEncodingRegisters...)
 	keyring := testfactory.TestKeyring(config.Codec, accountName)
 	account := user.NewAccount(accountName, 0, 0)

share/ipld/get_shares_test.go

@@ -176,7 +176,7 @@ func TestGetSharesByNamespace(t *testing.T) {
 			eds, err := AddShares(ctx, tt.rawData, bServ)
 			require.NoError(t, err)
 
-			var shares []libshare.Share
+			shares := make([]libshare.Share, 0)
 			rowRoots, err := eds.RowRoots()
 			require.NoError(t, err)
 			for _, row := range rowRoots {
@@ -373,7 +373,7 @@ func TestGetSharesWithProofsByNamespace(t *testing.T) {
 			eds, err := AddShares(ctx, tt.rawData, bServ)
 			require.NoError(t, err)
 
-			var shares []libshare.Share
+			shares := make([]libshare.Share, 0)
 			rowRoots, err := eds.RowRoots()
 			require.NoError(t, err)
 			for _, row := range rowRoots {
@@ -391,7 +391,7 @@ func TestGetSharesWithProofsByNamespace(t *testing.T) {
 					shares = append(shares, rowShares...)
 
 					// construct nodes from shares by prepending namespace
-					var leaves [][]byte
+					leaves := make([][]byte, 0, len(rowShares))
 					for _, shr := range rowShares {
 						leaves = append(leaves, append(shr.Namespace().Bytes(), shr.ToBytes()...))
 					}

share/shwap/namespace_data.go

@@ -21,7 +21,7 @@ type NamespaceData []RowNamespaceData
 
 // Flatten combines all shares from all rows within the namespace into a single slice.
 func (nd NamespaceData) Flatten() []libshare.Share {
-	var shares []libshare.Share
+	var shares []libshare.Share //nolint:prealloc
 	for _, row := range nd {
 		shares = append(shares, row.Shares...)
 	}

share/shwap/range_namespace_data.go

@@ -257,7 +257,7 @@ func (rngdata *RangeNamespaceData) verifyShares(
 // If the RangeNamespaceData is empty (i.e., contains no shares), Flatten returns nil.
 // Otherwise, it returns a flattened slice of libshare.Share combining shares from all rows.
 func (rngdata *RangeNamespaceData) Flatten() []libshare.Share {
-	var shares []libshare.Share
+	var shares []libshare.Share //nolint:prealloc
 	for _, shrs := range rngdata.Shares {
 		shares = append(shares, shrs...)
 	}