refactor(sync): simplify isExpired (#206)

Author: cristaloleg

sync/sync_head.go

@@ -198,7 +198,7 @@ func (s *Syncer[H]) verify(ctx context.Context, newHead H) (bool, error) {
 // isExpired checks if header is expired against trusting period.
 func isExpired[H header.Header[H]](header H, period time.Duration) bool {
 	expirationTime := header.Time().Add(period)
-	return !expirationTime.After(time.Now())
+	return expirationTime.Before(time.Now())
 }
 
 // isRecent checks if header is recent against the given recency threshold.

sync/sync_test.go

@@ -43,7 +43,7 @@ func TestSyncSimpleRequestingHead(t *testing.T) {
 	err = syncer.Start(ctx)
 	require.NoError(t, err)
 
-	time.Sleep(time.Millisecond * 10) // needs some to realize it is syncing
+	time.Sleep(time.Millisecond * 100) // needs some to realize it is syncing
 	err = syncer.SyncWait(ctx)
 	require.NoError(t, err)