adjust logging level for verify errors

Author: walldiss

p2p/exchange.go

@@ -174,11 +174,14 @@ func (ex *Exchange[H]) Head(ctx context.Context, opts ...header.HeadOption[H]) (
 						headerRespCh <- headers[0]
 						return
 					}
-					log.Errorw("verifying head received from tracked peer", "tracked peer", from,
+					logF := log.Warnw
+					if errors.Is(err, header.ErrKnownHeader) {
+						logF = log.Debugw
+					}
+					logF("verifying head received from tracked peer", "tracked peer", from,
 						"height", headers[0].Height(), "err", err)
 					headerRespCh <- zero
 					return
-
 				}
 			}
 			// request ensures that the result slice will have at least one Header

sync/sync_head.go

@@ -172,7 +172,12 @@ func (s *Syncer[H]) verify(ctx context.Context, newHead H) (bool, error) {
 
 	var verErr *header.VerifyError
 	if errors.As(err, &verErr) && !verErr.SoftFailure {
-		log.Errorw("invalid network header",
+		logF := log.Warnw
+		if errors.Is(err, header.ErrKnownHeader) {
+			logF = log.Debugw
+			log.Level()
+		}
+		logF("invalid network header",
 			"height_of_invalid", newHead.Height(),
 			"hash_of_invalid", newHead.Hash(),
 			"height_of_subjective", sbjHead.Height(),

verify.go

@@ -19,12 +19,7 @@ func Verify[H Header[H]](trstd, untrstd H, heightThreshold uint64) error {
 	// general mandatory verification
 	err := verify[H](trstd, untrstd, heightThreshold)
 	if err != nil {
-		verErr := &VerifyError{Reason: err}
-		if errors.Is(err, ErrKnownHeader) {
-			// if known, header is not *really* wrong, just already known and we can ignore it
-			verErr.SoftFailure = true
-		}
-		return verErr
+		return &VerifyError{Reason: err}
 	}
 	// user defined verification
 	err = trstd.Verify(untrstd)