fixes

Author: Wondertan

store/store.go

@@ -584,14 +584,6 @@ func (s *Store[H]) get(ctx context.Context, hash header.Hash) ([]byte, error) {
 // advanceHead moves contiguous Head forward if a newer one exists.
 // It looks throw caches, pending headers and datastore
 func (s *Store[H]) advanceHead(ctx context.Context) {
-	if log.Level() == zapcore.DebugLevel {
-		now := time.Now()
-		log.Debug("advancing head")
-		defer func() {
-			log.Debugw("finished advancing head", "took(s)", time.Since(now))
-		}()
-	}
-
 	newHead, changed := s.nextHead(ctx)
 	if changed {
 		s.contiguousHead.Store(&newHead)

store/store_delete.go

@@ -130,6 +130,10 @@ func (s *Store[H]) deleteSequential(ctx context.Context, from, to uint64) (err e
 		}
 	}
 
+	if err := batch.Commit(ctx); err != nil {
+		return fmt.Errorf("committing batch: %w", err)
+	}
+
 	return nil
 }
 

store/store_recover.go

@@ -10,46 +10,27 @@ import (
 // The new tail must be present in the store.
 // WARNING: Only use this function if you know what you are doing.
 func ResetTail[H header.Header[H]](ctx context.Context, store *Store[H], height uint64) error {
-	batch, err := store.ds.Batch(ctx)
-	if err != nil {
-		return err
-	}
-
-	err = store.setTail(ctx, batch, height)
-	if err != nil {
+	if err := store.setTail(ctx, store.ds, height); err != nil {
 		return err
 	}
 
-	err = batch.Commit(ctx)
-	if err != nil {
-		return err
-	}
 	return nil
 }
 
 // ResetHead resets the head of the store to be at the given height.
 // The new head must be present in the store.
 // WARNING: Only use this function if you know what you are doing.
 func ResetHead[H header.Header[H]](ctx context.Context, store *Store[H], height uint64) error {
-	batch, err := store.ds.Batch(ctx)
-	if err != nil {
-		return err
-	}
-
 	newHead, err := store.getByHeight(ctx, height)
 	if err != nil {
 		return err
 	}
 
-	if err := writeHeaderHashTo(ctx, batch, newHead, headKey); err != nil {
+	if err := writeHeaderHashTo(ctx, store.ds, newHead, headKey); err != nil {
 		return err
 	}
-	store.contiguousHead.Store(&newHead)
 
-	err = batch.Commit(ctx)
-	if err != nil {
-		return err
-	}
+	store.contiguousHead.Store(&newHead)
 	return nil
 }