fix(headertest): sanity check range (#166)

renaynay · web-flow · commit bdda26aab808 · 2024-03-15T14:02:12.000+01:00
diff --git a/headertest/store.go b/headertest/store.go
@@ -80,12 +80,11 @@ func (m *Store[H]) GetRangeByHeight(ctx context.Context, fromHead H, to uint64)
 }
 
 func (m *Store[H]) getRangeByHeight(ctx context.Context, from, to uint64) ([]H, error) {
-	amount := to - from
-	if amount == 0 {
-		return nil, fmt.Errorf("no headers requested")
+	if to <= from {
+		return nil, fmt.Errorf("malformed range, from: %d, to: %d", from, to)
 	}
 
-	headers := make([]H, amount)
+	headers := make([]H, to-from)
 
 	// As the requested range is [from; to),
 	// check that (to-1) height in request is less than

Original file line number	Diff line number	Diff line change
`@@ -80,12 +80,11 @@ func (m *Store[H]) GetRangeByHeight(ctx context.Context, fromHead H, to uint64)`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`func (m *Store[H]) getRangeByHeight(ctx context.Context, from, to uint64) ([]H, error) {`
`83`		`- amount := to - from`
`84`		`- if amount == 0 {`
`85`		`- return nil, fmt.Errorf("no headers requested")`
	`83`	`+ if to <= from {`
	`84`	`+ return nil, fmt.Errorf("malformed range, from: %d, to: %d", from, to)`
`86`	`85`	`}`
`87`	`86`
`88`		`- headers := make([]H, amount)`
	`87`	`+ headers := make([]H, to-from)`
`89`	`88`
`90`	`89`	`// As the requested range is [from; to),`
`91`	`90`	`// check that (to-1) height in request is less than`