fix(headertest): Return err not found in header store if not found (#148)

renaynay · web-flow · commit c34c25d653de · 2024-01-25T10:52:31.000-06:00
diff --git a/headertest/store.go b/headertest/store.go
@@ -62,7 +62,11 @@ func (m *Store[H]) Get(ctx context.Context, hash header.Hash) (H, error) {
 }
 
 func (m *Store[H]) GetByHeight(ctx context.Context, height uint64) (H, error) {
-	return m.Headers[height], nil
+	if header, exists := m.Headers[height]; exists {
+		return header, nil
+	}
+	var zero H
+	return zero, header.ErrNotFound
 }
 
 func (m *Store[H]) GetRange(ctx context.Context, from, to uint64) ([]H, error) {

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,11 @@ func (m *Store[H]) Get(ctx context.Context, hash header.Hash) (H, error) {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`func (m *Store[H]) GetByHeight(ctx context.Context, height uint64) (H, error) {`
`65`		`- return m.Headers[height], nil`
	`65`	`+ if header, exists := m.Headers[height]; exists {`
	`66`	`+ return header, nil`
	`67`	`+ }`
	`68`	`+ var zero H`
	`69`	`+ return zero, header.ErrNotFound`
`66`	`70`	`}`
`67`	`71`
`68`	`72`	`func (m *Store[H]) GetRange(ctx context.Context, from, to uint64) ([]H, error) {`