Update : [Remove duplicate code]

message :
1. Add user to model
2. Remove login state duplicate action

Author: celvineadiputra-dev

src/test/java/config/Auth.java

@@ -0,0 +1,29 @@
+package config;
+
+import config.models.User;
+
+public class Auth {
+    private final User standardUser;
+    private final User fakeUser;
+
+    public Auth() {
+        this.standardUser = new User("standard_user", "secret_sauce");
+        this.fakeUser = new User("", "secret_sauce");
+    }
+
+    public String getUserNameStandardUser() {
+        return this.standardUser.getUserName();
+    }
+
+    public String getPasswordStandardUser() {
+        return this.standardUser.getPassword();
+    }
+
+    public String getUserNameFakeUser() {
+        return this.fakeUser.getUserName();
+    }
+
+    public String getPasswordFakeUser() {
+        return this.fakeUser.getPassword();
+    }
+}

src/test/java/config/Config.java

@@ -2,6 +2,11 @@
 
 public class Config {
     private final String baseUrl = "https://www.saucedemo.com/";
+    public final Auth auth;
+
+    public Config() {
+        this.auth = new Auth();
+    }
 
     public String getBaseUrl() {
         return this.baseUrl;

src/test/java/config/models/User.java

@@ -0,0 +1,18 @@
+package config.models;
+
+public class User {
+    private final String userName, password;
+
+    public User(String userName, String password) {
+        this.userName = userName;
+        this.password = password;
+    }
+
+    public String getUserName() {
+        return userName;
+    }
+
+    public String getPassword() {
+        return password;
+    }
+}

src/test/java/resources/features/addToCart.feature

@@ -1,7 +1,7 @@
 Feature: Add Product to Cart
 
   Background:
-    Given The user is logged in
+    Given The user should be logged in
 
   Scenario: User successfully adds a product to the cart
     When The user clicks the add to cart button

src/test/java/resources/features/login.feature

@@ -1,23 +1,15 @@
 Feature: Login feature
 
-  Scenario Outline: User successfully logs in with valid credentials
+  Scenario: User successfully logs in with valid credentials
     Given The user opens the web page or app
-    When The user enters <username> as username
-    And The user enters <password> as password
+    When The user enters valid as username
+    And The user enters valid as password
     And The user clicks the login button
     Then The user should be logged in successfully
 
-    Examples:
-      | username      | password     |
-      | standard_user | secret_sauce |
-
-  Scenario Outline: User fails to log in with invalid credentials
+  Scenario: User failed logs in with valid credentials
     Given The user opens the web page or app
-    When The user enters <username> as username
-    And The user enters <password> as password
+    When The user enters invalid as username
+    And The user enters invalid as password
     And The user clicks the login button
-    Then The user should see an authentication error message
-
-    Examples:
-      | username | password |
-      | example  | 123      |
+    Then The user should be see error message

src/test/java/runner/RunAddToCart.java

@@ -8,7 +8,7 @@
 @CucumberOptions(
         features = "src/test/java/resources/features",
         glue = "stepDef",
-        plugin = {"html:target/Login_report.html"}
+        plugin = {"html:target/ReportTesting.html"}
 )
-public class RunLogin {
+public class Runner {
 }

src/test/java/runner/RunLogin.java src/test/java/runner/Runner.javasrc/test/java/runner/RunLogin.java renamed to src/test/java/runner/Runner.java

@@ -2,7 +2,6 @@
 
 import config.SetupDriver;
 import config.elements.ElementFormLogin;
-import io.cucumber.java.After;
 import io.cucumber.java.en.And;
 import io.cucumber.java.en.Given;
 import io.cucumber.java.en.Then;
@@ -25,16 +24,28 @@ public void userAlreadyOpenApp() {
         assertEquals("Swag Labs", currentTitle);
     }
 
-    @When("The user enters (.*) as username$")
-    public void userInputUserName(String username) {
+    @When("The user enters valid as username")
+    public void userInputUserName() {
         WebElement userNameField = this.elementFormLogin.userName();
-        userNameField.sendKeys(username);
+        userNameField.sendKeys(this.config.auth.getUserNameStandardUser());
     }
 
-    @And("The user enters (.*) as password$")
-    public void userInputPassword(String password) {
+    @And("The user enters valid as password")
+    public void userInputPassword() {
         WebElement passwordElement = this.elementFormLogin.password();
-        passwordElement.sendKeys(password);
+        passwordElement.sendKeys(this.config.auth.getPasswordStandardUser());
+    }
+
+    @When("The user enters invalid as username")
+    public void userInputInValidUserName() {
+        WebElement userNameField = this.elementFormLogin.userName();
+        userNameField.sendKeys(this.config.auth.getUserNameFakeUser());
+    }
+
+    @And("The user enters invalid as password")
+    public void userInputInValidPassword() {
+        WebElement passwordElement = this.elementFormLogin.password();
+        passwordElement.sendKeys(this.config.auth.getPasswordFakeUser());
     }
 
     @And("The user clicks the login button")
@@ -49,15 +60,15 @@ public void userSuccessfullyLogin() {
         Assertions.assertEquals(this.config.currentUrl("inventory.html"), currentUrl);
     }
 
-    @Then("The user should see an authentication error message")
-    public void userShouldSeeAnAuthenticationErrorMessage() {
+    @Then("The user should be see error message")
+    public void userFailedLogin() {
         int errorAlert = this.elementFormLogin.sizeErrorAlert();
 
         assertEquals(1, errorAlert);
     }
 
-    @After(order = 0)
-    public void closeBrowser() {
-        webDriver.close();
-    }
+//    @After(order = 0)
+//    public void closeBrowser() {
+//        webDriver.close();
+//    }
 }

src/test/java/stepDef/Login.java

@@ -0,0 +1,25 @@
+package stepDef;
+
+import config.SetupDriver;
+import config.elements.ElementFormLogin;
+import io.cucumber.java.en.Given;
+import org.openqa.selenium.WebElement;
+
+public class State extends SetupDriver {
+    private final ElementFormLogin elementFormLogin;
+
+    public State() {
+        this.elementFormLogin = new ElementFormLogin(super.webDriver);
+    }
+
+    @Given("The user should be logged in")
+    public void login() {
+        WebElement userNameField = this.elementFormLogin.userName();
+        WebElement passwordField = this.elementFormLogin.password();
+
+        userNameField.sendKeys(this.config.auth.getUserNameStandardUser());
+        passwordField.sendKeys(this.config.auth.getPasswordStandardUser());
+
+        this.elementFormLogin.loginButton().click();
+    }
+}