netstack/fdbased: close fd on swap err

ignoramous · ignoramous · commit 32e92b08346f · 2025-08-21T21:19:09.000+05:30
diff --git a/intra/netstack/fdbased.go b/intra/netstack/fdbased.go
@@ -289,7 +289,8 @@ func (e *endpoint) swap(fd int, force bool) (err error) {
 	f, err := newTun(fd) // fd may be invalid (ex: -1)
 	if err != nil || f == nil {
 		f = invalidFds // nilaway
-		err = log.EE("ns: tun(%d): swap: err: %v / %v; using invalidfd", fd, err)
+		clos(fd)
+		return log.EE("ns: tun(%d): swap: err: %v / %v; using invalidfd", fd, err)
 	}
 
 	e.fds.Store(f) // commence WritePackets() on fd

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,8 @@ func (e *endpoint) swap(fd int, force bool) (err error) {`
`289`	`289`	`f, err := newTun(fd) // fd may be invalid (ex: -1)`
`290`	`290`	`if err != nil \|\| f == nil {`
`291`	`291`	`f = invalidFds // nilaway`
`292`		`- err = log.EE("ns: tun(%d): swap: err: %v / %v; using invalidfd", fd, err)`
	`292`	`+ clos(fd)`
	`293`	`+ return log.EE("ns: tun(%d): swap: err: %v / %v; using invalidfd", fd, err)`
`293`	`294`	`}`
`294`	`295`
`295`	`296`	`e.fds.Store(f) // commence WritePackets() on fd`