netstack/forwarders: do not unlock unlocked mutex

ignoramous · ignoramous · commit 8eff8d00e261 · 2026-01-09T22:41:46.000+05:30
diff --git a/intra/netstack/forwarders.go b/intra/netstack/forwarders.go
@@ -177,11 +177,10 @@ func (p *processor) deliverPackets() {
 		pkt := p.pkts.PopFront()
 		p.mu.Unlock()
 		if pkt != nil {
-			if p.icmp.respond(pkt) {
-				return
+			if !p.icmp.respond(pkt) {
+				p.e.InjectInbound(pkt.NetworkProtocolNumber, pkt)
+				pkt.DecRef()
 			}
-			p.e.InjectInbound(pkt.NetworkProtocolNumber, pkt)
-			pkt.DecRef()
 		}
 		p.mu.Lock()
 	}

Original file line number	Diff line number	Diff line change
`@@ -177,11 +177,10 @@ func (p *processor) deliverPackets() {`
`177`	`177`	`pkt := p.pkts.PopFront()`
`178`	`178`	`p.mu.Unlock()`
`179`	`179`	`if pkt != nil {`
`180`		`- if p.icmp.respond(pkt) {`
`181`		`- return`
	`180`	`+ if !p.icmp.respond(pkt) {`
	`181`	`+ p.e.InjectInbound(pkt.NetworkProtocolNumber, pkt)`
	`182`	`+ pkt.DecRef()`
`182`	`183`	`}`
`183`		`- p.e.InjectInbound(pkt.NetworkProtocolNumber, pkt)`
`184`		`- pkt.DecRef()`
`185`	`184`	`}`
`186`	`185`	`p.mu.Lock()`
`187`	`186`	`}`