netstack/icmp: okay to crash on panics

ignoramous · ignoramous · commit 9887a76ad235 · 2026-01-10T00:40:01.000+05:30
diff --git a/intra/netstack/icmpecho.go b/intra/netstack/icmpecho.go
@@ -146,7 +146,7 @@ func (r *icmpResponder) handle(nic tcpip.NICID, pkt *stack.PacketBuffer) (handle
 		return r.forward(h, pkt, src, dst)
 	} else {
 		// Process asynchronously to avoid blocking the dispatcher loop.
-		core.Go("icmp.responder", func() {
+		core.Gx("icmp.responder", func() {
 			r.process(h, nic, parsed, src, dst)
 		})
 	}

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ func (r icmpResponder) handle(nic tcpip.NICID, pkt stack.PacketBuffer) (handle`
`146`	`146`	`return r.forward(h, pkt, src, dst)`
`147`	`147`	`} else {`
`148`	`148`	`// Process asynchronously to avoid blocking the dispatcher loop.`
`149`		`- core.Go("icmp.responder", func() {`
	`149`	`+ core.Gx("icmp.responder", func() {`
`150`	`150`	`r.process(h, nic, parsed, src, dst)`
`151`	`151`	`})`
`152`	`152`	`}`