core/overreach: append to runtime envs var is pointless

ignoramous · ignoramous · commit bc08e031b6aa · 2026-01-14T22:04:30.000+05:30
diff --git a/intra/core/overreach.go b/intra/core/overreach.go
@@ -70,14 +70,12 @@ func SetRuntimeEnviron(key, val string) (found bool, err error) {
 	for i, e := range envs {
 		if len(e) >= len(kv) && e[:len(kv)] == kv {
 			envs[i] = kv + val
+			err = os.Setenv(key, val)
 			found = true
 			break
 		}
 	}
-	if !found {
-		envs = append(envs, kv+val)
-	}
-	return found, os.Setenv(key, val)
+	return
 }
 
 // GetRuntimeEnviron gets a value from the Go runtime's cached

Original file line number	Diff line number	Diff line change
`@@ -70,14 +70,12 @@ func SetRuntimeEnviron(key, val string) (found bool, err error) {`
`70`	`70`	`for i, e := range envs {`
`71`	`71`	`if len(e) >= len(kv) && e[:len(kv)] == kv {`
`72`	`72`	`envs[i] = kv + val`
	`73`	`+ err = os.Setenv(key, val)`
`73`	`74`	`found = true`
`74`	`75`	`break`
`75`	`76`	`}`
`76`	`77`	`}`
`77`		`- if !found {`
`78`		`- envs = append(envs, kv+val)`
`79`		`- }`
`80`		`- return found, os.Setenv(key, val)`
	`78`	`+ return`
`81`	`79`	`}`
`82`	`80`
`83`	`81`	`// GetRuntimeEnviron gets a value from the Go runtime's cached`