ipn/se: m docs, var names

Author: ignoramous

intra/common.go

@@ -227,21 +227,23 @@ func (h *baseHandler) onFlow(localaddr, target netip.AddrPort) (fm *Mark, undidA
 		return h.listener.Flow(proto, int32(uid), x.StrOf(src), x.StrOf(dst), x.StrOf(ips), x.StrOf(doms), x.StrOf(pdoms), x.StrOf(blocklists)), nil
 	}, onFlowTimeout)
 
+	loopback := settings.Loopingback.Load()
+
 	if fm == nil || !ok { // zeroListener returns nil
 		log.W("com: %s: onFlow: empty res or on flow timeout %t; block!", h.proto, ok)
 		fm = optionsBlock
 	} else if len(fm.PIDCSV) <= 0 {
+		fm.PIDCSV = ipn.Exit
 		if preuid == SELF_UID {
-			fm.PIDCSV = ipn.Exit
-		} else if h.prox.AutoActive() {
-			fm.PIDCSV = ipn.Auto
-		} else {
-			fm.PIDCSV = ipn.Exit
+			if loopback {
+				fm.PIDCSV = ipn.Base
+			} else if h.prox.AutoActive() {
+				fm.PIDCSV = ipn.Auto
+			}
 		}
 		log.E("com: %s: onFlow: missing proxyid for preuid %s (%s => %s) from kt (alg: %v + %v); %s!",
 			h.proto, preuid, src, dst, ips, doms, fm.PIDCSV)
 	}
-	loopback := settings.Loopingback.Load()
 	// in loopback mode, user may have setup SELF_UID to be routed out via remote proxies.
 	// in other cases, routing Rethink via remote proxies is probably a bug.
 	if !loopback && preuid == SELF_UID && !ipn.IsAnyLocalProxy(strings.Split(fm.PIDCSV, ",")...) {

intra/ipn/seproxy.go

@@ -110,25 +110,25 @@ var _ Proxy = (*seproxy)(nil)
 var _ proxy.Dialer = (*sedialer)(nil)
 
 // NewSEasyProxy returns a new seproxy.
-func NewSEasyProxy(ctx context.Context, c protect.Controller, px ProxyProvider, sec *seasy.SEApi) (*seproxy, error) {
-	if sec == nil {
+func NewSEasyProxy(ctx context.Context, c protect.Controller, px ProxyProvider, seapi *seasy.SEApi) (*seproxy, error) {
+	if seapi == nil {
 		return nil, errMissingSEClient
 	}
 
 	ctx, done := context.WithCancel(ctx)
-	if _, err := sec.Start(ctx); err != nil {
+	if _, err := seapi.Start(ctx); err != nil {
 		done()
 		return nil, err
 	}
 
-	endpoints := sec.Endpoints()
+	endpoints := seapi.Endpoints()
 	if len(endpoints) <= 0 { // unlikely
 		done()
 		return nil, errSENoEndpoints
 	}
 
 	authfn := func() string {
-		return headerBasicAuth(sec.GetProxyCredentials())
+		return headerBasicAuth(seapi.GetProxyCredentials())
 	}
 
 	var missingcert *x509.Certificate
@@ -145,8 +145,8 @@ func NewSEasyProxy(ctx context.Context, c protect.Controller, px ProxyProvider,
 
 	sep := &seproxy{
 		done:        done,
-		sec:         sec,
-		addrs:       sec.Addrs(),
+		sec:         seapi,
+		addrs:       seapi.Addrs(),
 		px:          px,
 		viaID:       core.NewZeroVolatile[string](),
 		lastRefresh: core.NewVolatile(now),

intra/settings/proxyopts.go

@@ -138,7 +138,7 @@ func (m AutoModeType) String() string {
 	}
 }
 
-// SetAutoMode sets the global AutoMode variable to y.
+// SetAutoMode sets the global AutoMode variable to m.
 // Indicates if backend.Auto proxy is in local, remote, or hybrid mode.
 func SetAutoMode(m int32) (prev int32) {
 	m = max(m, AutoModeLocal)